fix(console): gate the AI surface on the service-ai capability (discovery), not the agent catalog by os-zhuang · Pull Request #1992 · objectstack-ai/objectui

os-zhuang · 2026-06-25T04:23:09Z

Why

Follow-up to #1987 (and the framework's #2311).

@objectstack/service-ai is an enterprise capability — the Community Edition does not depend on it. So the console's AI gate should key off whether service-ai is present (discovery's services.ai), not the agent catalog.

#1987 gated on a non-empty agent catalog as a workaround: at the time, a CE-shaped runtime still loaded the headless AI service and reported services.ai: available with no agents, so a discovery-based gate would have shown AI with nothing behind it. The framework now (#2311) only registers the AI service when the host app declares @objectstack/service-ai, so discovery is an honest edition signal:

CE (no service-ai) → services.ai: { enabled: false, status: "unavailable" } → AI surface hides.
Enterprise (service-ai present) → services.ai: available → AI shows — even if no specific agent is configured yet (the capability is what matters; AiChatPage degrades gracefully on an empty catalog).

What changed

Only useAiSurfaceEnabled:

// before (#1987): catalog-based
const { agents } = useAgents({ apiBase: resolveAiApiBase() });
return { enabled: agents.length > 0, ... };

// after: discovery / service-ai capability
const { isAiEnabled, isLoading } = useDiscovery();
if (aiBaseUrlConfigured) return { enabled: true, isLoading: false };
return { enabled: isAiEnabled, isLoading };

Everything else from #1987 stays — the centralized hook, the RequireAiSurface /ai route guard, the gated top-bar AI link + designer "Ask AI" buttons, and AiChatPage's graceful "AI unavailable" empty state. resolveAiApiBase is kept (HomePage still uses it for its per-agent CTAs).

Verification

app-shell tsc clean; console full tsc && vite build clean.
Full app-shell suite green (874 passing), incl. the rewritten useAiSurface.test.ts (discovery on/off/loading).
CE correctness of the discovery signal (services.ai: unavailable when no service-ai) was established end-to-end in framework fix(components): also toast form submit errors so they're visible past the fold #2311.

🤖 Generated with Claude Code

…he agent catalog useAiSurfaceEnabled now keys off discovery's `services.ai` (isAiEnabled) — i.e. whether the enterprise @objectstack/service-ai capability is present — instead of a non-empty agent catalog. service-ai is an enterprise capability; a Community-Edition runtime doesn't ship it, so the framework doesn't register the AI service and discovery reports services.ai unavailable → the whole AI surface hides. An install that has service-ai reports it available → AI shows. The presence of the CAPABILITY gates, not whether a specific agent is configured yet. The earlier catalog-based gating was a workaround for the headless service-ai reporting itself available in CE. The framework now only registers the AI service when the host app declares @objectstack/service-ai (objectstack-ai/framework#2311), so discovery is an honest edition signal and the catalog detour is gone. Everything else from the original gating stays: the centralized hook, the RequireAiSurface /ai route guard, the gated top-bar link + designer "Ask AI" buttons, and AiChatPage's graceful empty state. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>

vercel · 2026-06-25T04:23:15Z

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment

Project	Deployment	Actions	Updated (UTC)
objectui	Ignored		Jun 25, 2026 4:23am

github-actions · 2026-06-25T04:26:42Z

✅ Console Performance Budget

Metric	Value	Budget
Main entry (gzip)	58.8 KB	350 KB
Entry file	`index-DUBkJLed.js`	—
Status	PASS	—

📦 Bundle Size Report

Package	Size	Gzipped
app-shell (index.js)	6.87KB	2.47KB
app-shell (runtime-config.js)	4.72KB	1.69KB
app-shell (types.js)	0.01KB	0.04KB
auth (AuthContext.js)	0.31KB	0.24KB
auth (AuthGuard.js)	1.17KB	0.53KB
auth (AuthProvider.js)	17.16KB	3.44KB
auth (AuthShell.js)	3.49KB	1.40KB
auth (ForgotPasswordForm.js)	4.79KB	1.88KB
auth (LoginForm.js)	5.11KB	1.92KB
auth (PreviewBanner.js)	0.90KB	0.50KB
auth (RegisterForm.js)	6.63KB	2.15KB
auth (SocialSignInButtons.js)	8.89KB	3.61KB
auth (UserMenu.js)	3.40KB	1.22KB
auth (authStyles.js)	5.04KB	1.72KB
auth (createAuthClient.js)	24.74KB	6.00KB
auth (createAuthenticatedFetch.js)	3.33KB	1.32KB
auth (index.js)	1.75KB	0.76KB
auth (types.js)	0.59KB	0.35KB
auth (useAuth.js)	4.01KB	0.79KB
auth (useIsWorkspaceAdmin.js)	1.28KB	0.70KB
collaboration (CommentThread.js)	18.38KB	4.49KB
collaboration (LiveCursors.js)	3.17KB	1.27KB
collaboration (PresenceAvatars.js)	3.65KB	1.42KB
collaboration (PresenceProvider.js)	2.42KB	0.96KB
collaboration (index.js)	1.25KB	0.53KB
collaboration (useCommentSearch.js)	1.98KB	0.88KB
collaboration (useConflictResolution.js)	7.75KB	1.86KB
collaboration (useMentionNotifications.js)	1.81KB	0.68KB
collaboration (usePresence.js)	6.33KB	1.84KB
collaboration (useRealtimeSubscription.js)	7.91KB	2.01KB
components (index.js)	418.42KB	89.09KB
core (index.js)	1.52KB	0.55KB
create-plugin (index.js)	9.28KB	2.98KB
data-objectstack (index.js)	99.69KB	24.89KB
fields (index.js)	166.21KB	40.08KB
i18n (LocalizationContext.js)	1.76KB	0.96KB
i18n (currency.js)	1.22KB	0.64KB
i18n (i18n.js)	4.32KB	1.77KB
i18n (index.js)	2.46KB	0.96KB
i18n (pickLocalized.js)	1.31KB	0.67KB
i18n (provider.js)	5.37KB	1.72KB
i18n (useObjectLabel.js)	21.15KB	4.68KB
i18n (useSafeTranslation.js)	2.68KB	0.98KB
layout (index.js)	36.30KB	10.04KB
mobile (MobileProvider.js)	0.92KB	0.49KB
mobile (ResponsiveContainer.js)	0.94KB	0.38KB
mobile (breakpoints.js)	1.51KB	0.70KB
mobile (createOfflineDataSource.js)	5.61KB	1.74KB
mobile (index.js)	1.50KB	0.62KB
mobile (offlineQueue.js)	3.91KB	1.35KB
mobile (pwa.js)	0.97KB	0.49KB
mobile (serviceWorker.js)	1.48KB	0.62KB
mobile (serviceWorkerSource.js)	3.41KB	1.48KB
mobile (useBreakpoint.js)	1.54KB	0.65KB
mobile (useGesture.js)	4.42KB	1.27KB
mobile (useOfflineSync.js)	1.99KB	0.72KB
mobile (usePullToRefresh.js)	2.53KB	0.85KB
mobile (useResponsive.js)	0.71KB	0.42KB
mobile (useResponsiveConfig.js)	1.36KB	0.63KB
mobile (useSpecGesture.js)	1.77KB	0.77KB
mobile (useTouchTarget.js)	1.01KB	0.54KB
permissions (MePermissionsProvider.js)	5.09KB	1.84KB
permissions (PermissionContext.js)	0.31KB	0.25KB
permissions (PermissionGuard.js)	0.89KB	0.45KB
permissions (PermissionProvider.js)	3.46KB	1.03KB
permissions (evaluator.js)	4.00KB	1.23KB
permissions (index.js)	0.91KB	0.41KB
permissions (store.js)	0.91KB	0.42KB
permissions (useFieldPermissions.js)	1.28KB	0.52KB
permissions (usePermissions.js)	1.50KB	0.70KB
plugin-ai (index.js)	15.71KB	3.79KB
plugin-calendar (index.js)	45.98KB	12.65KB
plugin-charts (index.js)	45.46KB	12.78KB
plugin-chatbot (index.js)	153.41KB	37.19KB
plugin-dashboard (index.js)	107.36KB	26.65KB
plugin-designer (index.js)	213.42KB	42.94KB
plugin-detail (index.js)	195.59KB	47.19KB
plugin-editor (index.js)	2.38KB	1.06KB
plugin-form (index.js)	93.23KB	22.71KB
plugin-gantt (index.js)	136.68KB	33.88KB
plugin-grid (index.js)	120.86KB	32.74KB
plugin-kanban (index.js)	48.82KB	13.13KB
plugin-list (index.js)	94.53KB	22.32KB
plugin-map (index.js)	16.02KB	4.98KB
plugin-markdown (index.js)	13.58KB	4.64KB
plugin-report (index.js)	37.83KB	9.97KB
plugin-timeline (index.js)	25.37KB	7.20KB
plugin-tree (index.js)	8.04KB	2.70KB
plugin-view (index.js)	84.45KB	20.36KB
providers (DataSourceProvider.js)	0.75KB	0.39KB
providers (MetadataProvider.js)	1.37KB	0.59KB
providers (ThemeProvider.js)	1.55KB	0.67KB
providers (UploadProvider.js)	11.71KB	3.53KB
providers (index.js)	0.44KB	0.22KB
providers (types.js)	0.01KB	0.04KB
react (LazyPluginLoader.js)	3.77KB	1.33KB
react (SchemaRenderer.js)	18.23KB	5.97KB
react (index.js)	0.76KB	0.42KB
tenant (TenantContext.js)	0.31KB	0.25KB
tenant (TenantGuard.js)	1.04KB	0.43KB
tenant (TenantProvider.js)	2.76KB	0.98KB
tenant (TenantScopedQuery.js)	0.77KB	0.44KB
tenant (index.js)	0.75KB	0.38KB
tenant (resolver.js)	2.64KB	0.76KB
tenant (useTenant.js)	0.50KB	0.32KB
tenant (useTenantBranding.js)	0.62KB	0.39KB
types (ai.js)	0.20KB	0.17KB
types (api-types.js)	0.20KB	0.18KB
types (app.js)	2.87KB	0.99KB
types (base.js)	0.20KB	0.18KB
types (blocks.js)	0.20KB	0.18KB
types (complex.js)	0.20KB	0.18KB
types (crud.js)	0.20KB	0.18KB
types (data-display.js)	0.20KB	0.18KB
types (data-protocol.js)	0.20KB	0.19KB
types (data.js)	0.20KB	0.18KB
types (designer.js)	0.77KB	0.41KB
types (disclosure.js)	0.20KB	0.18KB
types (feedback.js)	0.20KB	0.18KB
types (field-types.js)	0.20KB	0.18KB
types (form.js)	0.20KB	0.18KB
types (index.js)	1.54KB	0.68KB
types (layout.js)	0.20KB	0.18KB
types (mobile.js)	0.20KB	0.18KB
types (navigation.js)	0.20KB	0.18KB
types (objectql.js)	0.20KB	0.18KB
types (overlay.js)	0.20KB	0.18KB
types (permissions.js)	0.20KB	0.18KB
types (plugin-scope.js)	0.20KB	0.18KB
types (record-components.js)	0.20KB	0.19KB
types (registry.js)	0.20KB	0.18KB
types (reports.js)	0.20KB	0.18KB
types (spec-report.js)	5.26KB	1.96KB
types (tenant.js)	0.20KB	0.18KB
types (theme.js)	0.20KB	0.18KB
types (ui-action.js)	0.75KB	0.46KB
types (views.js)	0.20KB	0.18KB
types (widget.js)	0.20KB	0.18KB

Size Limits

✅ Core packages should be < 50KB gzipped
✅ Component packages should be < 100KB gzipped
⚠️ Plugin packages should be < 150KB gzipped

…ot discovery (per-user AI seat) (#1993) Reverts objectui#1992. `useAiSurfaceEnabled` keys off `GET /api/v1/ai/agents` again (>= 1 agent → AI shows). That route is now access-filtered server-side (framework ADR-0049 / ADR-0068): it returns only the agents the CALLER may chat, so a user WITHOUT the per-user AI seat (`ai_seat`) gets an empty catalog and the ENTIRE AI surface — FAB, `/ai` routes, top-bar + designer "Ask AI" — hides for them, instead of showing a control that 403s on click. #1992 had moved the gate to the deployment-wide discovery `services.ai` capability, which is identical for every user and so cannot express per-user seating — the wrong signal for the AI-seat gate. Community-Edition gating is unaffected (no service-ai → no agents → empty catalog → hidden). Updated the hook docs with a "do NOT flip back to discovery" note so the per-user dimension isn't dropped again. app-shell builds clean; useAiSurface tests (4) green. The catalog's per-user filtering is proven server-side (framework branch feat/ai-seat-catalog-filter): seated user → ['build','ask'], seat-less → []. Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>

github-actions Bot added the tests label Jun 25, 2026

os-zhuang merged commit 8a3b351 into main Jun 25, 2026
10 checks passed

os-zhuang deleted the feat/ai-gate-on-service-ai branch June 25, 2026 04:31

os-zhuang mentioned this pull request Jun 25, 2026

fix(console): gate AI surface on the access-filtered agent catalog, not discovery (per-user AI seat) #1993

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fix(console): gate the AI surface on the service-ai capability (discovery), not the agent catalog#1992

fix(console): gate the AI surface on the service-ai capability (discovery), not the agent catalog#1992
os-zhuang merged 1 commit into
mainfrom
feat/ai-gate-on-service-ai

os-zhuang commented Jun 25, 2026

Uh oh!

vercel Bot commented Jun 25, 2026

Uh oh!

github-actions Bot commented Jun 25, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Uh oh!

Conversation

os-zhuang commented Jun 25, 2026

Why

What changed

Verification

Uh oh!

vercel Bot commented Jun 25, 2026

Uh oh!

github-actions Bot commented Jun 25, 2026

✅ Console Performance Budget

📦 Bundle Size Report

Size Limits

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant