chore: drop compactLayout fallback reads (alias retired by framework#2536)#2187
Merged
Conversation
…2536) framework#2539 removed the deprecated spelling from the spec (create() rejects, parse strips, no mirror) — served metadata carries highlightFields only, so these 6 fallback reads can never fire again. deriveHighlightFields tests flipped: the retired spelling is now IGNORED (heuristic applies) instead of read. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
Contributor
✅ Console Performance Budget
📦 Bundle Size Report
Size Limits
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Companion to framework#2539, which retired the deprecated
compactLayoutspelling from the spec (create()rejects it, lenient parse strips it, the transition mirror is gone). Served metadata now carrieshighlightFieldsonly — these fallback reads can never fire again, and keeping them would teach the retired key to the next reader (exactly how theviews.*dialect once spread).Changes
deriveHighlightFields(plugin-detail synth), RecordDetailView highlight strip + child-record preview, ObjectView ×2, InterfaceListPage.BuildPageOptions.compactLayoutprop deleted (plugin-detail).deriveHighlightFieldstests flipped: the retired spelling is now ignored (heuristic applies) instead of read — mirrors the spec-side test flip in framework#2539.Verification
buildDefaultPageSchema.test.ts73/73 green (incl. the flipped cases); app-shell 964 green.@object-ui/corevia components dist) — identical on unmodified main (stash-verified), unrelated to this change; CI runs them with the proper workspace build.🤖 Generated with Claude Code