refactor(app-shell): drop agent visibility from AgentPreview (#1901)#2665
Merged
Conversation
The agent `visibility` field was removed from the spec as an unenforced security property (framework #1901, ADR-0056 D8). AgentPreview rendered it as a persona-header pill, which now always fell back to the hardcoded default and implied a gating dial that does not exist. Remove the `visibility` read and its pill from the persona header. The `Lock` icon import stays (still used by the Permissions rail block). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_012gckUwoUMWvTWfGHFgWAob
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
Contributor
✅ Console Performance Budget
📦 Bundle Size Report
Size Limits
|
os-zhuang
marked this pull request as ready for review
July 18, 2026 14:41
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Companion to framework PR objectstack-ai/objectstack#3216, which removes the agent
visibilityfield from the spec as an unenforced security property (framework #1901, ADR-0056 D8 "design+enforce or remove").AgentPreviewrenderedvisibilityas a persona-header pill. With the field gone from the schema it always fell back to the hardcoded'organization'default and implied a gating dial that does not exist — so it's removed.Changes
AgentPreview.tsx— remove thevisibilityread and its persona-header pill; update the component doc comment. TheLockicon import stays (still used by the Permissions rail block).Verification
No node_modules in this environment (install was declined), so no local build/test run. The change is a mechanical removal of one read and one JSX element; no other objectui reference to agent
visibilityexists (view/field/recordvisibilityis an unrelated concept and is untouched).Depends on framework#3216 (schema removal).
🤖 Generated with Claude Code
https://claude.ai/code/session_012gckUwoUMWvTWfGHFgWAob
Generated by Claude Code