Skip to content

refactor(app-shell): drop agent visibility from AgentPreview (#1901) #2665

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
os-zhuang merged 1 commit into from
Jul 18, 2026
Merged

refactor(app-shell): drop agent visibility from AgentPreview (#1901) #2665

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions packages/app-shell/src/views/metadata-admin/previews/AgentPreview.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
*
* Shows the configuration an operator needs to sanity-check an agent
* before saving:
* • Persona header (avatar, label, role, visibility, active flag).
* • Persona header (avatar, label, role, active flag).
* • Model config (provider, model id, temperature, max tokens).
* • System prompt / instructions in a scrollable monospace block.
* • Skills + Tools as two collapsible chip lists.
Expand Down Expand Up @@ -62,7 +62,6 @@ export function AgentPreview({ name, draft }: MetadataPreviewProps) {
const avatar = (d.avatar as string | undefined) || undefined;
const instructions = String(d.instructions ?? '');
const active = d.active !== false;
const visibility = String(d.visibility ?? 'organization');
const model = (d.model ?? {}) as ModelConfig;
const skills: string[] = Array.isArray(d.skills) ? (d.skills as string[]) : [];
const tools: ToolRef[] = Array.isArray(d.tools) ? (d.tools as ToolRef[]) : [];
Expand Down Expand Up @@ -120,7 +119,6 @@ export function AgentPreview({ name, draft }: MetadataPreviewProps) {
{role && <div className="text-xs text-muted-foreground mt-0.5">{role}</div>}
<div className="mt-1.5 flex flex-wrap items-center gap-x-3 gap-y-1 text-[11px]">
<Pill icon={active ? Eye : EyeOff} label={active ? 'Active' : 'Disabled'} tone={active ? 'green' : 'gray'} />
<Pill icon={Lock} label={visibility} />
{model.provider && <Pill icon={Sparkles} label={`${model.provider}${model.model ? ` · ${model.model}` : ''}`} mono />}
{model.temperature != null && <Pill icon={Gauge} label={`temp ${model.temperature}`} />}
{model.maxTokens != null && <Pill label={`max ${model.maxTokens}t`} />}
Expand Down
Loading