Skip to content

feat(SchemaForm): field-type-aware operators + values for view filter#2766

Merged
os-zhuang merged 1 commit into
mainfrom
claude/schemaform-field-aware-operator-p0cyx8
Jul 21, 2026
Merged

feat(SchemaForm): field-type-aware operators + values for view filter#2766
os-zhuang merged 1 commit into
mainfrom
claude/schemaform-field-aware-operator-p0cyx8

Conversation

@os-zhuang

Copy link
Copy Markdown
Contributor

Closes #2764.

Summary

Makes the Studio Edit View Config filter editor field-type-aware, by reusing the runtime FilterBuilder (which already provides per-field-type operator lists, type-aware value inputs, and i18n) and aligning the stored operator vocabulary with the canonical @objectstack/spec ViewFilterRule enum — rather than a parallel operator/value implementation.

  • ResourceEditPage — resolve the source object from draft.data.object (view configs bind their object under data), so filter rows get the object field catalog that drives operator/value widgets.
  • widgets.tsx (FilterBuilderWidget) — write the canonical spec operators (greater_than, not_equals, before/after, is_empty, …). Reads still accept legacy shorthand/camelCase spellings (gt, eq, isNull) from already-stored metadata, and round-trip an unknown operator verbatim instead of silently rewriting it to equals.
  • Runtime operator→AST maps (ListView.mapOperator, UserFilters.specOperatorToAst) — accept the canonical long-form operators the builder now writes, alongside the existing shorthand spellings, so stored canonical filters evaluate correctly.

The actual routing of the view filter field to the filter-builder widget is done contract-first in the spec form (view.form.ts, in the paired framework PR) — matching how dataset/page forms already pin it — so no renderer-side name heuristic is added here.

Why not the previous attempt (#2760)

That PR built parallel per-row operator/value widgets that duplicated FilterBuilder, wrote an operator vocabulary conflicting with what FilterBuilderWidget already writes, made between unreachable for date fields (branch-order bug), stored booleans as strings and in values as comma-joined strings, rendered a literal in JSX, hardcoded English labels, and used over-broad /Value$/ / /Operator$/ widget detection. Reusing the existing FilterBuilder avoids all of it.

Dependencies

Depends on objectstack-ai/objectstack#3373 (ViewFilterRule operator enum + widget: 'filter-builder' on the view filter field). This PR is independently buildable — it does not import the unpublished spec helper — but the operator dropdown and the builder routing land once the spec change ships.

Test plan

  • pnpm --filter @object-ui/plugin-list test — 9 files, 163 tests pass (covers ListView.mapOperator + UserFilters.specOperatorToAst).
  • pnpm --filter @object-ui/app-shell exec tsc --noEmit — clean (0 errors).

🤖 Generated with Claude Code

https://claude.ai/code/session_01PwbhoMeqh33xFWq5M77QTJ


Generated by Claude Code

Align the Studio view-config filter editor with the canonical @objectstack/spec
ViewFilterRule operator vocabulary and reuse the runtime FilterBuilder (which
already provides per-field-type operator lists, value inputs, and i18n) instead
of raw repeater rows.

- ResourceEditPage: resolve the source object from `data.object` so view filter
  rows get the object field catalog that drives operator/value widgets.
- widgets.tsx FilterBuilderWidget: write the canonical operator vocabulary
  (greater_than, not_equals, before/after, …); reads still accept legacy
  shorthand/camelCase spellings from already-stored metadata and round-trip
  unknown operators instead of rewriting them.
- Runtime operator->AST maps (ListView.mapOperator, UserFilters.specOperatorToAst)
  now accept the canonical long-form operators the builder writes, alongside the
  existing shorthand spellings.

Depends on the paired @objectstack/spec change (ViewFilterRule operator enum +
`widget: 'filter-builder'` on the view filter field) for the operator dropdown.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01PwbhoMeqh33xFWq5M77QTJ
@vercel

vercel Bot commented Jul 20, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated (UTC)
objectui Ignored Ignored Jul 20, 2026 6:16pm

Request Review

@github-actions

Copy link
Copy Markdown
Contributor

✅ Console Performance Budget

Metric Value Budget
Main entry (gzip) 28.0 KB 350 KB
Entry file index-BtFR3YIt.js
Status PASS

📦 Bundle Size Report

Package Size Gzipped
app-shell (index.js) 8.19KB 2.96KB
app-shell (runtime-config.js) 7.42KB 2.32KB
app-shell (types.js) 0.01KB 0.04KB
app-shell (urlParams.js) 7.57KB 2.97KB
auth (AuthContext.js) 0.31KB 0.24KB
auth (AuthGuard.js) 1.17KB 0.53KB
auth (AuthProvider.js) 21.70KB 4.21KB
auth (AuthShell.js) 3.49KB 1.40KB
auth (ForgotPasswordForm.js) 12.12KB 3.41KB
auth (LoginForm.js) 17.86KB 5.29KB
auth (PreviewBanner.js) 0.90KB 0.50KB
auth (RegisterForm.js) 6.43KB 2.09KB
auth (SocialSignInButtons.js) 9.60KB 3.89KB
auth (UserMenu.js) 3.40KB 1.22KB
auth (auth-gate-events.js) 1.29KB 0.66KB
auth (authStyles.js) 5.04KB 1.72KB
auth (createAuthClient.js) 33.74KB 8.53KB
auth (createAuthenticatedFetch.js) 4.37KB 1.69KB
auth (index.js) 1.83KB 0.79KB
auth (phone-identifier.js) 1.11KB 0.66KB
auth (types.js) 0.59KB 0.35KB
auth (useAuth.js) 4.86KB 0.85KB
auth (useIsWorkspaceAdmin.js) 1.61KB 0.85KB
collaboration (CommentThread.js) 18.38KB 4.49KB
collaboration (LiveCursors.js) 3.17KB 1.27KB
collaboration (PresenceAvatars.js) 3.65KB 1.42KB
collaboration (PresenceProvider.js) 2.79KB 1.13KB
collaboration (index.js) 1.25KB 0.53KB
collaboration (useCommentSearch.js) 1.98KB 0.88KB
collaboration (useConflictResolution.js) 7.75KB 1.86KB
collaboration (useMentionNotifications.js) 1.81KB 0.68KB
collaboration (usePresence.js) 6.33KB 1.84KB
collaboration (useRealtimeSubscription.js) 7.91KB 2.01KB
components (index.js) 449.99KB 97.82KB
core (index.js) 1.86KB 0.63KB
create-plugin (index.js) 9.28KB 2.98KB
data-objectstack (index.js) 121.12KB 30.43KB
fields (index.js) 211.66KB 51.78KB
i18n (LocalizationContext.js) 1.76KB 0.96KB
i18n (currency.js) 1.22KB 0.64KB
i18n (i18n.js) 4.32KB 1.77KB
i18n (index.js) 2.46KB 0.96KB
i18n (pickLocalized.js) 1.70KB 0.83KB
i18n (provider.js) 5.37KB 1.72KB
i18n (useObjectLabel.js) 24.31KB 5.34KB
i18n (useSafeTranslation.js) 2.87KB 1.28KB
layout (index.js) 38.45KB 10.67KB
mobile (MobileProvider.js) 0.92KB 0.49KB
mobile (ResponsiveContainer.js) 0.94KB 0.38KB
mobile (breakpoints.js) 1.51KB 0.70KB
mobile (createOfflineDataSource.js) 5.61KB 1.74KB
mobile (index.js) 1.50KB 0.62KB
mobile (offlineQueue.js) 3.91KB 1.35KB
mobile (pwa.js) 0.97KB 0.49KB
mobile (serviceWorker.js) 1.48KB 0.62KB
mobile (serviceWorkerSource.js) 3.41KB 1.48KB
mobile (useBreakpoint.js) 1.54KB 0.65KB
mobile (useGesture.js) 4.42KB 1.27KB
mobile (useOfflineSync.js) 1.99KB 0.72KB
mobile (usePullToRefresh.js) 2.53KB 0.85KB
mobile (useResponsive.js) 0.71KB 0.42KB
mobile (useResponsiveConfig.js) 1.36KB 0.63KB
mobile (useSpecGesture.js) 1.77KB 0.77KB
mobile (useTouchTarget.js) 1.01KB 0.54KB
permissions (MePermissionsProvider.js) 5.90KB 2.15KB
permissions (PermissionContext.js) 0.31KB 0.25KB
permissions (PermissionGuard.js) 0.89KB 0.45KB
permissions (PermissionProvider.js) 3.46KB 1.03KB
permissions (evaluator.js) 4.00KB 1.23KB
permissions (index.js) 0.91KB 0.41KB
permissions (store.js) 0.91KB 0.42KB
permissions (useFieldPermissions.js) 1.28KB 0.52KB
permissions (usePermissions.js) 1.50KB 0.70KB
plugin-ai (index.js) 15.71KB 3.79KB
plugin-calendar (index.js) 45.37KB 12.48KB
plugin-charts (index.js) 46.90KB 13.26KB
plugin-chatbot (index.js) 179.53KB 42.79KB
plugin-dashboard (index.js) 108.70KB 27.99KB
plugin-designer (index.js) 210.92KB 42.69KB
plugin-detail (index.js) 214.78KB 52.42KB
plugin-editor (index.js) 2.46KB 1.10KB
plugin-form (index.js) 102.82KB 24.94KB
plugin-gantt (index.js) 162.33KB 39.53KB
plugin-grid (index.js) 174.13KB 45.90KB
plugin-kanban (index.js) 47.45KB 12.99KB
plugin-list (index.js) 98.59KB 23.27KB
plugin-map (index.js) 16.80KB 5.24KB
plugin-markdown (index.js) 13.65KB 4.67KB
plugin-report (index.js) 37.81KB 9.98KB
plugin-timeline (index.js) 25.37KB 7.20KB
plugin-tree (index.js) 8.36KB 2.81KB
plugin-view (index.js) 85.64KB 20.85KB
providers (DataSourceProvider.js) 0.75KB 0.39KB
providers (MetadataProvider.js) 1.37KB 0.59KB
providers (ThemeProvider.js) 1.55KB 0.67KB
providers (UploadProvider.js) 11.71KB 3.53KB
providers (index.js) 0.44KB 0.22KB
providers (types.js) 0.01KB 0.04KB
react-runtime (index.js) 3.19KB 1.38KB
react (LazyPluginLoader.js) 3.77KB 1.33KB
react (SchemaRenderer.js) 18.70KB 6.09KB
react (data-invalidation.js) 5.05KB 2.08KB
react (index.js) 1.00KB 0.55KB
sdui-parser (codegen.js) 4.09KB 1.74KB
sdui-parser (index.js) 2.16KB 0.94KB
sdui-parser (parse.js) 10.04KB 2.82KB
sdui-parser (types.js) 0.29KB 0.24KB
sdui-parser (validate.js) 4.69KB 1.48KB
types (ai.js) 0.20KB 0.17KB
types (api-types.js) 0.20KB 0.18KB
types (app.js) 2.87KB 0.99KB
types (base.js) 0.20KB 0.18KB
types (blocks.js) 0.20KB 0.18KB
types (complex.js) 0.20KB 0.18KB
types (crud.js) 0.20KB 0.18KB
types (data-display.js) 0.20KB 0.18KB
types (data-protocol.js) 0.20KB 0.19KB
types (data.js) 0.20KB 0.18KB
types (designer.js) 0.77KB 0.41KB
types (disclosure.js) 0.20KB 0.18KB
types (feedback.js) 0.20KB 0.18KB
types (field-types.js) 0.20KB 0.18KB
types (form.js) 0.20KB 0.18KB
types (index.js) 2.02KB 0.95KB
types (layout.js) 0.20KB 0.18KB
types (managed-by.js) 0.19KB 0.18KB
types (mobile.js) 0.20KB 0.18KB
types (navigation.js) 0.20KB 0.18KB
types (objectql.js) 0.20KB 0.18KB
types (overlay.js) 0.20KB 0.18KB
types (permissions.js) 0.20KB 0.18KB
types (plugin-scope.js) 0.20KB 0.18KB
types (record-components.js) 0.20KB 0.19KB
types (record-semantics.js) 1.28KB 0.67KB
types (registry.js) 0.20KB 0.18KB
types (reports.js) 0.20KB 0.18KB
types (spec-report.js) 5.26KB 1.96KB
types (system-fields.js) 2.39KB 1.17KB
types (theme.js) 0.20KB 0.18KB
types (ui-action.js) 0.75KB 0.46KB
types (views.js) 0.20KB 0.18KB
types (widget.js) 0.20KB 0.18KB

Size Limits

  • ✅ Core packages should be < 50KB gzipped
  • ✅ Component packages should be < 100KB gzipped
  • ⚠️ Plugin packages should be < 150KB gzipped

@os-zhuang
os-zhuang marked this pull request as ready for review July 21, 2026 00:56
@os-zhuang
os-zhuang merged commit 93a85b2 into main Jul 21, 2026
14 checks passed
@os-zhuang
os-zhuang deleted the claude/schemaform-field-aware-operator-p0cyx8 branch July 21, 2026 00:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Studio: field-type-aware operator + value editing for view filter rules (Edit View Config)

2 participants