Skip to content

refactor(views): ListView reads spec-canonical columns, legacy fields folded in one normalizer (#2890) - #2932

Merged
os-zhuang merged 1 commit into
mainfrom
feat/2890-listview-columns
Jul 28, 2026
Merged

refactor(views): ListView reads spec-canonical columns, legacy fields folded in one normalizer (#2890)#2932
os-zhuang merged 1 commit into
mainfrom
feat/2890-listview-columns

Conversation

@os-zhuang

Copy link
Copy Markdown
Contributor

Closes the first rename in #2890 scope A: fieldscolumns.

ListViewSchema has been derived from @objectstack/spec/ui since #2231, but the renderer still spoke objectui's own vocabulary for the same concepts. This PR moves every ListView read-site onto the spec key and puts legacy acceptance in exactly one place.

What changed

  • New normalizeListViewSchema (@object-ui/core) — folds fields into columns (canonical wins when both are present) and drops the legacy key, so a read-site that was missed fails loudly instead of quietly taking the legacy path. It also absorbs the viewType renderability default ListView applied inline. Non-mutating, idempotent, and returns its input by reference when there is nothing to fold, so ListView's downstream useMemos keep a stable dependency identity on the already-canonical path.
  • ListView normalizes once at the component boundary, before anything reads the schema.
  • Producers emit columnsObjectView's renderListView payload, ObjectDataPage, InterfaceListPage and the list-view registry defaults were downgrading already-columns-keyed view config back to fields.
  • Drive-by: the filter builder's objectDef-not-loaded fallback resolved only name/fieldName, so ListColumn objects produced unnamed filter entries. It now reads field too.

Why not a z.preprocess on ListViewSchema

The issue suggests a spec-side preprocess, on the precedent of normalizeFilterOperator. That mechanism cannot work here: nothing on the render path parses view metadata through zod. The zod schemas serve the CLI validator, the VS Code extension and tests; ListViewSchema at the render site is a TypeScript type annotation, erased at compile time. A schema-level fold — spec-side or local — would never execute. The guarantee has to come from a call site, so that is where it lives. (Two more findings about the spec-side route are written up on the issue.)

Per AGENTS.md Commandment #0.1 this is deliberately not a per-read-site ?? dual-read: those had already drifted (ObjectGrid preferred columns in one branch and fields in another). Like the spec's own migration bridges, the fold is expected to be dropped in a future major once stored metadata is migrated.

fields stays declared on ListViewSchema and in the drift guard's sanctioned set — it is still valid input, and @objectstack/spec's react-blocks.ts sanctions it as the React-tier <ListView fields> prop — but it is input-only now.

Verification

  • New normalize-list-view.test.ts — 13 tests (fold, precedence, drop, idempotence, reference stability, non-object input).
  • New ListView consumer regression — 4 tests asserting the $select projection is built from columns, from ListColumn objects, from legacy fields, and that columns wins when both are present.
  • Existing ListView suite (170 tests) authors fields: throughout and passes unchanged — that is the legacy-acceptance proof.
  • Full local vitest run, turbo run type-check over the 5 touched packages (32 tasks), and ESLint on every changed file (0 errors).

🤖 Generated with Claude Code

…lds` folded in one normalizer (#2890)

`ListViewSchema` has been spec-derived since #2231, but the renderer still spoke
objectui's own vocabulary. First rename closed: `fields` → `columns`.

Legacy acceptance stays (stored view metadata carries `fields`) but moves into a
single documented normalizer instead of per-read-site fallbacks:

- `normalizeListViewSchema` (@object-ui/core) folds `fields` into `columns`
  (canonical wins) and drops the legacy key so a missed read-site fails loudly.
  It also absorbs the `viewType` renderability default ListView applied inline.
  Non-mutating, idempotent, returns its input by reference when nothing folds.
- `ListView` normalizes once at the component boundary. That call site — not
  the zod schema — is the guarantee: nothing on the render path parses view
  metadata through zod, so a `z.preprocess` on `ListViewSchema` would never run.
- Producers emit `columns`: ObjectView's `renderListView` payload,
  ObjectDataPage, InterfaceListPage and the `list-view` registry defaults were
  downgrading already-canonical `columns` config back to `fields`.

Also fixes the filter builder's objectDef-not-loaded fallback, which resolved
only `name`/`fieldName` and so produced unnamed entries for ListColumn objects.

`fields` stays declared on the schema and in the drift guard's sanctioned set —
it is still valid input, and @objectstack/spec's react-blocks.ts sanctions it as
the React-tier `<ListView fields>` prop — but it is input-only now.

Co-Authored-By: Claude <noreply@anthropic.com>
@vercel

vercel Bot commented Jul 28, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated (UTC)
objectui Ignored Ignored Jul 28, 2026 3:45pm

Request Review

@github-actions

Copy link
Copy Markdown
Contributor

✅ Console Performance Budget

Metric Value Budget
Main entry (gzip) 27.9 KB 350 KB
Entry file index-C9fsxUjh.js
Status PASS

📦 Bundle Size Report

Package Size Gzipped
app-shell (index.js) 8.20KB 2.97KB
app-shell (runtime-config.js) 7.42KB 2.32KB
app-shell (types.js) 0.01KB 0.04KB
app-shell (urlParams.js) 7.57KB 2.97KB
auth (AuthContext.js) 0.31KB 0.24KB
auth (AuthGuard.js) 1.17KB 0.53KB
auth (AuthProvider.js) 22.10KB 4.37KB
auth (AuthShell.js) 3.49KB 1.40KB
auth (ForgotPasswordForm.js) 12.12KB 3.41KB
auth (LoginForm.js) 17.86KB 5.29KB
auth (PreviewBanner.js) 0.90KB 0.50KB
auth (RegisterForm.js) 6.43KB 2.09KB
auth (SocialSignInButtons.js) 9.60KB 3.89KB
auth (UserMenu.js) 3.40KB 1.22KB
auth (auth-gate-events.js) 1.29KB 0.66KB
auth (authStyles.js) 5.04KB 1.72KB
auth (createAuthClient.js) 35.76KB 9.11KB
auth (createAuthenticatedFetch.js) 4.37KB 1.69KB
auth (index.js) 2.25KB 1.01KB
auth (org-roles.js) 6.72KB 2.85KB
auth (phone-identifier.js) 1.11KB 0.66KB
auth (types.js) 0.59KB 0.35KB
auth (useAuth.js) 4.91KB 0.87KB
auth (useIsWorkspaceAdmin.js) 1.61KB 0.85KB
collaboration (CommentThread.js) 18.38KB 4.49KB
collaboration (LiveCursors.js) 3.17KB 1.27KB
collaboration (PresenceAvatars.js) 3.65KB 1.42KB
collaboration (PresenceProvider.js) 2.79KB 1.13KB
collaboration (index.js) 1.25KB 0.53KB
collaboration (useCommentSearch.js) 1.98KB 0.88KB
collaboration (useConflictResolution.js) 7.75KB 1.86KB
collaboration (useMentionNotifications.js) 1.81KB 0.68KB
collaboration (usePresence.js) 6.33KB 1.84KB
collaboration (useRealtimeSubscription.js) 7.91KB 2.01KB
components (index.js) 450.13KB 97.92KB
core (index.js) 2.16KB 0.78KB
create-plugin (index.js) 9.28KB 2.98KB
data-objectstack (index.js) 127.78KB 32.15KB
fields (index.js) 220.07KB 53.90KB
i18n (LocalizationContext.js) 1.76KB 0.96KB
i18n (currency.js) 1.22KB 0.64KB
i18n (i18n.js) 4.32KB 1.77KB
i18n (index.js) 2.46KB 0.96KB
i18n (pickLocalized.js) 1.70KB 0.83KB
i18n (provider.js) 5.37KB 1.72KB
i18n (useObjectLabel.js) 25.17KB 5.80KB
i18n (useSafeTranslation.js) 3.26KB 1.44KB
layout (index.js) 38.45KB 10.67KB
mobile (MobileProvider.js) 0.92KB 0.49KB
mobile (ResponsiveContainer.js) 0.94KB 0.38KB
mobile (breakpoints.js) 1.51KB 0.70KB
mobile (createOfflineDataSource.js) 5.61KB 1.74KB
mobile (index.js) 1.50KB 0.62KB
mobile (offlineQueue.js) 3.91KB 1.35KB
mobile (pwa.js) 0.97KB 0.49KB
mobile (serviceWorker.js) 1.48KB 0.62KB
mobile (serviceWorkerSource.js) 3.41KB 1.48KB
mobile (useBreakpoint.js) 1.54KB 0.65KB
mobile (useGesture.js) 4.42KB 1.27KB
mobile (useOfflineSync.js) 1.99KB 0.72KB
mobile (usePullToRefresh.js) 2.53KB 0.85KB
mobile (useResponsive.js) 0.71KB 0.42KB
mobile (useResponsiveConfig.js) 1.36KB 0.63KB
mobile (useSpecGesture.js) 1.77KB 0.77KB
mobile (useTouchTarget.js) 1.01KB 0.54KB
permissions (MePermissionsProvider.js) 6.84KB 2.42KB
permissions (PermissionContext.js) 0.31KB 0.25KB
permissions (PermissionGuard.js) 0.89KB 0.45KB
permissions (PermissionProvider.js) 3.67KB 1.12KB
permissions (evaluator.js) 4.41KB 1.44KB
permissions (index.js) 0.91KB 0.41KB
permissions (store.js) 0.91KB 0.42KB
permissions (useFieldPermissions.js) 1.28KB 0.52KB
permissions (usePermissions.js) 1.55KB 0.71KB
plugin-ai (index.js) 15.71KB 3.79KB
plugin-calendar (index.js) 44.90KB 12.35KB
plugin-charts (index.js) 57.26KB 16.24KB
plugin-chatbot (index.js) 179.93KB 42.67KB
plugin-dashboard (index.js) 109.60KB 28.33KB
plugin-designer (index.js) 210.56KB 42.56KB
plugin-detail (index.js) 216.77KB 53.01KB
plugin-editor (index.js) 2.46KB 1.10KB
plugin-form (index.js) 103.47KB 25.10KB
plugin-gantt (index.js) 162.26KB 39.53KB
plugin-grid (index.js) 179.25KB 46.97KB
plugin-kanban (index.js) 47.82KB 13.18KB
plugin-list (index.js) 98.71KB 23.32KB
plugin-map (index.js) 16.80KB 5.24KB
plugin-markdown (index.js) 13.65KB 4.67KB
plugin-report (index.js) 37.07KB 9.81KB
plugin-timeline (index.js) 25.03KB 7.11KB
plugin-tree (index.js) 8.36KB 2.81KB
plugin-view (index.js) 85.68KB 20.85KB
providers (DataSourceProvider.js) 0.75KB 0.39KB
providers (MetadataProvider.js) 1.37KB 0.59KB
providers (ThemeProvider.js) 1.55KB 0.67KB
providers (UploadProvider.js) 11.71KB 3.53KB
providers (index.js) 0.44KB 0.22KB
providers (types.js) 0.01KB 0.04KB
react-runtime (index.js) 3.19KB 1.38KB
react (LazyPluginLoader.js) 3.77KB 1.33KB
react (SchemaRenderer.js) 18.70KB 6.09KB
react (data-invalidation.js) 5.05KB 2.08KB
react (index.js) 1.00KB 0.55KB
sdui-parser (codegen.js) 4.09KB 1.74KB
sdui-parser (index.js) 2.16KB 0.94KB
sdui-parser (parse.js) 10.04KB 2.82KB
sdui-parser (types.js) 0.29KB 0.24KB
sdui-parser (validate.js) 4.69KB 1.48KB
types (ai.js) 0.20KB 0.17KB
types (api-types.js) 0.20KB 0.18KB
types (app.js) 2.87KB 0.99KB
types (base.js) 0.20KB 0.18KB
types (blocks.js) 0.20KB 0.18KB
types (complex.js) 0.20KB 0.18KB
types (crud.js) 0.20KB 0.18KB
types (data-display.js) 0.20KB 0.18KB
types (data-protocol.js) 0.20KB 0.19KB
types (data.js) 0.20KB 0.18KB
types (designer.js) 0.77KB 0.41KB
types (disclosure.js) 0.20KB 0.18KB
types (feedback.js) 0.20KB 0.18KB
types (field-types.js) 0.20KB 0.18KB
types (form.js) 0.20KB 0.18KB
types (index.js) 1.86KB 0.91KB
types (layout.js) 0.20KB 0.18KB
types (managed-by.js) 0.19KB 0.18KB
types (mobile.js) 0.20KB 0.18KB
types (navigation.js) 0.20KB 0.18KB
types (objectql.js) 0.20KB 0.18KB
types (overlay.js) 0.20KB 0.18KB
types (permissions.js) 0.20KB 0.18KB
types (plugin-scope.js) 0.20KB 0.18KB
types (record-components.js) 0.20KB 0.19KB
types (record-semantics.js) 1.28KB 0.67KB
types (registry.js) 0.20KB 0.18KB
types (reports.js) 0.20KB 0.18KB
types (spec-report.js) 5.04KB 1.93KB
types (system-fields.js) 2.39KB 1.17KB
types (theme.js) 0.20KB 0.18KB
types (ui-action.js) 0.75KB 0.46KB
types (views.js) 0.20KB 0.18KB
types (widget.js) 0.20KB 0.18KB

Size Limits

  • ✅ Core packages should be < 50KB gzipped
  • ✅ Component packages should be < 100KB gzipped
  • ⚠️ Plugin packages should be < 150KB gzipped

@os-zhuang
os-zhuang merged commit cd09a7b into main Jul 28, 2026
16 checks passed
@os-zhuang
os-zhuang deleted the feat/2890-listview-columns branch July 28, 2026 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant