docs(components): react-page scope comment says ObjectGrid, not the unregistered ObjectTable - #2938
Merged
Merged
Conversation
…nregistered ObjectTable
The `kind:'react'` page header comment advertised two identifiers that do
not exist, so an author following it hit a wall either way:
- `<ObjectTable>` -> ReferenceError, surfaced as the red "React page error"
panel. `buildComponentScope` PascalCases each public non-container tag
from the curated PUBLIC_BLOCKS contract, which carries `object-grid`
(registered in plugin-grid) and no `object-table` at all, so the real
injected identifier has always been `ObjectGrid`.
- `<Block type="object-table" />` -> "Unknown component type", since
nothing registers that type anywhere in the product.
`object-table` survives only in sdui-parser's synthetic compiler fixtures,
which build their own inline manifests and never touch the real registry.
Comment-only; no behavior change.
Co-Authored-By: Claude <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
Contributor
✅ Console Performance Budget
📦 Bundle Size Report
Size Limits
|
os-zhuang
added a commit
that referenced
this pull request
Jul 29, 2026
… doc comments (#2947) Follow-up to #2938. `ObjectTable` is not a typo but a historical artifact: the component was renamed to `ObjectGrid` long ago (see the "ObjectTable: Auto-generates tables from ObjectQL object schemas" entries still recorded in the package CHANGELOGs), and some prose never followed. #2938 fixed the one occurrence that actually bit authors — the `kind:'react'` page scope comment, where the prose *is* the API documentation for a runtime-derived scope. These two are lower-stakes descriptive prose on type definitions, cleaned up so the dead name stops surviving in live code: - field-types.ts — the module doc for the field type system. - objectql.ts — `ObjectViewSchema`. Factually correct as well as mechanical: ObjectView renders an `object-grid` (plugin-view/src/ObjectView.tsx:858). `ObjectTable` now appears only in the package CHANGELOGs (immutable history), gitignored `dist/` output, and sdui-parser's synthetic compiler fixtures. Comment-only; no behavior change. Co-authored-by: Jack Zhuang <277994282+os-zhuang@users.noreply.github.com> Co-authored-by: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The
kind:'react'page renderer's header comment inreact-page.tsxadvertised two identifiers that do not exist. An author following the
comment hit a wall either way:
<ObjectTable>(line 22)ReferenceError— surfaced as the red "React page error" panel<Block type="object-table" />(line 26)Why
buildComponentScope(react-page.tsx:50-86) builds the injected scope byPascalCasing each public, non-container tag from the curated
PUBLIC_BLOCKScontract. That list(public-blocks.ts:26-66)
carries
object-grid— neverobject-table— so the real injectedidentifier has always been
ObjectGrid.object-gridis genuinely registered, and withoutisContainer, so itsurvives the container filter and lands in the scope:
plugin-grid/src/index.tsx:55—ComponentRegistry.register('object-grid', ObjectGridRenderer, {...})Verification that
object-tablehas no registrationgrep -rn "object-table" packages apps docsreturns only:packages/components/dist/...d.ts— stale build output, regenerates,packages/sdui-parsercompiler fixtures (__tests__/*,verify.ts) — thesebuild their own inline synthetic manifests and a fake in-test
ComponentRegistry.register, and never touch the real product registry.So nothing in the product registers
object-table.Change
Comment-only — two lines, no behavior change, no changeset (not a feature).
🤖 Generated with Claude Code