Skip to content

fix(sdui): lazy public blocks reach a kind:'react' page scope; ReactRunner keeps its errors - #2976

Merged
os-zhuang merged 2 commits into
mainfrom
claude/react-lazy-block-scope-bpvef6
Jul 30, 2026
Merged

fix(sdui): lazy public blocks reach a kind:'react' page scope; ReactRunner keeps its errors#2976
os-zhuang merged 2 commits into
mainfrom
claude/react-lazy-block-scope-bpvef6

Conversation

@os-zhuang

Copy link
Copy Markdown
Contributor

Fixes #2953, fixes #2954.

Two defects in the trusted kind:'react' page tier. They're coupled — the second fix only works because of the first — so they land together.

#2953 — the public contract skipped lazily-registered blocks

getPublicConfigs() resolved every curated PUBLIC_BLOCKS tag through getConfig(), which reads the eager components map and never consults lazyEntries. So a block registered via registerLazy() was absent from the contract until its plugin chunk happened to be imported.

In apps/console that silently dropped six PUBLIC_BLOCKS tags from every react page's scope — object-kanban, object-calendar, object-gantt, object-timeline, object-map, markdown. Writing <ObjectKanban/> threw ReferenceError even though the tag is a first-class contract member, and whether it threw depended on load order, so the same page could work in one session and fail in another.

Took direction 2 from the issue (fix the contract surface, not just buildComponentScope), since the same skew reaches every consumer of the public tier:

  • New private Registry.getContractConfig(tag) — the loaded registration when there is one, otherwise the pending registerLazy stub's metadata. It mirrors registerLazy's key derivation so the canonical type used for dedupe matches what register() will store once the loader runs (and doesn't double-prefix a namespace onto an already colon-shaped curated tag like record:details).
  • getPublicConfigs() now returns PublicComponentConfig[]: same shape as before, but a not-yet-loaded entry comes back with lazy: true and no component. The lazy tier:'public' opt-in is honoured too, mirroring the eager one.
  • getConfig() is left alone — callers read .component off it, and a stub has no renderer. Its doc now states that split explicitly and points at hasLazy/loadLazy.

react-page.tsx needed no logic change: the injected wrapper already defers to SchemaRenderer, which fires the loader, renders the Loading <tag>… placeholder, and re-renders on the registry's notify.

#2954 — ReactRunner discarded the errors it caught

getDerivedStateFromProps re-transpiled and re-evaluated the page source on every render and unconditionally set error: null. React runs it before the re-render that follows getDerivedStateFromError, so the boundary threw away the error it had just caught, rebuilt an identical throwing element, and the throw escaped past its own fallback.

The transpile+eval is now memoised on (code, scope) — unchanged inputs return null and keep the existing state. One change, three fixes:

  1. fallback is reachable again. ReactKindPage's styled "React page error" panel was dead code for render-phase errors; authors saw SchemaRenderer's generic Component "home" failed to render instead.
  2. onError fires correctly. It was gated on an error the next getDerivedStateFromProps had already cleared. Now it reports on the transition (once per error, not once per render), and componentDidMount covers compile-time errors — which previously never reported at all, since componentDidUpdate doesn't run for the first render.
  3. No more remount. Every eval mints a fresh Page function — a new element type — so recompiling per render remounted the page subtree and wiped its useState. That was the latent hazard flagged in the issue; memoising removes it.

Errors are no longer sticky: new code/scope recompiles and clears them.

Why the two are coupled

The #2953 fix means the scope is complete at build time, so it never has to be rebuilt — which is exactly why ReactKindPage deliberately does not subscribe to ComponentRegistry changes the way SchemaRenderer does. If it did, a lazy plugin finishing registration would notify, rebuild the scope, change its identity, and (via #2954's memo key) remount every interactive react page on screen. Both call sites now carry that reasoning in comments.

Tests

  • packages/react-runtime had no tests at all. Adds 12 covering the boundary, recovery, onError, compile memoisation and mount stability. 6 of them fail against the old runner (verified by reverting the fix and re-running).
  • packages/core — 6 new lazy-contract cases: stub included, load-order independence (same entry before and after the load), dual-key dedupe, colon-shaped tag, lazy tier:'public' opt-in, and getConfig() staying loaded-only.
  • packages/components — an end-to-end lazy block through the real scope builder + SchemaRenderer (fails against the old registry), and the negative control now pins the "React page error" panel directly instead of routing around the ReactRunner re-transpiles on every render, discarding its own error state #2954 quirk it had to document.

Verification

  • Full suite: 692 files passed | 1 skipped, 8138 tests passed | 24 skipped.
  • turbo run type-check across the repo and for @object-ui/console: clean.
  • lint on core / react-runtime / components: 0 errors.
  • changeset:check: clean. Changeset included (@object-ui/core, @object-ui/react-runtime, @object-ui/components — patch).

No manifest impact: both generators (apps/console/dev/manifest-dump.tsx, packages/sdui-parser/scripts/gen-manifest.ts) import every plugin eagerly, so no lazy stubs exist at generation time. Were one to slip in, validateTree would downgrade a hard unknown-component error to an unknown-prop warning for a block that genuinely is in the contract — the correct direction, and never stricter than before.

🤖 Generated with Claude Code

https://claude.ai/code/session_01N4mrr1ihhwnfEHFSWmGoMp


Generated by Claude Code

claude added 2 commits July 30, 2026 02:53
…unner keeps its errors (#2953, #2954)

Two defects in the trusted `kind:'react'` page tier.

objectui#2953 — the contract skipped lazily-registered blocks.
`getPublicConfigs()` resolved every curated `PUBLIC_BLOCKS` tag through
`getConfig()`, which reads loaded registrations only, so a block registered
via `registerLazy()` was absent from the contract until its plugin chunk
happened to be imported. In apps/console that silently dropped `object-kanban`,
`object-calendar`, `object-gantt`, `object-timeline`, `object-map` and
`markdown` from every react page's scope: `<ObjectKanban/>` threw a
ReferenceError even though the tag is a first-class contract member, and
whether it threw depended on load order.

`getPublicConfigs()` now resolves pending lazy stubs too, returning them with
`lazy: true` and no `component` (new `PublicComponentConfig` type). The
injected wrapper renders through `SchemaRenderer`, which already triggers the
loader and shows its placeholder, so the scope is complete at build time and
never has to be rebuilt. `getConfig()` stays loaded-only by design — callers
read `.component` off it — and now says so.

objectui#2954 — ReactRunner discarded the errors it caught.
`getDerivedStateFromProps` re-transpiled and re-evaluated the page source on
every render and unconditionally set `error: null`. React runs it before the
re-render that follows `getDerivedStateFromError`, so the boundary threw away
the error it had just caught, rebuilt an identical throwing element, and the
throw escaped past its own `fallback` to the renderer's generic panel;
`onError` was gated on state that had already been cleared, and never fired at
all for a compile-time error; and every eval minted a fresh page function — a
new element type — remounting the subtree and wiping the page's `useState`.

The transpile+eval is now memoised on `(code, scope)`, errors persist until
those inputs actually change, and `onError` reports each error exactly once
(including at mount). That also makes the scope's identity stability load
bearing, which is why the react page deliberately does not subscribe to
registry changes — the #2953 fix means it no longer needs to.

Tests: `@object-ui/react-runtime` had none; adds a suite covering the boundary,
recovery, onError, compile memoisation and mount stability (6 of 12 fail
against the old runner). Adds lazy-contract cases to the registry's public-tier
tests and an end-to-end lazy block to the react-page scope tests, and pins the
"React page error" panel the negative control previously had to route around.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01N4mrr1ihhwnfEHFSWmGoMp
… tests

The comments in react-page-scope.test.tsx cite react-page.tsx by line, and the
previous commit shifted those lines. Re-point them at the current anchors.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01N4mrr1ihhwnfEHFSWmGoMp
@vercel

vercel Bot commented Jul 30, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated (UTC)
objectui Ignored Ignored Jul 30, 2026 3:04am

Request Review

@github-actions

Copy link
Copy Markdown
Contributor

✅ Console Performance Budget

Metric Value Budget
Main entry (gzip) 27.9 KB 350 KB
Entry file index-hr8sc2B4.js
Status PASS

📦 Bundle Size Report

Package Size Gzipped
app-shell (index.js) 8.20KB 2.97KB
app-shell (runtime-config.js) 7.42KB 2.32KB
app-shell (types.js) 0.01KB 0.04KB
app-shell (urlParams.js) 7.57KB 2.97KB
auth (AuthContext.js) 0.31KB 0.24KB
auth (AuthGuard.js) 1.17KB 0.53KB
auth (AuthProvider.js) 22.10KB 4.37KB
auth (AuthShell.js) 3.49KB 1.40KB
auth (ForgotPasswordForm.js) 12.12KB 3.41KB
auth (LoginForm.js) 17.86KB 5.29KB
auth (PreviewBanner.js) 0.90KB 0.50KB
auth (RegisterForm.js) 6.43KB 2.09KB
auth (SocialSignInButtons.js) 9.60KB 3.89KB
auth (UserMenu.js) 3.40KB 1.22KB
auth (auth-gate-events.js) 1.29KB 0.66KB
auth (authStyles.js) 5.04KB 1.72KB
auth (createAuthClient.js) 35.76KB 9.11KB
auth (createAuthenticatedFetch.js) 4.37KB 1.69KB
auth (index.js) 2.25KB 1.01KB
auth (org-roles.js) 6.72KB 2.85KB
auth (phone-identifier.js) 1.11KB 0.66KB
auth (types.js) 0.59KB 0.35KB
auth (useAuth.js) 4.91KB 0.87KB
auth (useIsWorkspaceAdmin.js) 1.61KB 0.85KB
collaboration (CommentThread.js) 18.38KB 4.49KB
collaboration (LiveCursors.js) 3.17KB 1.27KB
collaboration (PresenceAvatars.js) 3.65KB 1.42KB
collaboration (PresenceProvider.js) 2.79KB 1.13KB
collaboration (index.js) 1.25KB 0.53KB
collaboration (useCommentSearch.js) 1.98KB 0.88KB
collaboration (useConflictResolution.js) 7.75KB 1.86KB
collaboration (useMentionNotifications.js) 1.81KB 0.68KB
collaboration (usePresence.js) 6.33KB 1.84KB
collaboration (useRealtimeSubscription.js) 7.91KB 2.01KB
components (index.js) 450.74KB 98.10KB
core (index.js) 2.16KB 0.78KB
create-plugin (index.js) 9.28KB 2.98KB
data-objectstack (index.js) 129.96KB 32.71KB
fields (index.js) 221.10KB 54.18KB
i18n (LocalizationContext.js) 1.76KB 0.96KB
i18n (currency.js) 1.22KB 0.64KB
i18n (i18n.js) 4.32KB 1.77KB
i18n (index.js) 2.46KB 0.96KB
i18n (pickLocalized.js) 1.70KB 0.83KB
i18n (provider.js) 5.37KB 1.72KB
i18n (useObjectLabel.js) 25.17KB 5.80KB
i18n (useSafeTranslation.js) 3.26KB 1.44KB
layout (index.js) 38.45KB 10.67KB
mobile (MobileProvider.js) 0.92KB 0.49KB
mobile (ResponsiveContainer.js) 0.94KB 0.38KB
mobile (breakpoints.js) 1.51KB 0.70KB
mobile (createOfflineDataSource.js) 5.61KB 1.74KB
mobile (index.js) 1.50KB 0.62KB
mobile (offlineQueue.js) 3.91KB 1.35KB
mobile (pwa.js) 0.97KB 0.49KB
mobile (serviceWorker.js) 1.48KB 0.62KB
mobile (serviceWorkerSource.js) 3.41KB 1.48KB
mobile (useBreakpoint.js) 1.54KB 0.65KB
mobile (useGesture.js) 4.42KB 1.27KB
mobile (useOfflineSync.js) 1.99KB 0.72KB
mobile (usePullToRefresh.js) 2.53KB 0.85KB
mobile (useResponsive.js) 0.71KB 0.42KB
mobile (useResponsiveConfig.js) 1.36KB 0.63KB
mobile (useSpecGesture.js) 1.77KB 0.77KB
mobile (useTouchTarget.js) 1.01KB 0.54KB
permissions (MePermissionsProvider.js) 6.84KB 2.42KB
permissions (PermissionContext.js) 0.31KB 0.25KB
permissions (PermissionGuard.js) 0.89KB 0.45KB
permissions (PermissionProvider.js) 3.67KB 1.12KB
permissions (evaluator.js) 4.41KB 1.44KB
permissions (index.js) 0.91KB 0.41KB
permissions (store.js) 0.91KB 0.42KB
permissions (useFieldPermissions.js) 1.28KB 0.52KB
permissions (usePermissions.js) 1.55KB 0.71KB
plugin-ai (index.js) 15.71KB 3.79KB
plugin-calendar (index.js) 44.90KB 12.35KB
plugin-charts (index.js) 57.26KB 16.24KB
plugin-chatbot (index.js) 179.93KB 42.67KB
plugin-dashboard (index.js) 109.60KB 28.33KB
plugin-designer (index.js) 210.56KB 42.56KB
plugin-detail (index.js) 216.52KB 53.02KB
plugin-editor (index.js) 2.46KB 1.10KB
plugin-form (index.js) 103.32KB 25.08KB
plugin-gantt (index.js) 162.26KB 39.53KB
plugin-grid (index.js) 179.45KB 47.03KB
plugin-kanban (index.js) 47.82KB 13.18KB
plugin-list (index.js) 98.19KB 23.17KB
plugin-map (index.js) 16.80KB 5.24KB
plugin-markdown (index.js) 13.65KB 4.67KB
plugin-report (index.js) 37.77KB 10.00KB
plugin-timeline (index.js) 25.03KB 7.11KB
plugin-tree (index.js) 8.36KB 2.81KB
plugin-view (index.js) 85.47KB 20.82KB
providers (DataSourceProvider.js) 0.75KB 0.39KB
providers (MetadataProvider.js) 1.37KB 0.59KB
providers (ThemeProvider.js) 1.55KB 0.67KB
providers (UploadProvider.js) 11.71KB 3.53KB
providers (index.js) 0.44KB 0.22KB
providers (types.js) 0.01KB 0.04KB
react-runtime (index.js) 4.80KB 2.03KB
react (LazyPluginLoader.js) 3.77KB 1.33KB
react (SchemaRenderer.js) 18.70KB 6.09KB
react (data-invalidation.js) 5.05KB 2.08KB
react (index.js) 1.02KB 0.55KB
sdui-parser (codegen.js) 4.09KB 1.74KB
sdui-parser (index.js) 2.16KB 0.94KB
sdui-parser (parse.js) 10.04KB 2.82KB
sdui-parser (types.js) 0.29KB 0.24KB
sdui-parser (validate.js) 4.69KB 1.48KB
types (ai.js) 0.20KB 0.17KB
types (api-types.js) 0.20KB 0.18KB
types (app.js) 2.87KB 0.99KB
types (base.js) 0.20KB 0.18KB
types (blocks.js) 0.20KB 0.18KB
types (complex.js) 0.20KB 0.18KB
types (crud.js) 0.20KB 0.18KB
types (data-display.js) 0.20KB 0.18KB
types (data-protocol.js) 0.20KB 0.19KB
types (data.js) 0.20KB 0.18KB
types (designer.js) 0.77KB 0.41KB
types (disclosure.js) 0.20KB 0.18KB
types (feedback.js) 0.20KB 0.18KB
types (field-types.js) 0.20KB 0.18KB
types (form.js) 0.20KB 0.18KB
types (index.js) 1.86KB 0.91KB
types (layout.js) 0.20KB 0.18KB
types (managed-by.js) 0.19KB 0.18KB
types (mobile.js) 0.20KB 0.18KB
types (navigation.js) 0.20KB 0.18KB
types (objectql.js) 0.20KB 0.18KB
types (overlay.js) 0.20KB 0.18KB
types (permissions.js) 0.20KB 0.18KB
types (plugin-scope.js) 0.20KB 0.18KB
types (record-components.js) 0.20KB 0.19KB
types (record-semantics.js) 1.28KB 0.67KB
types (registry.js) 0.20KB 0.18KB
types (reports.js) 0.20KB 0.18KB
types (spec-report.js) 5.04KB 1.93KB
types (system-fields.js) 2.39KB 1.17KB
types (theme.js) 0.20KB 0.18KB
types (ui-action.js) 0.75KB 0.46KB
types (views.js) 0.20KB 0.18KB
types (widget.js) 0.20KB 0.18KB

Size Limits

  • ✅ Core packages should be < 50KB gzipped
  • ✅ Component packages should be < 100KB gzipped
  • ⚠️ Plugin packages should be < 150KB gzipped

@os-zhuang
os-zhuang marked this pull request as ready for review July 30, 2026 04:46
@os-zhuang
os-zhuang merged commit aa1240a into main Jul 30, 2026
16 checks passed
@os-zhuang
os-zhuang deleted the claude/react-lazy-block-scope-bpvef6 branch July 30, 2026 04:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ReactRunner re-transpiles on every render, discarding its own error state kind:'react' page scope silently omits every lazily-registered public block

2 participants