Skip to content

refactor(actions)!: target is the only handler slot — delete the execute alias (objectstack#3856) - #2990

Merged
os-zhuang merged 1 commit into
mainfrom
claude/quirky-euler-p9dsfm
Jul 30, 2026
Merged

refactor(actions)!: target is the only handler slot — delete the execute alias (objectstack#3856)#2990
os-zhuang merged 1 commit into
mainfrom
claude/quirky-euler-p9dsfm

Conversation

@os-zhuang

Copy link
Copy Markdown
Contributor

Closes objectstack-ai/objectstack#3856.

The claim, confirmed

ActionRunner.executeScript read action.target || action.execute. Against @objectstack/spec 17 that fallback is unreachable — and by a stronger mechanism than objectstack#3856 assumed. #3742 dropped execute from parsed output; objectstack#3855 went further and tombstoned it, so the parser now rejects an authored execute with the rename prescription.

Verified empirically against the resolved 17.0.0-rc.0:

alias-only parse success: false
  error: execute: `execute` was removed in @objectstack/spec 17 (#3855) — use `target`.
         Rename the key; the value (a handler / flow / URL ref) is unchanged.
         Run `os migrate meta --from 16` to rewrite it automatically.
target-only parse success: true
  parsed keys: name, label, type, target, refreshAfter
  has execute on output: false

No parsed action can carry the key, so || could only ever yield target. Deleted rather than left as harmless residue: two handler slots is exactly what let one action run one script server-side and a different one client-side (objectstack#3713, where this renderer preferred the alias while the spec transform preferred target). A dead slot still reads as a live contract to the next maintainer.

The real finding: the type, not the fallback

objectstack#3856 asked whether a TypeScript reader here should already fail to compile, "because if it still compiles, something in objectui is reading a looser type than the spec's." It still compiled. Neither reader was typed against the spec's z.infer — both hand-declared the key:

Reader Was Now
@object-ui/types ActionSchema hand-declared execute?: string removed — execute: '…' fails tsc (TS2353) at the authoring site
@object-ui/core ActionDef hand-declared it too removed — but see below

ActionDef carries a [key: string]: any index signature, so removing the declaration produces no compile error there and stale hand-authored metadata (never parsed by the spec) still type-checks. Silently binding no handler is the objectstack#2169 "Mark Done does nothing" shape, so for that path executeScript now returns the rename prescription instead of a bare "No script provided" — the same reasoning the spec's own tombstone gives for keeping the removal audible. This is not a tolerant fallback: the script does not run.

Changes

  • @object-ui/coreexecuteScript reads target only; ActionDef.execute removed; retired-key branch returns the rename prescription (ordered after the existing body branch, since a body action ignores target and "rename it" would be wrong advice there).
  • @object-ui/typesActionSchema.execute removed; target documented as the only handler slot.
  • @object-ui/componentsaction:button, action:icon, action:menu, action:group stop forwarding execute into the runner.
  • @object-ui/app-shell — Studio's ActionPreview drops ?? d.execute; previewing an alias-only draft as "bound" contradicted the parse that rejects it on save.
  • Tests — the 18 execute:-authored actions across 6 suites move to target. The "should prefer canonical target over the deprecated execute alias" case becomes a regression test that the alias is not read and that the error prescribes the rename.

Grep is clean: no execute read on action metadata remains anywhere in packages/, apps/, or examples/. No docs, JSON, or example metadata authored the alias.

Verification

  • pnpm type-check — 76/76 tasks pass.
  • pnpm test — full suite green (action suites: 13 files / 204 tests).
  • pnpm lint — 45/45, 0 errors.
  • Compile channel probed both ways: execute on ActionSchema → TS2353; on ActionDef → still compiles (index signature), which is what the runtime prescription covers.

Requires @objectstack/spec 17. Metadata still on the alias is rewritten by os migrate meta --from 16.

🤖 Generated with Claude Code

https://claude.ai/code/session_014DBMo8gnFduzgpuSHd5Eje


Generated by Claude Code

…xecute` alias (objectstack#3856)

`ActionRunner.executeScript` read `action.target || action.execute`. Against
`@objectstack/spec` 17 that fallback is unreachable: `execute` is a tombstoned
key (objectstack#3855) the parser rejects with the rename prescription, so no
parsed action can carry it and the `||` could only ever yield `target`. Verified
against 17.0.0-rc.0 — an action declaring `execute` fails `ActionSchema.safeParse`
and a `target` action's parsed output has no `execute` key.

Deleted rather than kept as harmless residue: two handler slots is what let one
action run one script server-side and a different one client-side
(objectstack#3713, where this renderer preferred the alias while the spec
transform preferred `target`). A dead slot still reads as a live contract.

objectstack#3856 predicted a compile error here and there wasn't one — the real
finding. Neither reader was typed against the spec's `z.infer`; both
hand-declared the key:

- `@object-ui/types` `ActionSchema.execute` removed, so `execute: '…'` now fails
  `tsc` at the authoring site (TS2353).
- `@object-ui/core` `ActionDef.execute` removed too, but `ActionDef` carries a
  `[key: string]: any` index signature, so stale hand-authored metadata still
  compiles. For that path `executeScript` returns the rename prescription rather
  than a bare "No script provided" — removing an authorable key has to be
  audible, and binding no handler silently is the objectstack#2169 "Mark Done
  does nothing" shape.

The four action renderers stop forwarding `execute`, and Studio's `ActionPreview`
no longer falls back to it (previewing an alias-only draft as bound contradicted
the parse that rejects it on save). Tests move to `target`; the "prefer canonical
over the alias" case becomes a regression test that the alias is not read.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_014DBMo8gnFduzgpuSHd5Eje
@vercel

vercel Bot commented Jul 30, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated (UTC)
objectui Ignored Ignored Jul 30, 2026 7:40am

Request Review

@github-actions

Copy link
Copy Markdown
Contributor

✅ Console Performance Budget

Metric Value Budget
Main entry (gzip) 27.9 KB 350 KB
Entry file index-D7aOzQPW.js
Status PASS

📦 Bundle Size Report

Package Size Gzipped
app-shell (index.js) 8.20KB 2.97KB
app-shell (runtime-config.js) 7.42KB 2.32KB
app-shell (types.js) 0.01KB 0.04KB
app-shell (urlParams.js) 7.57KB 2.97KB
auth (AuthContext.js) 0.31KB 0.24KB
auth (AuthGuard.js) 1.17KB 0.53KB
auth (AuthProvider.js) 22.10KB 4.37KB
auth (AuthShell.js) 3.49KB 1.40KB
auth (ForgotPasswordForm.js) 12.12KB 3.41KB
auth (LoginForm.js) 17.86KB 5.29KB
auth (PreviewBanner.js) 0.90KB 0.50KB
auth (RegisterForm.js) 6.43KB 2.09KB
auth (SocialSignInButtons.js) 9.60KB 3.89KB
auth (UserMenu.js) 3.40KB 1.22KB
auth (auth-gate-events.js) 1.29KB 0.66KB
auth (authStyles.js) 5.04KB 1.72KB
auth (createAuthClient.js) 35.76KB 9.11KB
auth (createAuthenticatedFetch.js) 4.37KB 1.69KB
auth (index.js) 2.25KB 1.01KB
auth (org-roles.js) 6.72KB 2.85KB
auth (phone-identifier.js) 1.11KB 0.66KB
auth (types.js) 0.59KB 0.35KB
auth (useAuth.js) 4.91KB 0.87KB
auth (useIsWorkspaceAdmin.js) 1.61KB 0.85KB
collaboration (CommentThread.js) 18.38KB 4.49KB
collaboration (LiveCursors.js) 3.17KB 1.27KB
collaboration (PresenceAvatars.js) 3.65KB 1.42KB
collaboration (PresenceProvider.js) 2.79KB 1.13KB
collaboration (index.js) 1.25KB 0.53KB
collaboration (useCommentSearch.js) 1.98KB 0.88KB
collaboration (useConflictResolution.js) 7.75KB 1.86KB
collaboration (useMentionNotifications.js) 1.81KB 0.68KB
collaboration (usePresence.js) 6.33KB 1.84KB
collaboration (useRealtimeSubscription.js) 7.91KB 2.01KB
components (index.js) 450.65KB 98.07KB
core (index.js) 2.16KB 0.78KB
create-plugin (index.js) 9.28KB 2.98KB
data-objectstack (index.js) 134.67KB 34.24KB
fields (index.js) 221.10KB 54.18KB
i18n (LocalizationContext.js) 1.76KB 0.96KB
i18n (currency.js) 1.22KB 0.64KB
i18n (i18n.js) 4.32KB 1.77KB
i18n (index.js) 2.46KB 0.96KB
i18n (pickLocalized.js) 1.70KB 0.83KB
i18n (provider.js) 5.37KB 1.72KB
i18n (useObjectLabel.js) 25.17KB 5.80KB
i18n (useSafeTranslation.js) 3.26KB 1.44KB
layout (index.js) 38.45KB 10.67KB
mobile (MobileProvider.js) 0.92KB 0.49KB
mobile (ResponsiveContainer.js) 0.94KB 0.38KB
mobile (breakpoints.js) 1.51KB 0.70KB
mobile (createOfflineDataSource.js) 5.61KB 1.74KB
mobile (index.js) 1.50KB 0.62KB
mobile (offlineQueue.js) 3.91KB 1.35KB
mobile (pwa.js) 0.97KB 0.49KB
mobile (serviceWorker.js) 1.48KB 0.62KB
mobile (serviceWorkerSource.js) 3.41KB 1.48KB
mobile (useBreakpoint.js) 1.54KB 0.65KB
mobile (useGesture.js) 4.42KB 1.27KB
mobile (useOfflineSync.js) 1.99KB 0.72KB
mobile (usePullToRefresh.js) 2.53KB 0.85KB
mobile (useResponsive.js) 0.71KB 0.42KB
mobile (useResponsiveConfig.js) 1.36KB 0.63KB
mobile (useSpecGesture.js) 1.77KB 0.77KB
mobile (useTouchTarget.js) 1.01KB 0.54KB
permissions (MePermissionsProvider.js) 6.84KB 2.42KB
permissions (PermissionContext.js) 0.31KB 0.25KB
permissions (PermissionGuard.js) 0.89KB 0.45KB
permissions (PermissionProvider.js) 3.67KB 1.12KB
permissions (evaluator.js) 4.41KB 1.44KB
permissions (index.js) 0.91KB 0.41KB
permissions (store.js) 0.91KB 0.42KB
permissions (useFieldPermissions.js) 1.28KB 0.52KB
permissions (usePermissions.js) 1.55KB 0.71KB
plugin-ai (index.js) 15.71KB 3.79KB
plugin-calendar (index.js) 44.90KB 12.35KB
plugin-charts (index.js) 57.26KB 16.24KB
plugin-chatbot (index.js) 179.93KB 42.67KB
plugin-dashboard (index.js) 109.60KB 28.33KB
plugin-designer (index.js) 210.56KB 42.56KB
plugin-detail (index.js) 216.52KB 53.02KB
plugin-editor (index.js) 2.46KB 1.10KB
plugin-form (index.js) 103.45KB 25.12KB
plugin-gantt (index.js) 162.26KB 39.53KB
plugin-grid (index.js) 179.45KB 47.03KB
plugin-kanban (index.js) 47.82KB 13.18KB
plugin-list (index.js) 98.30KB 23.23KB
plugin-map (index.js) 16.80KB 5.24KB
plugin-markdown (index.js) 13.65KB 4.67KB
plugin-report (index.js) 37.77KB 10.00KB
plugin-timeline (index.js) 25.03KB 7.11KB
plugin-tree (index.js) 8.36KB 2.81KB
plugin-view (index.js) 85.47KB 20.82KB
providers (DataSourceProvider.js) 0.75KB 0.39KB
providers (MetadataProvider.js) 1.37KB 0.59KB
providers (ThemeProvider.js) 1.55KB 0.67KB
providers (UploadProvider.js) 11.71KB 3.53KB
providers (index.js) 0.44KB 0.22KB
providers (types.js) 0.01KB 0.04KB
react-runtime (index.js) 5.67KB 2.37KB
react (LazyPluginLoader.js) 3.77KB 1.33KB
react (SchemaRenderer.js) 19.28KB 6.38KB
react (data-invalidation.js) 5.05KB 2.08KB
react (index.js) 1.02KB 0.55KB
sdui-parser (codegen.js) 4.09KB 1.74KB
sdui-parser (index.js) 3.47KB 1.54KB
sdui-parser (parse.js) 10.04KB 2.82KB
sdui-parser (types.js) 0.29KB 0.24KB
sdui-parser (validate.js) 4.69KB 1.48KB
types (ai.js) 0.20KB 0.17KB
types (api-types.js) 0.20KB 0.18KB
types (app.js) 2.87KB 0.99KB
types (base.js) 0.20KB 0.18KB
types (blocks.js) 0.20KB 0.18KB
types (complex.js) 0.20KB 0.18KB
types (crud.js) 0.20KB 0.18KB
types (data-display.js) 0.20KB 0.18KB
types (data-protocol.js) 0.20KB 0.19KB
types (data.js) 0.20KB 0.18KB
types (designer.js) 0.77KB 0.41KB
types (disclosure.js) 0.20KB 0.18KB
types (error-code.js) 1.54KB 0.88KB
types (feedback.js) 0.20KB 0.18KB
types (field-types.js) 0.20KB 0.18KB
types (form.js) 0.20KB 0.18KB
types (index.js) 1.92KB 0.93KB
types (layout.js) 0.20KB 0.18KB
types (managed-by.js) 0.19KB 0.18KB
types (mobile.js) 0.20KB 0.18KB
types (navigation.js) 0.20KB 0.18KB
types (objectql.js) 0.20KB 0.18KB
types (overlay.js) 0.20KB 0.18KB
types (permissions.js) 0.20KB 0.18KB
types (plugin-scope.js) 0.20KB 0.18KB
types (record-components.js) 0.20KB 0.19KB
types (record-semantics.js) 1.28KB 0.67KB
types (registry.js) 0.20KB 0.18KB
types (reports.js) 0.20KB 0.18KB
types (spec-report.js) 5.04KB 1.93KB
types (system-fields.js) 2.39KB 1.17KB
types (theme.js) 0.20KB 0.18KB
types (ui-action.js) 0.75KB 0.46KB
types (views.js) 0.20KB 0.18KB
types (widget.js) 0.20KB 0.18KB

Size Limits

  • ✅ Core packages should be < 50KB gzipped
  • ✅ Component packages should be < 100KB gzipped
  • ⚠️ Plugin packages should be < 150KB gzipped

@os-zhuang
os-zhuang marked this pull request as ready for review July 30, 2026 08:06
@os-zhuang
os-zhuang merged commit 9e7349e into main Jul 30, 2026
16 checks passed
@os-zhuang
os-zhuang deleted the claude/quirky-euler-p9dsfm branch July 30, 2026 08:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[P3] objectui ActionRunner: the execute || target fallback is dead code since #3742 — confirm and delete

2 participants