Skip to content

fix(console): a flow or action that failed under HTTP 200 stops reporting success (#2958) - #2995

Merged
os-zhuang merged 1 commit into
mainfrom
claude/action-flow-false-success-627dac
Jul 30, 2026
Merged

fix(console): a flow or action that failed under HTTP 200 stops reporting success (#2958)#2995
os-zhuang merged 1 commit into
mainfrom
claude/action-flow-false-success-627dac

Conversation

@os-zhuang

@os-zhuang os-zhuang commented Jul 30, 2026

Copy link
Copy Markdown
Contributor

Closes #2958.

Business failures come back HTTP 200 with the failure on the inner envelope (objectstack#3913), and a failed flow launch carries neither status nor screen. Three call sites read that response by hand and two read it incompletely, so a failed run was indistinguishable from a completed one: no dialog, a green "completed successfully" toast, a refresh, and the real error swallowed.

What changed

utils/flowResponse.ts (new) — the flow trigger/resume rule, once. Classifies transport failure / flow failure / screen pause / terminal success, and guarantees error is a string.

Failure is classified before paused, which is safe: the engine always stamps success: true alongside status: 'paused' (verified in framework service-automation/src/engine.ts — both paused returns). So a wizard can never be swallowed by the new check.

Site Before After
useConsoleActionRuntime.flowHandler outer envelope only → failure fell into the terminal-success return success: false, no refresh
RecordDetailView.flowHandler same, plus raw json.error passthrough shares the interpreter; error coerced
FlowRunner.resumeWith correct, but toasted the raw error value shares the interpreter; keeps retryable-vs-terminal close behaviour
useConsoleActionRuntime.apiHandler res.ok only → refreshed on a rejected call success: false classified before the refresh

The script handler needed no change — it was already fixed via interpretActionResponse. This is that same lesson on the automation route.

Defect 3 (the raw error value)

RecordDetailView passed json.error straight through and FlowRunner passed data.error. The nested {code, message} shape reaches toast.error() as a React child and crashes the page (React #31) — the trap actionErrorDetail exists for. Both now route through it.

Tests

  • utils/__tests__/flowResponse.test.ts — 18 cases over every response shape, incl. the object-shaped-error coercion and "paused is not a failure".
  • useConsoleActionRuntime.test.tsx — 6 handler-level cases pinning the reported repro (failed launch, errorMessage preference, wizard still opens, nested-error coercion, apiHandler 200-failure, and that a payload merely containing a success key is left alone).
  • flow-envelope.ratchet.test.ts (new) — sibling of the existing /actions ratchet, so the rule cannot be hand-rolled back into three copies. Scoped to trigger/resume callers, since most automation callers just read the registry.

Verified the tests actually catch the bug: neutralising the inner-failure branch fails 9 tests, including the pre-existing FlowRunner terminal-failure test — confirming all three sites now share one rule. Neutralising the apiHandler check fails its test.

unit + dom + dom-heavy projects run clean (830 app-shell dom tests, 217 dom-heavy). Typecheck error count is unchanged from main (7 pre-existing @object-ui/types stale-dist errors, none in touched files); 0 lint errors.

🤖 Generated with Claude Code

@os-zhuang @claude
fix(console): a flow or action that failed under HTTP 200 stops repor…
90805fa 
…ting success (#2958)

Business failures come back HTTP 200 with the failure on the INNER envelope
(objectstack#3913), and a failed flow launch carries neither `status` nor
`screen`. Three call sites read that response by hand and two read it
incompletely, so a failed run was indistinguishable from a completed one: no
dialog, a green "completed successfully" toast, a refresh, and the real error
swallowed.

- `utils/flowResponse.ts` (new) — the flow trigger/resume rule, once:
  transport failure / flow failure / screen pause / terminal success, with
  `error` guaranteed to be a STRING. Failure is classified before `paused`,
  which is safe because the engine always stamps `success: true` alongside
  `status: 'paused'` (service-automation engine.ts).
- Both flow-launch handlers (`useConsoleActionRuntime`, `RecordDetailView`)
  now go through it, so a launch that failed returns `success: false` and no
  longer refreshes. RecordDetailView additionally stops passing `json.error`
  through raw — the nested `{code, message}` shape reaches `toast.error()` as
  a React child and crashes the page (React #31).
- `FlowRunner`'s resume shares the same interpreter, keeping its retryable
  (transport) vs terminal (flow) close behaviour and gaining the coercion.
- `apiHandler` classifies an HTTP-200 `success: false` body as a failure
  before refreshing on it.

The `script` handler was already fixed via `interpretActionResponse`; this is
the same lesson on the automation route, with a matching ratchet test so the
rule cannot be hand-rolled back into three copies.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
@vercel

vercel Bot commented Jul 30, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated (UTC)
objectui Ignored Ignored Jul 30, 2026 8:17am

Request Review

@github-actions github-actions Bot added the tests label Jul 30, 2026
@github-actions

github-actions Bot commented Jul 30, 2026

Copy link
Copy Markdown
Contributor

✅ Console Performance Budget

Metric Value Budget
Main entry (gzip) 27.9 KB 350 KB
Entry file index-C4PqhKXr.js —
Status PASS —

📦 Bundle Size Report

Package Size Gzipped
app-shell (index.js) 8.20KB 2.97KB
app-shell (runtime-config.js) 7.42KB 2.32KB
app-shell (types.js) 0.01KB 0.04KB
app-shell (urlParams.js) 7.57KB 2.97KB
auth (AuthContext.js) 0.31KB 0.24KB
auth (AuthGuard.js) 1.17KB 0.53KB
auth (AuthProvider.js) 22.10KB 4.37KB
auth (AuthShell.js) 3.49KB 1.40KB
auth (ForgotPasswordForm.js) 12.12KB 3.41KB
auth (LoginForm.js) 17.86KB 5.29KB
auth (PreviewBanner.js) 0.90KB 0.50KB
auth (RegisterForm.js) 6.43KB 2.09KB
auth (SocialSignInButtons.js) 9.60KB 3.89KB
auth (UserMenu.js) 3.40KB 1.22KB
auth (auth-gate-events.js) 1.29KB 0.66KB
auth (authStyles.js) 5.04KB 1.72KB
auth (createAuthClient.js) 35.76KB 9.11KB
auth (createAuthenticatedFetch.js) 4.37KB 1.69KB
auth (index.js) 2.25KB 1.01KB
auth (org-roles.js) 6.72KB 2.85KB
auth (phone-identifier.js) 1.11KB 0.66KB
auth (types.js) 0.59KB 0.35KB
auth (useAuth.js) 4.91KB 0.87KB
auth (useIsWorkspaceAdmin.js) 1.61KB 0.85KB
collaboration (CommentThread.js) 18.38KB 4.49KB
collaboration (LiveCursors.js) 3.17KB 1.27KB
collaboration (PresenceAvatars.js) 3.65KB 1.42KB
collaboration (PresenceProvider.js) 2.79KB 1.13KB
collaboration (index.js) 1.25KB 0.53KB
collaboration (useCommentSearch.js) 1.98KB 0.88KB
collaboration (useConflictResolution.js) 7.75KB 1.86KB
collaboration (useMentionNotifications.js) 1.81KB 0.68KB
collaboration (usePresence.js) 6.33KB 1.84KB
collaboration (useRealtimeSubscription.js) 7.91KB 2.01KB
components (index.js) 454.03KB 99.05KB
core (index.js) 2.16KB 0.78KB
create-plugin (index.js) 9.28KB 2.98KB
data-objectstack (index.js) 134.67KB 34.24KB
fields (index.js) 221.10KB 54.18KB
i18n (LocalizationContext.js) 1.76KB 0.96KB
i18n (currency.js) 1.22KB 0.64KB
i18n (i18n.js) 4.32KB 1.77KB
i18n (index.js) 2.46KB 0.96KB
i18n (pickLocalized.js) 1.70KB 0.83KB
i18n (provider.js) 5.37KB 1.72KB
i18n (useObjectLabel.js) 25.17KB 5.80KB
i18n (useSafeTranslation.js) 3.26KB 1.44KB
layout (index.js) 38.45KB 10.67KB
mobile (MobileProvider.js) 0.92KB 0.49KB
mobile (ResponsiveContainer.js) 0.94KB 0.38KB
mobile (breakpoints.js) 1.51KB 0.70KB
mobile (createOfflineDataSource.js) 5.61KB 1.74KB
mobile (index.js) 1.50KB 0.62KB
mobile (offlineQueue.js) 3.91KB 1.35KB
mobile (pwa.js) 0.97KB 0.49KB
mobile (serviceWorker.js) 1.48KB 0.62KB
mobile (serviceWorkerSource.js) 3.41KB 1.48KB
mobile (useBreakpoint.js) 1.54KB 0.65KB
mobile (useGesture.js) 4.42KB 1.27KB
mobile (useOfflineSync.js) 1.99KB 0.72KB
mobile (usePullToRefresh.js) 2.53KB 0.85KB
mobile (useResponsive.js) 0.71KB 0.42KB
mobile (useResponsiveConfig.js) 1.36KB 0.63KB
mobile (useSpecGesture.js) 1.77KB 0.77KB
mobile (useTouchTarget.js) 1.01KB 0.54KB
permissions (MePermissionsProvider.js) 6.84KB 2.42KB
permissions (PermissionContext.js) 0.31KB 0.25KB
permissions (PermissionGuard.js) 0.89KB 0.45KB
permissions (PermissionProvider.js) 3.67KB 1.12KB
permissions (evaluator.js) 4.41KB 1.44KB
permissions (index.js) 0.91KB 0.41KB
permissions (store.js) 0.91KB 0.42KB
permissions (useFieldPermissions.js) 1.28KB 0.52KB
permissions (usePermissions.js) 1.55KB 0.71KB
plugin-ai (index.js) 15.71KB 3.79KB
plugin-calendar (index.js) 44.90KB 12.35KB
plugin-charts (index.js) 57.26KB 16.24KB
plugin-chatbot (index.js) 180.09KB 42.72KB
plugin-dashboard (index.js) 110.24KB 28.47KB
plugin-designer (index.js) 210.56KB 42.56KB
plugin-detail (index.js) 216.52KB 53.02KB
plugin-editor (index.js) 2.46KB 1.10KB
plugin-form (index.js) 103.30KB 25.07KB
plugin-gantt (index.js) 162.26KB 39.53KB
plugin-grid (index.js) 179.53KB 47.06KB
plugin-kanban (index.js) 47.82KB 13.18KB
plugin-list (index.js) 98.89KB 23.41KB
plugin-map (index.js) 16.80KB 5.24KB
plugin-markdown (index.js) 13.65KB 4.67KB
plugin-report (index.js) 40.24KB 10.51KB
plugin-timeline (index.js) 25.03KB 7.11KB
plugin-tree (index.js) 8.36KB 2.81KB
plugin-view (index.js) 85.88KB 20.99KB
providers (DataSourceProvider.js) 0.75KB 0.39KB
providers (MetadataProvider.js) 1.37KB 0.59KB
providers (ThemeProvider.js) 1.55KB 0.67KB
providers (UploadProvider.js) 11.71KB 3.53KB
providers (index.js) 0.44KB 0.22KB
providers (types.js) 0.01KB 0.04KB
react-runtime (index.js) 5.67KB 2.37KB
react (LazyPluginLoader.js) 3.77KB 1.33KB
react (SchemaRenderer.js) 19.28KB 6.38KB
react (data-invalidation.js) 5.05KB 2.08KB
react (index.js) 1.02KB 0.55KB
sdui-parser (codegen.js) 4.09KB 1.74KB
sdui-parser (index.js) 3.47KB 1.54KB
sdui-parser (parse.js) 10.04KB 2.82KB
sdui-parser (types.js) 0.29KB 0.24KB
sdui-parser (validate.js) 4.69KB 1.48KB
types (ai.js) 0.20KB 0.17KB
types (api-types.js) 0.20KB 0.18KB
types (app.js) 2.87KB 0.99KB
types (base.js) 0.20KB 0.18KB
types (blocks.js) 0.20KB 0.18KB
types (complex.js) 0.20KB 0.18KB
types (crud.js) 0.20KB 0.18KB
types (data-display.js) 0.20KB 0.18KB
types (data-protocol.js) 0.20KB 0.19KB
types (data.js) 0.20KB 0.18KB
types (designer.js) 0.77KB 0.41KB
types (disclosure.js) 0.20KB 0.18KB
types (error-code.js) 1.54KB 0.88KB
types (feedback.js) 0.20KB 0.18KB
types (field-types.js) 0.20KB 0.18KB
types (form.js) 0.20KB 0.18KB
types (index.js) 1.94KB 0.95KB
types (layout.js) 0.20KB 0.18KB
types (managed-by.js) 0.19KB 0.18KB
types (mobile.js) 0.20KB 0.18KB
types (navigation.js) 0.20KB 0.18KB
types (objectql.js) 0.20KB 0.18KB
types (overlay.js) 0.20KB 0.18KB
types (permissions.js) 0.20KB 0.18KB
types (plugin-scope.js) 0.20KB 0.18KB
types (record-components.js) 0.20KB 0.19KB
types (record-semantics.js) 1.28KB 0.67KB
types (registry.js) 0.20KB 0.18KB
types (reports.js) 0.20KB 0.18KB
types (spec-report.js) 5.04KB 1.93KB
types (system-fields.js) 2.39KB 1.17KB
types (theme.js) 0.20KB 0.18KB
types (ui-action.js) 0.82KB 0.48KB
types (views.js) 0.20KB 0.18KB
types (widget.js) 0.20KB 0.18KB

Size Limits

  • ✅ Core packages should be < 50KB gzipped
  • ✅ Component packages should be < 100KB gzipped
  • ⚠️ Plugin packages should be < 150KB gzipped

@os-zhuang
os-zhuang merged commit 83e3520 into main Jul 30, 2026
16 checks passed
@os-zhuang
os-zhuang deleted the claude/action-flow-false-success-627dac branch July 30, 2026 08:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

tests

Projects

None yet

Milestone

No milestone

1 participant

@os-zhuang