Skip to content

fix(components,app-shell): the last two direction props follow v4's rename to orientation #3025

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
os-zhuang merged 1 commit into from
Jul 30, 2026
Merged

fix(components,app-shell): the last two direction props follow v4's rename to orientation #3025

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 3 additions & 8 deletions packages/app-shell/src/views/metadata-admin/ResourceEditPage.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,11 +117,6 @@ import { describeIssuePath } from './issuePath';
import { buildCreateModeBody } from './createBody';
import { errorCodeIs, errorCodeIsAnyOf } from '@object-ui/types';

// react-resizable-panels' `direction` prop type does not always narrow
// cleanly in our TS config; cast at the boundary (precedent:
// packages/components/src/custom/navigation-overlay.tsx).
const PanelGroup = ResizablePanelGroup as React.FC<any>;

/**
* Metadata types whose canvas IS the primary create-time authoring
* surface, so we render the preview/inspector split during create
Expand Down Expand Up @@ -2060,8 +2055,8 @@ function MetadataResourceEditPageImpl({
: 'relative flex-1 min-h-0 flex'
}
>
<PanelGroup
direction="horizontal"
<ResizablePanelGroup
orientation="horizontal"
className="flex-1 min-h-0 rounded-md border bg-background overflow-hidden"
id={`metadata-edit-${type}`}
>
Expand Down Expand Up @@ -2336,7 +2331,7 @@ function MetadataResourceEditPageImpl({
</div>
</div>
</ResizablePanel>
</PanelGroup>
</ResizablePanelGroup>
{/* The floating reopen pill that used to live here was
removed: the canvas toolbar already hosts a permanent
VSCode-style inspector toggle next to the fullscreen
Expand Down
8 changes: 2 additions & 6 deletions packages/components/src/custom/navigation-overlay.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -460,12 +460,8 @@ export const NavigationOverlay: React.FC<NavigationOverlayProps> = ({
: 40;
const mainPercent = 100 - detailPercent;

// Cast needed: ResizablePanelGroup has correct runtime behavior but
// vite-plugin-dts may not resolve the direction prop type correctly
const PanelGroup = ResizablePanelGroup as React.FC<any>;

return (
<PanelGroup direction="horizontal" className={cn('h-full', className)}>
<ResizablePanelGroup orientation="horizontal" className={cn('h-full', className)}>
<ResizablePanel defaultSize={mainPercent} minSize={30}>
{mainContent}
</ResizablePanel>
Expand Down Expand Up @@ -501,7 +497,7 @@ export const NavigationOverlay: React.FC<NavigationOverlayProps> = ({
{renderContent(selectedRecord)}
</div>
</ResizablePanel>
</PanelGroup>
</ResizablePanelGroup>
);
}

Expand Down
Loading