Skip to content

fix(registry): prefix every namespaced key exactly once, in every namespace - #3037

Merged
os-zhuang merged 1 commit into
mainfrom
claude/react-lazy-block-scope-bpvef6
Jul 30, 2026
Merged

fix(registry): prefix every namespaced key exactly once, in every namespace#3037
os-zhuang merged 1 commit into
mainfrom
claude/react-lazy-block-scope-bpvef6

Conversation

@os-zhuang

Copy link
Copy Markdown
Contributor

#3023 fixed eleven record:* blocks registered as register('record:x', …, { namespace: 'record' }) — an already-prefixed name handed to a registry that prefixes it again — and guarded that namespace alone. Twenty-two more were sitting elsewhere:

namespace doubled keys includes
element: 10 element:divider (curated)
page: 7 page:header (curated)
action: 5

Checking one namespace is exactly what let them keep sitting there, so the guard now asks the whole registry rather than a prefix of it.

Fix

Same as before — register the bare name, let namespace do the prefixing, skipFallback: true so the fallback doesn't claim that bare name globally:

-ComponentRegistry.register('page:header', PageHeaderRenderer, {
+ComponentRegistry.register('header', PageHeaderRenderer, {
   namespace: 'page',
+  skipFallback: true,

skipFallback is doing real work here. Without it these 22 would take over header, footer, sidebar, tabs, card, accordion, section, text, image, button, icon as top-level tags — every one of which belongs to ui:. Verified after the change: all still owned by ui, none stolen.

before after
registry keys 522 500
doubled keys 22 0
contract 42/42 42/42
page:header canonical page:page:header page:header
element:divider canonical element:element:divider element:divider

Nothing in the repo referenced a doubled key.

Guard generalized

The record-only doubled-prefix assertion is replaced by a registry-wide one. Verified by reverting a single registration:

AssertionError: expected [ 'element:element:divider' ] to deeply equal []

What this came out of, and a correction

I went looking because six curated Tier B primitives (grid, page:header, text, image, element:divider, html) reported no inputs in the console contract.

They do declare inputs. vitest.setup.dom.tsx registers simplified text / image / html / grid stubs, and because the setup imports @object-ui/components first, the real registrations run and are then overwritten by the stubs — inside the test environment only. text, for one, really declares content (required) in packages/components/src/renderers/basic/text.tsx.

So the "missing inputs" was a test-environment artifact, not a product gap. That shadowing is a separate question and I've left it alone — but it does mean this file's picture of the contract is partly fiction for those four tags, which is worth knowing before anyone writes an assertion that depends on them.

The doubled keys the probe turned up along the way are not artifacts — they reproduce against the real registrations.

Full suite 737 passed | 1 skipped, lint 0 errors, type-check 38/38, changeset included.

🤖 Generated with Claude Code

https://claude.ai/code/session_01N4mrr1ihhwnfEHFSWmGoMp


Generated by Claude Code

…espace

#3023 fixed eleven record:* blocks registered as
register('record:x', …, { namespace: 'record' }) — an already-prefixed name
handed to a registry that prefixes it again, landing the block at
record:record:x — and guarded that namespace alone. Twenty-two more were
sitting in action: (5), element: (10) and page: (7), two of them
(page:header, element:divider) curated public blocks.

Checking one namespace is exactly what let them keep sitting there, so the
guard now asks the whole registry rather than a prefix of it.

Same fix as before: register the bare name and let `namespace` do the
prefixing, with skipFallback: true so the fallback does not claim that bare
name globally. It would otherwise take over `header`, `footer`, `sidebar`,
`tabs`, `card`, `accordion`, `section`, `text`, `image`, `button`, `icon` —
every one of which belongs to ui:. All 22 stay reachable exactly as
<namespace>:<name>; the registry goes 522 keys to 500, and the contract is
unchanged at 42/42.

Found while probing why six curated Tier B primitives report no `inputs`. They
do declare them — vitest.setup.dom.tsx registers simplified text / image /
html / grid stubs that shadow the real registrations inside the test
environment only. That shadowing is a separate question, left alone here; the
doubled keys it turned up are not test-environment artifacts.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01N4mrr1ihhwnfEHFSWmGoMp
@vercel

vercel Bot commented Jul 30, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated (UTC)
objectui Ignored Ignored Jul 30, 2026 1:04pm

Request Review

@github-actions

Copy link
Copy Markdown
Contributor

✅ Console Performance Budget

Metric Value Budget
Main entry (gzip) 27.9 KB 350 KB
Entry file index-Cc_98Owl.js
Status PASS

📦 Bundle Size Report

Package Size Gzipped
app-shell (index.js) 8.20KB 2.97KB
app-shell (runtime-config.js) 7.42KB 2.32KB
app-shell (types.js) 0.01KB 0.04KB
app-shell (urlParams.js) 7.57KB 2.97KB
auth (AuthContext.js) 0.31KB 0.24KB
auth (AuthGuard.js) 1.17KB 0.53KB
auth (AuthProvider.js) 22.10KB 4.37KB
auth (AuthShell.js) 3.49KB 1.40KB
auth (ForgotPasswordForm.js) 12.12KB 3.41KB
auth (LoginForm.js) 17.86KB 5.29KB
auth (PreviewBanner.js) 0.90KB 0.50KB
auth (RegisterForm.js) 6.43KB 2.09KB
auth (SocialSignInButtons.js) 9.60KB 3.89KB
auth (UserMenu.js) 3.40KB 1.22KB
auth (auth-gate-events.js) 1.29KB 0.66KB
auth (authStyles.js) 5.04KB 1.72KB
auth (createAuthClient.js) 35.76KB 9.11KB
auth (createAuthenticatedFetch.js) 4.37KB 1.69KB
auth (index.js) 2.25KB 1.01KB
auth (org-roles.js) 6.72KB 2.85KB
auth (phone-identifier.js) 1.11KB 0.66KB
auth (types.js) 0.59KB 0.35KB
auth (useAuth.js) 4.91KB 0.87KB
auth (useIsWorkspaceAdmin.js) 1.61KB 0.85KB
collaboration (CommentThread.js) 18.38KB 4.49KB
collaboration (LiveCursors.js) 3.17KB 1.27KB
collaboration (PresenceAvatars.js) 3.65KB 1.42KB
collaboration (PresenceProvider.js) 2.79KB 1.13KB
collaboration (index.js) 1.25KB 0.53KB
collaboration (useCommentSearch.js) 1.98KB 0.88KB
collaboration (useConflictResolution.js) 7.75KB 1.86KB
collaboration (useMentionNotifications.js) 1.81KB 0.68KB
collaboration (usePresence.js) 6.33KB 1.84KB
collaboration (useRealtimeSubscription.js) 7.91KB 2.01KB
components (index.js) 457.97KB 100.09KB
core (index.js) 2.16KB 0.78KB
create-plugin (index.js) 9.28KB 2.98KB
data-objectstack (index.js) 134.67KB 34.24KB
fields (index.js) 222.07KB 54.35KB
i18n (LocalizationContext.js) 1.76KB 0.96KB
i18n (currency.js) 1.22KB 0.64KB
i18n (i18n.js) 4.32KB 1.77KB
i18n (index.js) 2.46KB 0.96KB
i18n (pickLocalized.js) 1.70KB 0.83KB
i18n (provider.js) 5.37KB 1.72KB
i18n (useObjectLabel.js) 25.17KB 5.80KB
i18n (useSafeTranslation.js) 3.26KB 1.44KB
layout (index.js) 38.45KB 10.67KB
mobile (MobileProvider.js) 0.92KB 0.49KB
mobile (ResponsiveContainer.js) 0.94KB 0.38KB
mobile (breakpoints.js) 1.51KB 0.70KB
mobile (createOfflineDataSource.js) 5.61KB 1.74KB
mobile (index.js) 1.50KB 0.62KB
mobile (offlineQueue.js) 3.91KB 1.35KB
mobile (pwa.js) 0.97KB 0.49KB
mobile (serviceWorker.js) 1.48KB 0.62KB
mobile (serviceWorkerSource.js) 3.41KB 1.48KB
mobile (useBreakpoint.js) 1.54KB 0.65KB
mobile (useGesture.js) 6.96KB 1.98KB
mobile (useOfflineSync.js) 1.99KB 0.72KB
mobile (usePullToRefresh.js) 2.53KB 0.85KB
mobile (useResponsive.js) 0.71KB 0.42KB
mobile (useResponsiveConfig.js) 1.36KB 0.63KB
mobile (useSpecGesture.js) 4.05KB 1.53KB
mobile (useTouchTarget.js) 1.01KB 0.54KB
permissions (MePermissionsProvider.js) 6.84KB 2.42KB
permissions (PermissionContext.js) 0.31KB 0.25KB
permissions (PermissionGuard.js) 0.89KB 0.45KB
permissions (PermissionProvider.js) 3.67KB 1.12KB
permissions (evaluator.js) 4.41KB 1.44KB
permissions (index.js) 0.91KB 0.41KB
permissions (store.js) 0.91KB 0.42KB
permissions (useFieldPermissions.js) 1.28KB 0.52KB
permissions (usePermissions.js) 1.55KB 0.71KB
plugin-ai (index.js) 15.71KB 3.79KB
plugin-calendar (index.js) 44.90KB 12.35KB
plugin-charts (index.js) 60.52KB 17.11KB
plugin-chatbot (index.js) 180.09KB 42.72KB
plugin-dashboard (index.js) 111.59KB 28.74KB
plugin-designer (index.js) 210.56KB 42.56KB
plugin-detail (index.js) 221.50KB 54.15KB
plugin-editor (index.js) 2.46KB 1.10KB
plugin-form (index.js) 106.35KB 25.82KB
plugin-gantt (index.js) 162.26KB 39.53KB
plugin-grid (index.js) 183.96KB 48.23KB
plugin-kanban (index.js) 47.82KB 13.18KB
plugin-list (index.js) 102.39KB 24.18KB
plugin-map (index.js) 16.80KB 5.24KB
plugin-markdown (index.js) 13.65KB 4.67KB
plugin-report (index.js) 40.32KB 10.53KB
plugin-timeline (index.js) 25.75KB 7.32KB
plugin-tree (index.js) 8.36KB 2.81KB
plugin-view (index.js) 85.91KB 20.99KB
providers (DataSourceProvider.js) 0.75KB 0.39KB
providers (MetadataProvider.js) 1.37KB 0.59KB
providers (ThemeProvider.js) 1.90KB 0.85KB
providers (UploadProvider.js) 11.71KB 3.53KB
providers (index.js) 0.44KB 0.22KB
providers (types.js) 0.01KB 0.04KB
react-runtime (index.js) 5.67KB 2.37KB
react (LazyPluginLoader.js) 3.77KB 1.33KB
react (SchemaRenderer.js) 19.28KB 6.38KB
react (data-invalidation.js) 5.05KB 2.08KB
react (index.js) 1.02KB 0.55KB
sdui-parser (codegen.js) 4.09KB 1.74KB
sdui-parser (index.js) 3.47KB 1.54KB
sdui-parser (parse.js) 10.04KB 2.82KB
sdui-parser (types.js) 0.29KB 0.24KB
sdui-parser (validate.js) 4.69KB 1.48KB
types (ai.js) 0.20KB 0.17KB
types (api-types.js) 0.20KB 0.18KB
types (app.js) 2.87KB 0.99KB
types (base.js) 0.20KB 0.18KB
types (blocks.js) 0.20KB 0.18KB
types (complex.js) 0.20KB 0.18KB
types (crud.js) 0.20KB 0.18KB
types (data-display.js) 0.20KB 0.18KB
types (data-protocol.js) 0.20KB 0.19KB
types (data.js) 0.20KB 0.18KB
types (designer.js) 0.77KB 0.41KB
types (disclosure.js) 0.20KB 0.18KB
types (error-code.js) 1.54KB 0.88KB
types (feedback.js) 0.20KB 0.18KB
types (field-types.js) 0.20KB 0.18KB
types (form.js) 0.20KB 0.18KB
types (index.js) 2.00KB 0.96KB
types (layout.js) 0.20KB 0.18KB
types (managed-by.js) 0.19KB 0.18KB
types (mobile.js) 0.20KB 0.18KB
types (navigation.js) 0.20KB 0.18KB
types (objectql.js) 0.20KB 0.18KB
types (overlay.js) 0.20KB 0.18KB
types (permissions.js) 0.20KB 0.18KB
types (plugin-scope.js) 0.20KB 0.18KB
types (record-components.js) 0.20KB 0.19KB
types (record-semantics.js) 1.28KB 0.67KB
types (registry.js) 0.20KB 0.18KB
types (reports.js) 0.20KB 0.18KB
types (spec-report.js) 5.04KB 1.93KB
types (system-fields.js) 2.39KB 1.17KB
types (theme.js) 0.20KB 0.18KB
types (ui-action.js) 1.08KB 0.64KB
types (views.js) 0.20KB 0.18KB
types (widget.js) 0.20KB 0.18KB

Size Limits

  • ✅ Core packages should be < 50KB gzipped
  • ✅ Component packages should be < 100KB gzipped
  • ⚠️ Plugin packages should be < 150KB gzipped

@os-zhuang
os-zhuang marked this pull request as ready for review July 30, 2026 13:12
@os-zhuang
os-zhuang merged commit 9a04d25 into main Jul 30, 2026
16 checks passed
@os-zhuang
os-zhuang deleted the claude/react-lazy-block-scope-bpvef6 branch July 30, 2026 13:13
os-zhuang added a commit that referenced this pull request Jul 30, 2026
…he public contract (#3069)

The AI-authoring vocabulary and the Studio page designer disagreed by thirteen
blocks: PUBLIC_BLOCKS carried one page: tag and one element: tag while the
designer palette — and @objectstack/spec's page schema — offered the whole
families. A block a human can drag in Studio was invisible to a model writing
the same page, which is the #3006 state at 10x the scale.

Fifteen tags join the contract (42 -> 57), every one shipping a renderer with
declared inputs (#3065):

  page:     tabs, card, accordion, section, footer, sidebar
  element:  text, number, button, definition-list, repeater
  action:   button, group, menu, icon

Five stay out, each with its reason recorded and guarded: action:bar
(record:quick_actions covers the record action strip; the spec blesses the
other four), element:image (duplicates the curated `image` — one spelling per
concept), and element:record_picker / element:text_input /
element:metadata_viewer (mirroring the Studio palette's own PALETTE_EXCLUSIONS,
so the two vocabularies stay out for the same reasons rather than by
coincidence).

The console's reverse-coverage guard now sweeps all four semantic namespaces
instead of record: alone — checking only the namespace you just fixed is
exactly how the last 22 doubled keys went unnoticed (#3037). A new prop-less
allowlist (element:divider, page:section, page:footer, page:sidebar) keeps
"declares no inputs" a pinned decision in both directions: those four must
stay at zero, everything else curated must declare a surface.

Verified by mutation: dropping action:menu from the list fails the sweep with
exactly that tag named.


Claude-Session: https://claude.ai/code/session_01N4mrr1ihhwnfEHFSWmGoMp

Co-authored-by: Claude <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants