fix(plugin-form,i18n): form edit saves send If-Match and surface 409 conflicts instead of silently overwriting by baozhoutao · Pull Request #3060 · objectstack-ai/objectui

baozhoutao · 2026-07-30T14:58:58Z

问题

console 编辑表单保存不带条件请求头:两个基于同一版本的并发编辑双双 200,后写静默覆盖先写(EHR 真机复测 021)。服务端早已支持 If-Match → 409 CONCURRENT_UPDATE,DataSource 契约也有 opts.ifMatch,唯独表单这一环没接——行内编辑(InlineEditSaveBar)接了,经典编辑表单没有。

修复

新增共享 useOccSave(packages/plugin-form/src/occSave.tsx):编辑保存带 ifMatch = 表单 findOne 读到的 updated_at;409 弹冲突对话框——继续编辑(不写入,表单和草稿保留)或覆盖保存(以 409 返回的 currentVersion 重试)。
6 个表单变体(ObjectForm / ModalForm / DrawerForm / TabbedForm / SplitForm / WizardForm)原来各自裸调 dataSource.update,全部接入。
无 updated_at(旧后端/无时间戳对象)自动降级为原无守护写入;非冲突错误走原错误路径。
冲突对话框与 Modal/Drawer 的 discard guard 同样嵌在 Radix 层内,保证弹层可点击。
文案补齐全部 10 个语言包(form.conflict*)。

测试

新增 occSave.test.tsx 8 例:ifMatch 传递、无版本降级、继续编辑不二次写入且草稿保留、覆盖用新版本号重试、非冲突错误正常抛出、Modal 冲突后不关闭。
plugin-form + i18n 全量 44 文件 / 419 测试通过;两包构建通过。

🤖 Generated with Claude Code

vercel · 2026-07-30T14:59:04Z

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment

Project	Deployment	Actions	Updated (UTC)
objectui	Ignored		Jul 30, 2026 2:59pm

github-actions · 2026-07-30T15:02:35Z

✅ Console Performance Budget

Metric	Value	Budget
Main entry (gzip)	27.9 KB	350 KB
Entry file	`index-B3BAIMeL.js`	—
Status	PASS	—

📦 Bundle Size Report

Package	Size	Gzipped
app-shell (index.js)	8.20KB	2.97KB
app-shell (runtime-config.js)	7.42KB	2.32KB
app-shell (types.js)	0.01KB	0.04KB
app-shell (urlParams.js)	7.57KB	2.97KB
auth (AuthContext.js)	0.31KB	0.24KB
auth (AuthGuard.js)	1.17KB	0.53KB
auth (AuthProvider.js)	22.10KB	4.37KB
auth (AuthShell.js)	3.49KB	1.40KB
auth (ForgotPasswordForm.js)	12.12KB	3.41KB
auth (LoginForm.js)	17.86KB	5.29KB
auth (PreviewBanner.js)	0.90KB	0.50KB
auth (RegisterForm.js)	6.43KB	2.09KB
auth (SocialSignInButtons.js)	9.60KB	3.89KB
auth (UserMenu.js)	3.40KB	1.22KB
auth (auth-gate-events.js)	1.29KB	0.66KB
auth (authStyles.js)	5.04KB	1.72KB
auth (createAuthClient.js)	35.76KB	9.11KB
auth (createAuthenticatedFetch.js)	4.37KB	1.69KB
auth (index.js)	2.35KB	1.07KB
auth (org-roles.js)	6.66KB	2.78KB
auth (phone-identifier.js)	1.11KB	0.66KB
auth (types.js)	0.59KB	0.35KB
auth (useAuth.js)	4.91KB	0.87KB
auth (useIsWorkspaceAdmin.js)	1.61KB	0.85KB
collaboration (CommentThread.js)	18.38KB	4.49KB
collaboration (LiveCursors.js)	3.17KB	1.27KB
collaboration (PresenceAvatars.js)	3.65KB	1.42KB
collaboration (PresenceProvider.js)	2.79KB	1.13KB
collaboration (index.js)	1.25KB	0.53KB
collaboration (useCommentSearch.js)	1.98KB	0.88KB
collaboration (useConflictResolution.js)	7.75KB	1.86KB
collaboration (useMentionNotifications.js)	1.81KB	0.68KB
collaboration (usePresence.js)	6.33KB	1.84KB
collaboration (useRealtimeSubscription.js)	7.91KB	2.01KB
components (index.js)	458.88KB	100.29KB
core (index.js)	2.16KB	0.78KB
create-plugin (index.js)	9.28KB	2.98KB
data-objectstack (index.js)	134.67KB	34.24KB
fields (index.js)	222.07KB	54.35KB
i18n (LocalizationContext.js)	1.76KB	0.96KB
i18n (currency.js)	1.22KB	0.64KB
i18n (i18n.js)	4.32KB	1.77KB
i18n (index.js)	2.46KB	0.96KB
i18n (pickLocalized.js)	1.70KB	0.83KB
i18n (provider.js)	5.37KB	1.72KB
i18n (useObjectLabel.js)	25.17KB	5.80KB
i18n (useSafeTranslation.js)	3.26KB	1.44KB
layout (index.js)	38.45KB	10.67KB
mobile (MobileProvider.js)	0.92KB	0.49KB
mobile (ResponsiveContainer.js)	0.94KB	0.38KB
mobile (breakpoints.js)	1.51KB	0.70KB
mobile (createOfflineDataSource.js)	5.61KB	1.74KB
mobile (index.js)	1.50KB	0.62KB
mobile (offlineQueue.js)	3.91KB	1.35KB
mobile (pwa.js)	0.97KB	0.49KB
mobile (serviceWorker.js)	1.48KB	0.62KB
mobile (serviceWorkerSource.js)	3.41KB	1.48KB
mobile (useBreakpoint.js)	1.54KB	0.65KB
mobile (useGesture.js)	6.96KB	1.98KB
mobile (useOfflineSync.js)	1.99KB	0.72KB
mobile (usePullToRefresh.js)	2.53KB	0.85KB
mobile (useResponsive.js)	0.71KB	0.42KB
mobile (useResponsiveConfig.js)	1.36KB	0.63KB
mobile (useSpecGesture.js)	4.05KB	1.53KB
mobile (useTouchTarget.js)	1.01KB	0.54KB
permissions (MePermissionsProvider.js)	8.76KB	3.06KB
permissions (PermissionContext.js)	0.31KB	0.25KB
permissions (PermissionGuard.js)	0.89KB	0.45KB
permissions (PermissionProvider.js)	3.67KB	1.12KB
permissions (evaluator.js)	4.41KB	1.44KB
permissions (index.js)	0.91KB	0.41KB
permissions (retry.js)	3.48KB	1.61KB
permissions (store.js)	0.91KB	0.42KB
permissions (useFieldPermissions.js)	1.28KB	0.52KB
permissions (usePermissions.js)	1.55KB	0.71KB
plugin-ai (index.js)	15.71KB	3.79KB
plugin-calendar (index.js)	44.90KB	12.35KB
plugin-charts (index.js)	60.52KB	17.11KB
plugin-chatbot (index.js)	180.09KB	42.72KB
plugin-dashboard (index.js)	111.59KB	28.74KB
plugin-designer (index.js)	210.51KB	42.50KB
plugin-detail (index.js)	221.81KB	54.28KB
plugin-editor (index.js)	2.46KB	1.10KB
plugin-form (index.js)	110.71KB	26.67KB
plugin-gantt (index.js)	162.26KB	39.53KB
plugin-grid (index.js)	183.80KB	48.21KB
plugin-kanban (index.js)	47.82KB	13.18KB
plugin-list (index.js)	102.39KB	24.18KB
plugin-map (index.js)	16.80KB	5.24KB
plugin-markdown (index.js)	13.65KB	4.67KB
plugin-report (index.js)	40.32KB	10.53KB
plugin-timeline (index.js)	25.75KB	7.32KB
plugin-tree (index.js)	8.36KB	2.81KB
plugin-view (index.js)	85.95KB	21.02KB
providers (DataSourceProvider.js)	0.75KB	0.39KB
providers (MetadataProvider.js)	1.37KB	0.59KB
providers (ThemeProvider.js)	1.90KB	0.85KB
providers (UploadProvider.js)	11.71KB	3.53KB
providers (index.js)	0.44KB	0.22KB
providers (types.js)	0.01KB	0.04KB
react-runtime (index.js)	5.67KB	2.37KB
react (LazyPluginLoader.js)	3.77KB	1.33KB
react (SchemaRenderer.js)	19.28KB	6.38KB
react (data-invalidation.js)	5.05KB	2.08KB
react (index.js)	1.02KB	0.55KB
sdui-parser (codegen.js)	4.09KB	1.74KB
sdui-parser (index.js)	3.47KB	1.54KB
sdui-parser (parse.js)	10.04KB	2.82KB
sdui-parser (types.js)	0.29KB	0.24KB
sdui-parser (validate.js)	4.69KB	1.48KB
types (ai.js)	0.20KB	0.17KB
types (api-types.js)	0.20KB	0.18KB
types (app.js)	2.87KB	0.99KB
types (base.js)	0.20KB	0.18KB
types (blocks.js)	0.20KB	0.18KB
types (complex.js)	0.20KB	0.18KB
types (crud.js)	0.20KB	0.18KB
types (data-display.js)	0.20KB	0.18KB
types (data-protocol.js)	0.20KB	0.19KB
types (data.js)	0.20KB	0.18KB
types (designer.js)	1.87KB	0.85KB
types (disclosure.js)	0.20KB	0.18KB
types (error-code.js)	1.54KB	0.88KB
types (feedback.js)	0.20KB	0.18KB
types (field-types.js)	0.20KB	0.18KB
types (form.js)	0.20KB	0.18KB
types (index.js)	2.07KB	0.99KB
types (layout.js)	0.20KB	0.18KB
types (managed-by.js)	0.19KB	0.18KB
types (mobile.js)	0.20KB	0.18KB
types (navigation.js)	0.20KB	0.18KB
types (objectql.js)	0.20KB	0.18KB
types (overlay.js)	0.20KB	0.18KB
types (permissions.js)	0.20KB	0.18KB
types (plugin-scope.js)	0.20KB	0.18KB
types (record-components.js)	0.20KB	0.19KB
types (record-semantics.js)	1.28KB	0.67KB
types (registry.js)	0.20KB	0.18KB
types (reports.js)	0.20KB	0.18KB
types (spec-report.js)	5.04KB	1.93KB
types (system-fields.js)	3.33KB	1.54KB
types (theme.js)	0.20KB	0.18KB
types (ui-action.js)	1.08KB	0.64KB
types (views.js)	0.20KB	0.18KB
types (widget.js)	0.20KB	0.18KB

Size Limits

✅ Core packages should be < 50KB gzipped
✅ Component packages should be < 100KB gzipped
⚠️ Plugin packages should be < 150KB gzipped

…conflicts instead of silently overwriting Every form variant (ObjectForm/ModalForm/DrawerForm/TabbedForm/SplitForm/ WizardForm) wrote records back with an unguarded dataSource.update — two racing editors both got a 200 and the later save silently erased the earlier one. The server already honours If-Match (409 CONCURRENT_UPDATE) and the DataSource contract forwards opts.ifMatch; the forms were the only link not sending it. New shared useOccSave (occSave.tsx): the edit save carries ifMatch = the updated_at the form read via findOne; a 409 opens a conflict dialog whose exits are "Keep editing" (nothing written, form and draft stay open) and "Overwrite" (retry re-keyed to the server's currentVersion). Records without a string updated_at degrade to the old unguarded write. Dialog copy added to all ten locales under form.conflict*. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

github-actions Bot added plugin tests labels Jul 30, 2026

baozhoutao merged commit 6e6f5ef into main Jul 30, 2026
16 checks passed

baozhoutao deleted the fix/form-edit-occ-ifmatch branch July 30, 2026 15:06

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fix(plugin-form,i18n): form edit saves send If-Match and surface 409 conflicts instead of silently overwriting - #3060

fix(plugin-form,i18n): form edit saves send If-Match and surface 409 conflicts instead of silently overwriting#3060
baozhoutao merged 1 commit into
mainfrom
fix/form-edit-occ-ifmatch

baozhoutao commented Jul 30, 2026

Uh oh!

vercel Bot commented Jul 30, 2026

Uh oh!

github-actions Bot commented Jul 30, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Uh oh!

Conversation

baozhoutao commented Jul 30, 2026

问题

修复

测试

Uh oh!

vercel Bot commented Jul 30, 2026

Uh oh!

github-actions Bot commented Jul 30, 2026

✅ Console Performance Budget

📦 Bundle Size Report

Size Limits

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant