feat(page,element): declare inputs for the eight configurable page:*/element:* blocks - #3065
Merged
Merged
Conversation
…element:* blocks Same gap #3027 closed for record:*, in the two namespaces next door: renderers that read real props while every authoring surface reported "takes no configuration". Declarations mirror what each renderer reads — page:tabs items, tabStyle (line/card/pill), position (top/left) page:card title, bordered, body (slot), footer (slot) page:accordion items, allowMultiple, variant (flush/card) element:text content, variant, align element:number object, aggregate, field, filter, format, prefix, suffix element:button label, action (inline ActionDef), variant, size, icon, iconPosition, disabled element:definition-list items, columns, inline element:repeater object, titleField, fields, filter, sort, limit, emptyText, divided page:section, page:footer and page:sidebar stay at zero inputs on purpose: their renderers render children/body and nothing else — like element:divider, they are genuinely prop-less containers, and inventing inputs for them would be the opposite falsehood. aria and className stay undeclared throughout, per the convention on record:details: escape hatches and styling pass-throughs, not authoring choices. element:button's registration also documents the split against action:button — inline ActionDef vs a declared action referenced by name — so the two stop reading as duplicates. Declaration only; no renderer behavior changes. Curation (which of these join PUBLIC_BLOCKS) is a separate change. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01N4mrr1ihhwnfEHFSWmGoMp
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
Contributor
✅ Console Performance Budget
📦 Bundle Size Report
Size Limits
|
os-zhuang
marked this pull request as ready for review
July 30, 2026 15:20
os-zhuang
added a commit
that referenced
this pull request
Jul 30, 2026
…he public contract (#3069) The AI-authoring vocabulary and the Studio page designer disagreed by thirteen blocks: PUBLIC_BLOCKS carried one page: tag and one element: tag while the designer palette — and @objectstack/spec's page schema — offered the whole families. A block a human can drag in Studio was invisible to a model writing the same page, which is the #3006 state at 10x the scale. Fifteen tags join the contract (42 -> 57), every one shipping a renderer with declared inputs (#3065): page: tabs, card, accordion, section, footer, sidebar element: text, number, button, definition-list, repeater action: button, group, menu, icon Five stay out, each with its reason recorded and guarded: action:bar (record:quick_actions covers the record action strip; the spec blesses the other four), element:image (duplicates the curated `image` — one spelling per concept), and element:record_picker / element:text_input / element:metadata_viewer (mirroring the Studio palette's own PALETTE_EXCLUSIONS, so the two vocabularies stay out for the same reasons rather than by coincidence). The console's reverse-coverage guard now sweeps all four semantic namespaces instead of record: alone — checking only the namespace you just fixed is exactly how the last 22 doubled keys went unnoticed (#3037). A new prop-less allowlist (element:divider, page:section, page:footer, page:sidebar) keeps "declares no inputs" a pinned decision in both directions: those four must stay at zero, everything else curated must declare a surface. Verified by mutation: dropping action:menu from the list fails the sweep with exactly that tag named. Claude-Session: https://claude.ai/code/session_01N4mrr1ihhwnfEHFSWmGoMp Co-authored-by: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part 1 of 2 (per the evaluation on this thread's session): pure declaration, no behavior change. Part 2 — expanding
PUBLIC_BLOCKSand generalizing the console's reverse-coverage guard — lands separately so the vocabulary decision stays independently revertable.Same gap #3027 closed for
record:*, in the two namespaces next door: renderers reading real props while every authoring surface (designer panel, generated manifest, contract) reported "takes no configuration". Every declaration below mirrors what the renderer actually reads — none are invented:page:tabsvalue/icon/count/visibleWhen), tabStyleline|card|pill, positiontop|leftpage:cardpage:accordioncollapsed), allowMultiple, variantflush|cardelement:textheading|subheading|body|caption, alignelement:numbercount|sum|avg|min|max, field, filter, format, prefix, suffixelement:buttonelement:definition-list{term, description}, columns, inlineelement:repeaterDeliberately left at zero
page:section,page:footer,page:sidebar— their renderers renderchildren/bodyand nothing else. Likeelement:divider, they are genuinely prop-less containers; inventing inputs for them would be the opposite falsehood from the one this fixes. (Part 2's guard will carry an explicit prop-less allowlist so this stays a decision, not an oversight.)aria/classNamestay undeclared throughout, per therecord:detailsconvention — escape hatches and styling pass-throughs, not authoring choices.One doc note in code
element:buttonvsaction:buttonread as duplicates from the outside; they aren't — inline ActionDef vs a declared action referenced by name (with visible/enabled predicates). The registration now says so, since that distinction decides which one an author (or model) should reach for.Verified via registry probe: all eight report their declared surface; the three containers and
element:dividerstay at zero. Full suite746 passed | 1 skipped, lint 0 errors, type-check 9/9, changeset included.🤖 Generated with Claude Code
https://claude.ai/code/session_01N4mrr1ihhwnfEHFSWmGoMp
Generated by Claude Code