Skip to content

feat(app-shell): the console mounts the notification surfaces (#3014 follow-up) - #3075

Merged
os-zhuang merged 1 commit into
mainfrom
claude/console-notification-surfaces
Jul 30, 2026
Merged

feat(app-shell): the console mounts the notification surfaces (#3014 follow-up)#3075
os-zhuang merged 1 commit into
mainfrom
claude/console-notification-surfaces

Conversation

@os-zhuang

Copy link
Copy Markdown
Contributor

Follow-up to #3071 (which closed #3014). That PR gave each spec NotificationTypeSchema member its own presentation, but no host mounted NotificationProvider — the capability existed and the console could not reach it. This wires it in.

What the console mounts now

displayType Surface Mounted by
toast sonner, via the new presentNotificationToast ConsoleShell
snackbar <NotificationSnackbar /> ConsoleShell
alert <NotificationAlerts /> ConsoleShell
banner <NotificationBanners /> ConsoleLayout, beside the draft / unpublished bars
inline <NotificationInline scope="…" /> the raising surface — not mounted globally

inline is left out on purpose: rendering in place at the raiser is the whole difference between it and a banner, so a global inline outlet would collapse the two again. ConsoleShell's header documents the split so the next person doesn't "fix" it.

Two pieces worth reviewing

presentNotificationToast — the single place a notification becomes a sonner call, so the mapping is one testable function instead of a lambda in the shell:

  • severity → sonner variant, in a Record<NotificationSeverityLevel, …> so a new spec severity fails type-check rather than silently rendering neutral;
  • duration: 0Infinity. The contract's "persistent" passed through raw would make the toast vanish on the next tick;
  • an absent duration is left undefined so ConsoleToaster's 4s default applies, rather than reinventing a number here;
  • actions[0] → sonner's one action slot (a notification needing more belongs on a banner or an alert).

ConsoleNotificationBannersNotificationBanners gated on useHasNotificationProvider(). ConsoleShell is deliberately a set of composable pieces a host assembles in its own App.tsx, so ConsoleLayout can legitimately render without the provider above it — and useNotifications() throws there, which would white-screen the whole app instead of simply showing no banners.

Both are exported for hand-assembled shells. The provider's defaultDuration matches ConsoleToaster's 4s, so a snackbar and a toast raised together disappear together.

Verification

In the running console (apps/console dev server, login route — which renders inside ConsoleShell): a toast, a snackbar with an Undo action, and a blocking alert dialog on screen at once, visibly distinct — the exact collapse #3014 was about, gone. Raising an inline with no outlet logs the dev warning naming the component to mount, and exactly once per notify() (measured, not assumed). No console errors on boot with the new root provider.

The banner placement is covered by tests rather than a screenshot: it lives in ConsoleLayout, which is behind auth, and standing up a backend for one strip was disproportionate — ConsoleShell.notifications.test.tsx renders ConsoleNotificationBanners inside the real ConsoleShell and asserts it lands on data-notification-surface="banner" while sonner is never called.

Suites:

  • packages/app-shell: 2047 tests, 247 files, all green (includes the 15 new ones — 7 shell integration + 8 toast-mapping).
  • tsc --noEmit clean on @object-ui/app-shell; eslint 0 errors on every touched file.

Docs: the notifications guide gains an "In the console" section, plus the @object-ui/app-shell README.

Refs #3014, #2942.

🤖 Generated with Claude Code

…follow-up)

#3071 gave each spec `NotificationTypeSchema` member its own presentation, but
no host mounted `NotificationProvider` — the capability existed and the console
could not reach it.

`ConsoleShell` now mounts the provider plus the surfaces with a single global
home; `ConsoleLayout` mounts the one that belongs in the content area:

  toast     -> sonner, via the new `presentNotificationToast`   (ConsoleShell)
  snackbar  -> <NotificationSnackbar />                         (ConsoleShell)
  alert     -> <NotificationAlerts />                           (ConsoleShell)
  banner    -> <NotificationBanners />, beside the draft /
               unpublished bars                                 (ConsoleLayout)
  inline    -> the raising surface's own <NotificationInline />; deliberately
               NOT mounted globally, since rendering in place at the raiser is
               the whole difference between it and a banner

`presentNotificationToast` is the single place a notification becomes a sonner
call: severity -> variant, `duration: 0` -> `Infinity` (the contract's
"persistent", which passed through raw would make the toast vanish on the next
tick), first action -> sonner's one action slot, an absent duration left to the
ConsoleToaster default. Its severity table is
`Record<NotificationSeverityLevel, …>`, so a new spec severity fails type-check
instead of silently rendering neutral.

The banners go through `ConsoleNotificationBanners`, gated on
`useHasNotificationProvider()`: `ConsoleShell` is deliberately composable
pieces a host assembles itself, so `ConsoleLayout` can render without the
provider above it — and `useNotifications()` throws there, white-screening the
app instead of simply showing no banners. Both pieces are exported for
hand-assembled shells.

Verified in the running console (login route): a toast, a snackbar with an
Undo action, and a blocking alert dialog on screen at once, visibly distinct;
raising an `inline` with no outlet logs the dev warning naming the component to
mount, once per notify().

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
@vercel

vercel Bot commented Jul 30, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated (UTC)
objectui Ignored Ignored Jul 30, 2026 4:13pm

Request Review

@github-actions github-actions Bot added documentation Improvements or additions to documentation tests labels Jul 30, 2026
@github-actions

Copy link
Copy Markdown
Contributor

✅ Console Performance Budget

Metric Value Budget
Main entry (gzip) 27.9 KB 350 KB
Entry file index-CS4c21HA.js
Status PASS

📦 Bundle Size Report

Package Size Gzipped
app-shell (index.js) 8.26KB 2.99KB
app-shell (runtime-config.js) 7.42KB 2.32KB
app-shell (types.js) 0.01KB 0.04KB
app-shell (urlParams.js) 7.57KB 2.97KB
auth (AuthContext.js) 0.31KB 0.24KB
auth (AuthGuard.js) 1.17KB 0.53KB
auth (AuthProvider.js) 22.10KB 4.37KB
auth (AuthShell.js) 3.49KB 1.40KB
auth (ForgotPasswordForm.js) 12.12KB 3.41KB
auth (LoginForm.js) 17.86KB 5.29KB
auth (PreviewBanner.js) 0.90KB 0.50KB
auth (RegisterForm.js) 6.43KB 2.09KB
auth (SocialSignInButtons.js) 9.60KB 3.89KB
auth (UserMenu.js) 3.40KB 1.22KB
auth (auth-gate-events.js) 1.29KB 0.66KB
auth (authStyles.js) 5.04KB 1.72KB
auth (createAuthClient.js) 35.76KB 9.11KB
auth (createAuthenticatedFetch.js) 4.37KB 1.69KB
auth (index.js) 2.35KB 1.07KB
auth (org-roles.js) 6.66KB 2.78KB
auth (phone-identifier.js) 1.11KB 0.66KB
auth (types.js) 0.59KB 0.35KB
auth (useAuth.js) 4.91KB 0.87KB
auth (useIsWorkspaceAdmin.js) 1.61KB 0.85KB
collaboration (CommentThread.js) 18.38KB 4.49KB
collaboration (LiveCursors.js) 3.17KB 1.27KB
collaboration (PresenceAvatars.js) 3.65KB 1.42KB
collaboration (PresenceProvider.js) 2.79KB 1.13KB
collaboration (index.js) 1.25KB 0.53KB
collaboration (useCommentSearch.js) 1.98KB 0.88KB
collaboration (useConflictResolution.js) 7.75KB 1.86KB
collaboration (useMentionNotifications.js) 1.81KB 0.68KB
collaboration (usePresence.js) 6.33KB 1.84KB
collaboration (useRealtimeSubscription.js) 7.91KB 2.01KB
components (index.js) 471.08KB 102.76KB
core (index.js) 2.16KB 0.78KB
create-plugin (index.js) 9.28KB 2.98KB
data-objectstack (index.js) 135.63KB 34.47KB
fields (index.js) 222.07KB 54.35KB
i18n (LocalizationContext.js) 1.76KB 0.96KB
i18n (currency.js) 1.22KB 0.64KB
i18n (i18n.js) 4.32KB 1.77KB
i18n (index.js) 2.46KB 0.96KB
i18n (pickLocalized.js) 1.70KB 0.83KB
i18n (provider.js) 5.37KB 1.72KB
i18n (useObjectLabel.js) 25.17KB 5.80KB
i18n (useSafeTranslation.js) 3.26KB 1.44KB
layout (index.js) 38.45KB 10.67KB
mobile (MobileProvider.js) 0.92KB 0.49KB
mobile (ResponsiveContainer.js) 0.94KB 0.38KB
mobile (breakpoints.js) 1.51KB 0.70KB
mobile (createOfflineDataSource.js) 5.61KB 1.74KB
mobile (index.js) 1.50KB 0.62KB
mobile (offlineQueue.js) 3.91KB 1.35KB
mobile (pwa.js) 0.97KB 0.49KB
mobile (serviceWorker.js) 1.48KB 0.62KB
mobile (serviceWorkerSource.js) 3.41KB 1.48KB
mobile (useBreakpoint.js) 1.54KB 0.65KB
mobile (useGesture.js) 6.96KB 1.98KB
mobile (useOfflineSync.js) 1.99KB 0.72KB
mobile (usePullToRefresh.js) 2.53KB 0.85KB
mobile (useResponsive.js) 0.71KB 0.42KB
mobile (useResponsiveConfig.js) 1.36KB 0.63KB
mobile (useSpecGesture.js) 4.05KB 1.53KB
mobile (useTouchTarget.js) 1.01KB 0.54KB
permissions (MePermissionsProvider.js) 8.76KB 3.06KB
permissions (PermissionContext.js) 0.31KB 0.25KB
permissions (PermissionGuard.js) 0.89KB 0.45KB
permissions (PermissionProvider.js) 3.67KB 1.12KB
permissions (evaluator.js) 4.41KB 1.44KB
permissions (index.js) 0.91KB 0.41KB
permissions (retry.js) 3.48KB 1.61KB
permissions (store.js) 0.91KB 0.42KB
permissions (useFieldPermissions.js) 1.28KB 0.52KB
permissions (usePermissions.js) 1.55KB 0.71KB
plugin-ai (index.js) 15.71KB 3.79KB
plugin-calendar (index.js) 44.90KB 12.35KB
plugin-charts (index.js) 60.52KB 17.11KB
plugin-chatbot (index.js) 180.09KB 42.72KB
plugin-dashboard (index.js) 111.59KB 28.74KB
plugin-designer (index.js) 210.51KB 42.50KB
plugin-detail (index.js) 221.81KB 54.28KB
plugin-editor (index.js) 2.46KB 1.10KB
plugin-form (index.js) 110.71KB 26.67KB
plugin-gantt (index.js) 162.26KB 39.53KB
plugin-grid (index.js) 184.77KB 48.50KB
plugin-kanban (index.js) 47.82KB 13.18KB
plugin-list (index.js) 104.07KB 24.88KB
plugin-map (index.js) 16.80KB 5.24KB
plugin-markdown (index.js) 13.65KB 4.67KB
plugin-report (index.js) 40.32KB 10.53KB
plugin-timeline (index.js) 25.75KB 7.32KB
plugin-tree (index.js) 8.36KB 2.81KB
plugin-view (index.js) 85.95KB 21.02KB
providers (DataSourceProvider.js) 0.75KB 0.39KB
providers (MetadataProvider.js) 1.37KB 0.59KB
providers (ThemeProvider.js) 1.90KB 0.85KB
providers (UploadProvider.js) 11.71KB 3.53KB
providers (index.js) 0.44KB 0.22KB
providers (types.js) 0.01KB 0.04KB
react-runtime (index.js) 5.67KB 2.37KB
react (LazyPluginLoader.js) 3.77KB 1.33KB
react (SchemaRenderer.js) 19.28KB 6.38KB
react (data-invalidation.js) 5.05KB 2.08KB
react (index.js) 1.02KB 0.55KB
sdui-parser (codegen.js) 4.09KB 1.74KB
sdui-parser (index.js) 3.47KB 1.54KB
sdui-parser (parse.js) 10.04KB 2.82KB
sdui-parser (types.js) 0.29KB 0.24KB
sdui-parser (validate.js) 4.69KB 1.48KB
types (ai.js) 0.20KB 0.17KB
types (api-types.js) 0.20KB 0.18KB
types (app.js) 2.87KB 0.99KB
types (base.js) 0.20KB 0.18KB
types (blocks.js) 0.20KB 0.18KB
types (complex.js) 0.20KB 0.18KB
types (crud.js) 0.20KB 0.18KB
types (data-display.js) 0.20KB 0.18KB
types (data-protocol.js) 0.20KB 0.19KB
types (data.js) 0.20KB 0.18KB
types (designer.js) 1.87KB 0.85KB
types (disclosure.js) 0.20KB 0.18KB
types (error-code.js) 1.54KB 0.88KB
types (feedback.js) 0.20KB 0.18KB
types (field-types.js) 0.20KB 0.18KB
types (form.js) 0.20KB 0.18KB
types (index.js) 2.07KB 0.99KB
types (layout.js) 0.20KB 0.18KB
types (managed-by.js) 0.19KB 0.18KB
types (mobile.js) 0.20KB 0.18KB
types (navigation.js) 0.20KB 0.18KB
types (objectql.js) 0.20KB 0.18KB
types (overlay.js) 0.20KB 0.18KB
types (permissions.js) 0.20KB 0.18KB
types (plugin-scope.js) 0.20KB 0.18KB
types (record-components.js) 0.20KB 0.19KB
types (record-semantics.js) 1.28KB 0.67KB
types (registry.js) 0.20KB 0.18KB
types (reports.js) 0.20KB 0.18KB
types (spec-report.js) 5.05KB 1.93KB
types (system-fields.js) 3.33KB 1.54KB
types (theme.js) 0.20KB 0.18KB
types (ui-action.js) 1.08KB 0.64KB
types (views.js) 0.20KB 0.18KB
types (widget.js) 0.20KB 0.18KB

Size Limits

  • ✅ Core packages should be < 50KB gzipped
  • ✅ Component packages should be < 100KB gzipped
  • ⚠️ Plugin packages should be < 150KB gzipped

@os-zhuang
os-zhuang merged commit 2bb1809 into main Jul 30, 2026
16 checks passed
@os-zhuang
os-zhuang deleted the claude/console-notification-surfaces branch July 30, 2026 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Notification displayType is honored in the contract but every type still presents as a toast

1 participant