fix(app-shell): lookup-param helpText only renders when the param actually degraded to a raw-id input (#3094) by baozhoutao · Pull Request #3095 · objectstack-ai/objectui

baozhoutao · 2026-07-31T05:28:23Z

问题

Action 参数对话框(RecordDetailView 记录头动作)里,lookup/reference 类型参数无条件渲染 actionDialog.lookupHelpText("该参数未配置引用对象,无法使用记录选择器。请直接填写记录 ID…")——即使 reference 已正确配置、记录选择器完全可用。用户被误导去贴裸记录 ID,而不去用旁边正常工作的选择器。

根因

ActionParamDialog.tsx 中该警告的渲染条件只有 isLookupParam && !param.helpText,从不检查参数是否真的降级。警告文案描述的降级判定在 paramToField() 里(lookup 且无 referenceTo → 降为 text 输入),但不参与该条件;同文件上方 lookupPlaceholder 分支是有 field.type === 'text' 检查的,两个分支不对称。

修复

一行改动:给 helpText 分支补上 field.type === 'text',与 placeholder 分支镜像——只有参数真降级成"贴 ID"文本框时才显示警告。

测试

ActionParamDialog.test.tsx 新增三个用例钉住三种状态:

带 referenceTo → 渲染真选择器(trigger 挂载)且无警告(本 issue 的回归用例);
无 referenceTo → 降级为 text 输入 + 显示警告;
自定义 helpText → 显示自定义文案,内置警告不出现。

该文件 31 用例全过;相邻 ActionParamDialog.uploading / paramToField / resolveActionParams 套件 28 用例全过;turbo build --filter=@object-ui/app-shell 通过。纯 bug 修复,按 AGENTS.md 无需 changeset。

🤖 Generated with Claude Code

vercel · 2026-07-31T05:28:29Z

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment

Project	Deployment	Actions	Updated (UTC)
objectui	Ignored		Jul 31, 2026 5:28am

github-actions · 2026-07-31T05:31:54Z

✅ Console Performance Budget

Metric	Value	Budget
Main entry (gzip)	27.9 KB	350 KB
Entry file	`index-Cwhw0IHY.js`	—
Status	PASS	—

📦 Bundle Size Report

Package	Size	Gzipped
app-shell (index.js)	8.26KB	2.99KB
app-shell (runtime-config.js)	7.42KB	2.32KB
app-shell (types.js)	0.01KB	0.04KB
app-shell (urlParams.js)	7.57KB	2.97KB
auth (AuthContext.js)	0.31KB	0.24KB
auth (AuthGuard.js)	1.17KB	0.53KB
auth (AuthProvider.js)	22.10KB	4.37KB
auth (AuthShell.js)	3.49KB	1.40KB
auth (ForgotPasswordForm.js)	12.12KB	3.41KB
auth (LoginForm.js)	17.86KB	5.29KB
auth (PreviewBanner.js)	0.90KB	0.50KB
auth (RegisterForm.js)	6.43KB	2.09KB
auth (SocialSignInButtons.js)	9.60KB	3.89KB
auth (UserMenu.js)	3.40KB	1.22KB
auth (auth-gate-events.js)	1.29KB	0.66KB
auth (authStyles.js)	5.04KB	1.72KB
auth (createAuthClient.js)	35.76KB	9.11KB
auth (createAuthenticatedFetch.js)	4.37KB	1.69KB
auth (index.js)	2.35KB	1.07KB
auth (org-roles.js)	6.66KB	2.78KB
auth (phone-identifier.js)	1.11KB	0.66KB
auth (types.js)	0.59KB	0.35KB
auth (useAuth.js)	4.91KB	0.87KB
auth (useIsWorkspaceAdmin.js)	1.61KB	0.85KB
collaboration (CommentThread.js)	18.38KB	4.49KB
collaboration (LiveCursors.js)	3.17KB	1.27KB
collaboration (PresenceAvatars.js)	3.65KB	1.42KB
collaboration (PresenceProvider.js)	2.79KB	1.13KB
collaboration (index.js)	1.25KB	0.53KB
collaboration (useCommentSearch.js)	1.98KB	0.88KB
collaboration (useConflictResolution.js)	7.75KB	1.86KB
collaboration (useMentionNotifications.js)	1.81KB	0.68KB
collaboration (usePresence.js)	6.33KB	1.84KB
collaboration (useRealtimeSubscription.js)	7.91KB	2.01KB
components (index.js)	473.75KB	103.77KB
core (index.js)	2.16KB	0.78KB
create-plugin (index.js)	9.28KB	2.98KB
data-objectstack (index.js)	136.34KB	34.64KB
fields (index.js)	222.07KB	54.35KB
i18n (LocalizationContext.js)	1.76KB	0.96KB
i18n (currency.js)	1.22KB	0.64KB
i18n (i18n.js)	4.32KB	1.77KB
i18n (index.js)	2.46KB	0.96KB
i18n (pickLocalized.js)	1.70KB	0.83KB
i18n (provider.js)	5.37KB	1.72KB
i18n (useObjectLabel.js)	25.17KB	5.80KB
i18n (useSafeTranslation.js)	3.26KB	1.44KB
layout (index.js)	38.44KB	10.66KB
mobile (MobileProvider.js)	0.92KB	0.49KB
mobile (ResponsiveContainer.js)	0.94KB	0.38KB
mobile (breakpoints.js)	1.51KB	0.70KB
mobile (createOfflineDataSource.js)	5.61KB	1.74KB
mobile (index.js)	1.50KB	0.62KB
mobile (offlineQueue.js)	3.91KB	1.35KB
mobile (pwa.js)	0.97KB	0.49KB
mobile (serviceWorker.js)	1.48KB	0.62KB
mobile (serviceWorkerSource.js)	3.41KB	1.48KB
mobile (useBreakpoint.js)	1.54KB	0.65KB
mobile (useGesture.js)	6.96KB	1.98KB
mobile (useOfflineSync.js)	1.99KB	0.72KB
mobile (usePullToRefresh.js)	2.53KB	0.85KB
mobile (useResponsive.js)	0.71KB	0.42KB
mobile (useResponsiveConfig.js)	1.36KB	0.63KB
mobile (useSpecGesture.js)	4.05KB	1.53KB
mobile (useTouchTarget.js)	1.01KB	0.54KB
permissions (MePermissionsProvider.js)	8.76KB	3.06KB
permissions (PermissionContext.js)	0.31KB	0.25KB
permissions (PermissionGuard.js)	0.89KB	0.45KB
permissions (PermissionProvider.js)	3.67KB	1.12KB
permissions (evaluator.js)	4.41KB	1.44KB
permissions (index.js)	0.91KB	0.41KB
permissions (retry.js)	3.48KB	1.61KB
permissions (store.js)	0.91KB	0.42KB
permissions (useFieldPermissions.js)	1.28KB	0.52KB
permissions (usePermissions.js)	1.55KB	0.71KB
plugin-ai (index.js)	15.71KB	3.79KB
plugin-calendar (index.js)	44.90KB	12.35KB
plugin-charts (index.js)	60.52KB	17.11KB
plugin-chatbot (index.js)	180.09KB	42.72KB
plugin-dashboard (index.js)	111.59KB	28.74KB
plugin-designer (index.js)	210.51KB	42.50KB
plugin-detail (index.js)	221.81KB	54.28KB
plugin-editor (index.js)	2.46KB	1.10KB
plugin-form (index.js)	111.38KB	26.93KB
plugin-gantt (index.js)	162.26KB	39.53KB
plugin-grid (index.js)	182.21KB	48.24KB
plugin-kanban (index.js)	47.82KB	13.18KB
plugin-list (index.js)	103.85KB	24.80KB
plugin-map (index.js)	16.80KB	5.24KB
plugin-markdown (index.js)	13.65KB	4.67KB
plugin-report (index.js)	40.32KB	10.53KB
plugin-timeline (index.js)	25.75KB	7.32KB
plugin-tree (index.js)	8.36KB	2.81KB
plugin-view (index.js)	83.54KB	20.39KB
providers (DataSourceProvider.js)	0.75KB	0.39KB
providers (MetadataProvider.js)	1.37KB	0.59KB
providers (ThemeProvider.js)	1.90KB	0.85KB
providers (UploadProvider.js)	11.71KB	3.53KB
providers (index.js)	0.44KB	0.22KB
providers (types.js)	0.01KB	0.04KB
react-runtime (index.js)	5.67KB	2.37KB
react (LazyPluginLoader.js)	3.77KB	1.33KB
react (SchemaRenderer.js)	19.28KB	6.38KB
react (data-invalidation.js)	5.05KB	2.08KB
react (index.js)	1.02KB	0.55KB
sdui-parser (codegen.js)	4.09KB	1.74KB
sdui-parser (index.js)	3.47KB	1.54KB
sdui-parser (parse.js)	10.04KB	2.82KB
sdui-parser (types.js)	0.29KB	0.24KB
sdui-parser (validate.js)	4.69KB	1.48KB
types (ai.js)	0.20KB	0.17KB
types (api-types.js)	0.20KB	0.18KB
types (app.js)	2.87KB	0.99KB
types (base.js)	0.20KB	0.18KB
types (blocks.js)	0.20KB	0.18KB
types (complex.js)	0.20KB	0.18KB
types (crud.js)	0.20KB	0.18KB
types (data-display.js)	0.20KB	0.18KB
types (data-protocol.js)	0.20KB	0.19KB
types (data.js)	0.20KB	0.18KB
types (designer.js)	1.87KB	0.85KB
types (disclosure.js)	0.20KB	0.18KB
types (error-code.js)	1.54KB	0.88KB
types (feedback.js)	0.20KB	0.18KB
types (field-types.js)	0.20KB	0.18KB
types (form.js)	0.20KB	0.18KB
types (index.js)	2.07KB	0.99KB
types (layout.js)	0.20KB	0.18KB
types (managed-by.js)	0.19KB	0.18KB
types (mobile.js)	0.20KB	0.18KB
types (navigation.js)	0.20KB	0.18KB
types (objectql.js)	0.20KB	0.18KB
types (overlay.js)	0.20KB	0.18KB
types (permissions.js)	0.20KB	0.18KB
types (plugin-scope.js)	0.20KB	0.18KB
types (record-components.js)	0.20KB	0.19KB
types (record-semantics.js)	1.28KB	0.67KB
types (registry.js)	0.20KB	0.18KB
types (reports.js)	0.20KB	0.18KB
types (spec-report.js)	5.05KB	1.93KB
types (system-fields.js)	3.33KB	1.54KB
types (theme.js)	0.20KB	0.18KB
types (ui-action.js)	1.08KB	0.64KB
types (views.js)	0.20KB	0.18KB
types (widget.js)	0.20KB	0.18KB

Size Limits

✅ Core packages should be < 50KB gzipped
✅ Component packages should be < 100KB gzipped
⚠️ Plugin packages should be < 150KB gzipped

…ually degraded to a raw-id input (#3094) The action params dialog rendered `actionDialog.lookupHelpText` ("no reference object configured, picker unavailable, paste a record id") for EVERY lookup/reference param without a custom helpText — even when `reference` was configured and the record picker worked. The condition only checked "is a lookup param"; the degradation it describes lives in paramToField() (lookup + no referenceTo → text input) and was never consulted. Gate the message on `field.type === 'text'`, mirroring the adjacent lookupPlaceholder branch that already checks it. Tests pin all three states: working picker → no warning; targetless param → text input + warning; custom helpText → custom text wins. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

github-actions Bot added the tests label Jul 31, 2026

os-zhuang merged commit 0947b3c into main Jul 31, 2026
16 checks passed

os-zhuang deleted the claude/issue-3094-review-42fd3e branch July 31, 2026 07:24

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fix(app-shell): lookup-param helpText only renders when the param actually degraded to a raw-id input (#3094) - #3095

fix(app-shell): lookup-param helpText only renders when the param actually degraded to a raw-id input (#3094)#3095
os-zhuang merged 1 commit into
mainfrom
claude/issue-3094-review-42fd3e

baozhoutao commented Jul 31, 2026

Uh oh!

vercel Bot commented Jul 31, 2026

Uh oh!

github-actions Bot commented Jul 31, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

baozhoutao commented Jul 31, 2026

问题

根因

修复

测试

Uh oh!

vercel Bot commented Jul 31, 2026

Uh oh!

github-actions Bot commented Jul 31, 2026

✅ Console Performance Budget

📦 Bundle Size Report

Size Limits

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants