Skip to content

fix(console): LocalizationFetchProvider 重试瞬时失败 —— 一次冷环境 503 不该让区域设置整个会话失效 - #3098

Merged
os-zhuang merged 1 commit into
mainfrom
claude/vercel-startup-permissions-provider-iwtkqm
Jul 31, 2026
Merged

fix(console): LocalizationFetchProvider 重试瞬时失败 —— 一次冷环境 503 不该让区域设置整个会话失效#3098
os-zhuang merged 1 commit into
mainfrom
claude/vercel-startup-permissions-provider-iwtkqm

Conversation

@os-zhuang

Copy link
Copy Markdown
Contributor

objectstack#4159 之后,/auth/me/localization拥有该会话的环境 kernel 应答,冷 kernel 会返回 503 + Retry-After。也就是说:在多租户宿主上,瞬时失败是冷启动的常规组成部分,不是异常。

而这个 provider 只尝试一次就 .catch() 静默。一次 503 会让货币与区域设置整个会话失效 —— 每个金额字段渲染成裸数字,且永远不会再试,哪怕 kernel 早已就绪。静默且永久,所以没人会把它当 bug 报上来。

一处我要说明的判断变更

objectui#3052 时我看过这个文件,判定为「cosmetic、可优雅降级、无需改动」。那个判断在当时是对的,之后就错了 —— #4159 把 503 从异常变成了这条端点的常规答案,而那个判断没有被重新检视。

真正让它浮出来的是不对称:同一个宿主、同一个 provenance、同一个 503,两个 provider 处理方式相反。

修法:原语共享,策略不共享

重试原语(什么算瞬时、等多久、Retry-After 解析)从 @object-ui/permissions 的内部模块移到 @object-ui/types(两个调用方都能到达的最底层包),PermissionsFetchError → 通用的 HttpFetchError。git 识别为重命名,共享意图在 diff 里就是显式的。MePermissionsProvider 行为零变化

策略保持分开,因为姿态相反

姿态 重试期间 预算
MePermissionsProvider fail-closed 保持 loading,不渲染 3 × 500ms
LocalizationFetchProvider cosmetic 始终渲染 children 4 × 1s

localization 更有耐心是刻意的:没有东西在等它,所以它可以在慢环境暖机结束时仍在尝试;对用户而言迟到的货币符号好过永远没有。

不重试的仍不重试:401 / 403 / 404 / 500 是关于调用者的真实答案,第一次就失败。

测试:8 例,此前零覆盖

其中一例钉的是姿态而不是行为:

never blocks: children render while the fetch is still failing

它防的是一个具体的未来回归 —— 有人"顺手对齐两个 provider",把 fail-closed 的阻塞语义搬到这个绝不能阻塞的面上。原语共享之后,这种对齐冲动只会更强,所以这条断言值得单独存在。

验证

结果
console localization 8/8(新增)
permissions(回归,改了导入路径) 124/124
全量 objectui 套件 8998 passed / 24 skipped
type-check 78/78
改动文件 lint 0 error

关联:objectstack#4159(503 的来源)、objectui#3052(permissions 侧的同类修复)、objectui#3050、cloud#927。


🤖 Generated with Claude Code

https://claude.ai/code/session_016gEeLZ4oTeSXG6fKG1r3vd


Generated by Claude Code

…ization failure

`/auth/me/localization` is served by the environment kernel that owns the session
on a multi-tenant host, and a cold one answers 503 + `Retry-After` while it warms
(objectstack#4159). A transient failure is a normal part of a cold start there,
not an exception.

The provider made ONE attempt and `.catch()`-ed into silence, so a single 503
during warm-up left currency and locale unset for the WHOLE session — every money
field a plain number, nothing ever trying again, long after the kernel was ready.
Silent and permanent, which is why nobody would report it as a bug.

I had looked at this file during objectui#3052 and judged it "cosmetic, degrades
gracefully, no change needed". That was right at the time and wrong afterwards:
#4159 turned 503 from an anomaly into this endpoint's routine answer, and the
judgement was never revisited. The asymmetry with MePermissionsProvider — same
host, same provenance, same 503, opposite handling — is what surfaced it.

PRIMITIVES SHARED, POLICY NOT. "Is this transient", "how long to wait" and the
`Retry-After` parsing move from @object-ui/permissions' internal module to
@object-ui/types — the lowest package both callers reach — and
`PermissionsFetchError` becomes the generic `HttpFetchError`. One definition of
transient rather than a second copy free to drift. No behaviour change for
MePermissionsProvider.

The policies stay separate because the postures are opposite: permissions is
FAIL-CLOSED and holds its loading state across the waits (rendering a permissive
default early is a real hazard); localization is COSMETIC and keeps rendering
children throughout, filling the value in if and when an attempt succeeds. Its
budget is also more patient (4 × 1s base vs 3 × 500ms) — nothing waits on it, so
it can still be trying when a slow environment finishes warming.

Tests: 8 new, where there were none. One pins the POSTURE rather than the
behaviour — children must be rendered while the fetch is still failing — because
the plausible future regression here is someone "aligning the two providers" and
carrying the fail-closed blocking onto a surface that must never block.

Verified: console localization 8/8, permissions 124/124 (regression), full
objectui suite 8998 passed / 24 skipped, type-check 78/78, changed-file lint 0.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_016gEeLZ4oTeSXG6fKG1r3vd
@vercel

vercel Bot commented Jul 31, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated (UTC)
objectui Ignored Ignored Jul 31, 2026 6:04am

Request Review

@github-actions

Copy link
Copy Markdown
Contributor

✅ Console Performance Budget

Metric Value Budget
Main entry (gzip) 28.0 KB 350 KB
Entry file index-bhSTuG8S.js
Status PASS

📦 Bundle Size Report

Package Size Gzipped
app-shell (index.js) 8.26KB 2.99KB
app-shell (runtime-config.js) 7.42KB 2.32KB
app-shell (types.js) 0.01KB 0.04KB
app-shell (urlParams.js) 7.57KB 2.97KB
auth (AuthContext.js) 0.31KB 0.24KB
auth (AuthGuard.js) 1.17KB 0.53KB
auth (AuthProvider.js) 22.10KB 4.37KB
auth (AuthShell.js) 3.49KB 1.40KB
auth (ForgotPasswordForm.js) 12.12KB 3.41KB
auth (LoginForm.js) 17.86KB 5.29KB
auth (PreviewBanner.js) 0.90KB 0.50KB
auth (RegisterForm.js) 6.43KB 2.09KB
auth (SocialSignInButtons.js) 9.60KB 3.89KB
auth (UserMenu.js) 3.40KB 1.22KB
auth (auth-gate-events.js) 1.29KB 0.66KB
auth (authStyles.js) 5.04KB 1.72KB
auth (createAuthClient.js) 35.76KB 9.11KB
auth (createAuthenticatedFetch.js) 4.37KB 1.69KB
auth (index.js) 2.35KB 1.07KB
auth (org-roles.js) 6.66KB 2.78KB
auth (phone-identifier.js) 1.11KB 0.66KB
auth (types.js) 0.59KB 0.35KB
auth (useAuth.js) 4.91KB 0.87KB
auth (useIsWorkspaceAdmin.js) 1.61KB 0.85KB
collaboration (CommentThread.js) 18.38KB 4.49KB
collaboration (LiveCursors.js) 3.17KB 1.27KB
collaboration (PresenceAvatars.js) 3.65KB 1.42KB
collaboration (PresenceProvider.js) 2.79KB 1.13KB
collaboration (index.js) 1.25KB 0.53KB
collaboration (useCommentSearch.js) 1.98KB 0.88KB
collaboration (useConflictResolution.js) 7.75KB 1.86KB
collaboration (useMentionNotifications.js) 1.81KB 0.68KB
collaboration (usePresence.js) 6.33KB 1.84KB
collaboration (useRealtimeSubscription.js) 7.91KB 2.01KB
components (index.js) 473.75KB 103.77KB
core (index.js) 2.16KB 0.78KB
create-plugin (index.js) 9.28KB 2.98KB
data-objectstack (index.js) 136.34KB 34.64KB
fields (index.js) 222.07KB 54.35KB
i18n (LocalizationContext.js) 1.76KB 0.96KB
i18n (currency.js) 1.22KB 0.64KB
i18n (i18n.js) 4.32KB 1.77KB
i18n (index.js) 2.46KB 0.96KB
i18n (pickLocalized.js) 1.70KB 0.83KB
i18n (provider.js) 5.37KB 1.72KB
i18n (useObjectLabel.js) 25.17KB 5.80KB
i18n (useSafeTranslation.js) 3.26KB 1.44KB
layout (index.js) 38.44KB 10.66KB
mobile (MobileProvider.js) 0.92KB 0.49KB
mobile (ResponsiveContainer.js) 0.94KB 0.38KB
mobile (breakpoints.js) 1.51KB 0.70KB
mobile (createOfflineDataSource.js) 5.61KB 1.74KB
mobile (index.js) 1.50KB 0.62KB
mobile (offlineQueue.js) 3.91KB 1.35KB
mobile (pwa.js) 0.97KB 0.49KB
mobile (serviceWorker.js) 1.48KB 0.62KB
mobile (serviceWorkerSource.js) 3.41KB 1.48KB
mobile (useBreakpoint.js) 1.54KB 0.65KB
mobile (useGesture.js) 6.96KB 1.98KB
mobile (useOfflineSync.js) 1.99KB 0.72KB
mobile (usePullToRefresh.js) 2.53KB 0.85KB
mobile (useResponsive.js) 0.71KB 0.42KB
mobile (useResponsiveConfig.js) 1.36KB 0.63KB
mobile (useSpecGesture.js) 4.05KB 1.53KB
mobile (useTouchTarget.js) 1.01KB 0.54KB
permissions (MePermissionsProvider.js) 8.75KB 3.06KB
permissions (PermissionContext.js) 0.31KB 0.25KB
permissions (PermissionGuard.js) 0.89KB 0.45KB
permissions (PermissionProvider.js) 3.67KB 1.12KB
permissions (evaluator.js) 4.41KB 1.44KB
permissions (index.js) 0.91KB 0.41KB
permissions (store.js) 0.91KB 0.42KB
permissions (useFieldPermissions.js) 1.28KB 0.52KB
permissions (usePermissions.js) 1.55KB 0.71KB
plugin-ai (index.js) 15.71KB 3.79KB
plugin-calendar (index.js) 44.90KB 12.35KB
plugin-charts (index.js) 60.52KB 17.11KB
plugin-chatbot (index.js) 180.09KB 42.72KB
plugin-dashboard (index.js) 111.59KB 28.74KB
plugin-designer (index.js) 210.51KB 42.50KB
plugin-detail (index.js) 221.81KB 54.28KB
plugin-editor (index.js) 2.46KB 1.10KB
plugin-form (index.js) 111.38KB 26.93KB
plugin-gantt (index.js) 162.26KB 39.53KB
plugin-grid (index.js) 182.21KB 48.24KB
plugin-kanban (index.js) 47.82KB 13.18KB
plugin-list (index.js) 103.85KB 24.80KB
plugin-map (index.js) 16.80KB 5.24KB
plugin-markdown (index.js) 13.65KB 4.67KB
plugin-report (index.js) 40.32KB 10.53KB
plugin-timeline (index.js) 25.75KB 7.32KB
plugin-tree (index.js) 8.36KB 2.81KB
plugin-view (index.js) 83.54KB 20.39KB
providers (DataSourceProvider.js) 0.75KB 0.39KB
providers (MetadataProvider.js) 1.37KB 0.59KB
providers (ThemeProvider.js) 1.90KB 0.85KB
providers (UploadProvider.js) 11.71KB 3.53KB
providers (index.js) 0.44KB 0.22KB
providers (types.js) 0.01KB 0.04KB
react-runtime (index.js) 5.67KB 2.37KB
react (LazyPluginLoader.js) 3.77KB 1.33KB
react (SchemaRenderer.js) 19.28KB 6.38KB
react (data-invalidation.js) 5.05KB 2.08KB
react (index.js) 1.02KB 0.55KB
sdui-parser (codegen.js) 4.09KB 1.74KB
sdui-parser (index.js) 3.47KB 1.54KB
sdui-parser (parse.js) 10.04KB 2.82KB
sdui-parser (types.js) 0.29KB 0.24KB
sdui-parser (validate.js) 4.69KB 1.48KB
types (ai.js) 0.20KB 0.17KB
types (api-types.js) 0.20KB 0.18KB
types (app.js) 2.87KB 0.99KB
types (base.js) 0.20KB 0.18KB
types (blocks.js) 0.20KB 0.18KB
types (complex.js) 0.20KB 0.18KB
types (crud.js) 0.20KB 0.18KB
types (data-display.js) 0.20KB 0.18KB
types (data-protocol.js) 0.20KB 0.19KB
types (data.js) 0.20KB 0.18KB
types (designer.js) 1.87KB 0.85KB
types (disclosure.js) 0.20KB 0.18KB
types (error-code.js) 1.54KB 0.88KB
types (feedback.js) 0.20KB 0.18KB
types (field-types.js) 0.20KB 0.18KB
types (form.js) 0.20KB 0.18KB
types (http-retry.js) 4.32KB 2.02KB
types (index.js) 2.45KB 1.21KB
types (layout.js) 0.20KB 0.18KB
types (managed-by.js) 0.19KB 0.18KB
types (mobile.js) 0.20KB 0.18KB
types (navigation.js) 0.20KB 0.18KB
types (objectql.js) 0.20KB 0.18KB
types (overlay.js) 0.20KB 0.18KB
types (permissions.js) 0.20KB 0.18KB
types (plugin-scope.js) 0.20KB 0.18KB
types (record-components.js) 0.20KB 0.19KB
types (record-semantics.js) 1.28KB 0.67KB
types (registry.js) 0.20KB 0.18KB
types (reports.js) 0.20KB 0.18KB
types (spec-report.js) 5.05KB 1.93KB
types (system-fields.js) 3.33KB 1.54KB
types (theme.js) 0.20KB 0.18KB
types (ui-action.js) 1.08KB 0.64KB
types (views.js) 0.20KB 0.18KB
types (widget.js) 0.20KB 0.18KB

Size Limits

  • ✅ Core packages should be < 50KB gzipped
  • ✅ Component packages should be < 100KB gzipped
  • ⚠️ Plugin packages should be < 150KB gzipped

@os-zhuang
os-zhuang marked this pull request as ready for review July 31, 2026 06:10
@os-zhuang
os-zhuang merged commit 49e5671 into main Jul 31, 2026
16 checks passed
@os-zhuang
os-zhuang deleted the claude/vercel-startup-permissions-provider-iwtkqm branch July 31, 2026 06:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants