Skip to content

docs(app-shell): the wait-key retirement lands in spec 17.0.0, not the "18" its tombstone claims (#3101) - #3105

Merged
os-zhuang merged 1 commit into
mainfrom
claude/wait-form-spec-18-deprecation-9ef7c3
Jul 31, 2026
Merged

docs(app-shell): the wait-key retirement lands in spec 17.0.0, not the "18" its tombstone claims (#3101)#3105
os-zhuang merged 1 commit into
mainfrom
claude/wait-form-spec-18-deprecation-9ef7c3

Conversation

@os-zhuang

@os-zhuang os-zhuang commented Jul 31, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

#3101 记了一条待办:wait 表单还提供 waitEventConfig.timeoutMs / .onTimeout,而 framework#4198 已经给它们上了墓碑。待办本身成立 —— 触发时机写错了。

没有 18 可等

zodKeys 的 TSDoc(以及 #3101 正文、以及 framework#4198 自己的 changeset 正文)都写着这两个键"retired at spec 18",于是 #3101 的处置写成「在把 @objectstack/spec 升到 18 的那个 PR 里一并处理」。当前的发布机器产不出 18:

事实 值
npm dist-tags latest = 16.1.0,rc = 17.0.0-rc.0 —— 17.0.0 从未发布
framework .changeset/pre.json mode: "pre", tag: "rc",@objectstack/spec initialVersion = 16.1.0
#4198 的 changeset '@objectstack/spec': major
算出来的下一版 pre 模式从上一个已发布版本起算:16.1.0 + major = 17.0.0(发成 17.0.0-rc.1)
framework main 两个墓碑已在树上(ab1633122),同一棵树上 PROTOCOL_VERSION = '17.0.0',且 protocol-version.test.ts 把它钉死在 package.json 的 major 上
ADR-0059 §4 删除 → "bump to a new major";相对已发布的 16.1.0,那个 new major 就是 17

"18" 是从在研版本号 17.0.0-rc.0 往上数了一位得来的,而 changesets 是从 16.1.0 往上算的。framework main 上 9 处墓碑文案写 18、32 处写 17;那 9 处的共同点只是"在 rc.0 切出之后才落地",全都还在 17 这趟车上(objectstack#3909 "the 17.0.0 train" 仍开着)。已装的 rc.0 里 spec 18 出现 0 次,spec 17 出现 200 次。

这条注释为什么值得改

它是这个 ratchet 的触发条件说明。写成"等 18",这条待办就会等一个不会到来的事件,然后在下一次 rc 刷新时被动踩雷 —— 正是 #3101 想避免的那件事。改后的注释把推导过程也记下来,免得下一个人重新数错一遍。

仅注释;zodKeys 的过滤逻辑与三处断言一字未动。

不受影响的部分

不要单独先删这两个字段 仍然成立,只是理由要换:sibling-block 断言是双向的(flow-node-config.spec-reconciliation.test.ts L192-199),而已装的 rc.0 里 waitEventConfig 仍把两个键声明为活键,现在删会在反方向红(declared by the spec block but absent from the designer form)。轴是"已装 rc.0 vs 下一次 rc",不是"17 vs 18"。

验证

pnpm exec vitest run packages/app-shell/src/views/metadata-admin/inspectors/flow-node-config.spec-reconciliation.test.ts
→ 1 passed | 3 passed | 5 skipped

(5 skipped = script/subflow/decision 三个 feature-detect 面板,已装 spec 尚未导出它们的契约 —— 与改动前一致。)

Related

🤖 Generated with Claude Code

@os-zhuang @claude
docs(app-shell): the wait-key retirement lands in spec 17.0.0, not th…
08a93fe 
…e "18" its tombstone claims (#3101)

`zodKeys`' TSDoc named "spec 18" as the bump that arms the `wait` panel,
copied from framework#4198's own prose. There is no 18 to wait for:
`@objectstack/spec` publishes `latest` 16.1.0 / `rc` 17.0.0-rc.0, and
changesets computes a pre-release train off the last *published* major — so
the retirement's `major` changeset resolves to 17.0.0-rc.x, not 18. framework
main already carries both tombstones (ab1633122) with
`PROTOCOL_VERSION = '17.0.0'`.

Comment only; the filter and the assertions are unchanged. The correction
matters because it names the trigger: the panel fires on the next rc this
repo installs, not on a major the current release train cannot produce.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
@vercel

vercel Bot commented Jul 31, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated (UTC)
objectui Ignored Ignored Jul 31, 2026 7:35am

Request Review

@github-actions github-actions Bot added the tests label Jul 31, 2026
This was referenced Jul 31, 2026
Open
Closed
@github-actions

github-actions Bot commented Jul 31, 2026

Copy link
Copy Markdown
Contributor

✅ Console Performance Budget

Metric Value Budget
Main entry (gzip) 28.1 KB 350 KB
Entry file index-BOl6My3k.js —
Status PASS —

📦 Bundle Size Report

Package Size Gzipped
app-shell (index.js) 8.26KB 2.99KB
app-shell (runtime-config.js) 7.42KB 2.32KB
app-shell (types.js) 0.01KB 0.04KB
app-shell (urlParams.js) 7.57KB 2.97KB
auth (AuthContext.js) 0.31KB 0.24KB
auth (AuthGuard.js) 1.17KB 0.53KB
auth (AuthProvider.js) 22.10KB 4.37KB
auth (AuthShell.js) 3.49KB 1.40KB
auth (ForgotPasswordForm.js) 12.12KB 3.41KB
auth (LoginForm.js) 17.86KB 5.29KB
auth (PreviewBanner.js) 0.90KB 0.50KB
auth (RegisterForm.js) 6.43KB 2.09KB
auth (SocialSignInButtons.js) 9.60KB 3.89KB
auth (UserMenu.js) 3.40KB 1.22KB
auth (auth-gate-events.js) 1.29KB 0.66KB
auth (authStyles.js) 5.04KB 1.72KB
auth (createAuthClient.js) 35.76KB 9.11KB
auth (createAuthenticatedFetch.js) 4.37KB 1.69KB
auth (index.js) 2.35KB 1.07KB
auth (org-roles.js) 6.66KB 2.78KB
auth (phone-identifier.js) 1.11KB 0.66KB
auth (types.js) 0.59KB 0.35KB
auth (useAuth.js) 4.91KB 0.87KB
auth (useIsWorkspaceAdmin.js) 1.61KB 0.85KB
collaboration (CommentThread.js) 18.38KB 4.49KB
collaboration (LiveCursors.js) 3.17KB 1.27KB
collaboration (PresenceAvatars.js) 3.65KB 1.42KB
collaboration (PresenceProvider.js) 2.79KB 1.13KB
collaboration (index.js) 1.25KB 0.53KB
collaboration (useCommentSearch.js) 1.98KB 0.88KB
collaboration (useConflictResolution.js) 7.75KB 1.86KB
collaboration (useMentionNotifications.js) 1.81KB 0.68KB
collaboration (usePresence.js) 6.33KB 1.84KB
collaboration (useRealtimeSubscription.js) 7.91KB 2.01KB
components (index.js) 474.19KB 103.88KB
core (index.js) 2.20KB 0.79KB
create-plugin (index.js) 9.28KB 2.98KB
data-objectstack (index.js) 136.34KB 34.64KB
fields (index.js) 222.06KB 54.35KB
i18n (LocalizationContext.js) 1.76KB 0.96KB
i18n (currency.js) 1.22KB 0.64KB
i18n (i18n.js) 4.32KB 1.77KB
i18n (index.js) 2.46KB 0.96KB
i18n (pickLocalized.js) 1.70KB 0.83KB
i18n (provider.js) 5.37KB 1.72KB
i18n (useObjectLabel.js) 25.17KB 5.80KB
i18n (useSafeTranslation.js) 3.26KB 1.44KB
layout (index.js) 38.44KB 10.66KB
mobile (MobileProvider.js) 0.92KB 0.49KB
mobile (ResponsiveContainer.js) 0.94KB 0.38KB
mobile (breakpoints.js) 1.51KB 0.70KB
mobile (createOfflineDataSource.js) 5.61KB 1.74KB
mobile (index.js) 1.50KB 0.62KB
mobile (offlineQueue.js) 3.91KB 1.35KB
mobile (pwa.js) 0.97KB 0.49KB
mobile (serviceWorker.js) 1.48KB 0.62KB
mobile (serviceWorkerSource.js) 3.41KB 1.48KB
mobile (useBreakpoint.js) 1.54KB 0.65KB
mobile (useGesture.js) 6.96KB 1.98KB
mobile (useOfflineSync.js) 1.99KB 0.72KB
mobile (usePullToRefresh.js) 2.53KB 0.85KB
mobile (useResponsive.js) 0.71KB 0.42KB
mobile (useResponsiveConfig.js) 1.36KB 0.63KB
mobile (useSpecGesture.js) 4.05KB 1.53KB
mobile (useTouchTarget.js) 1.01KB 0.54KB
permissions (MePermissionsProvider.js) 8.75KB 3.06KB
permissions (PermissionContext.js) 0.31KB 0.25KB
permissions (PermissionGuard.js) 0.89KB 0.45KB
permissions (PermissionProvider.js) 3.67KB 1.12KB
permissions (evaluator.js) 4.41KB 1.44KB
permissions (index.js) 0.91KB 0.41KB
permissions (store.js) 0.91KB 0.42KB
permissions (useFieldPermissions.js) 1.28KB 0.52KB
permissions (usePermissions.js) 1.55KB 0.71KB
plugin-ai (index.js) 15.71KB 3.79KB
plugin-calendar (index.js) 44.90KB 12.35KB
plugin-charts (index.js) 60.52KB 17.11KB
plugin-chatbot (index.js) 180.09KB 42.72KB
plugin-dashboard (index.js) 111.59KB 28.74KB
plugin-designer (index.js) 210.51KB 42.50KB
plugin-detail (index.js) 221.90KB 54.29KB
plugin-editor (index.js) 2.46KB 1.10KB
plugin-form (index.js) 111.38KB 26.93KB
plugin-gantt (index.js) 162.26KB 39.53KB
plugin-grid (index.js) 182.21KB 48.24KB
plugin-kanban (index.js) 47.82KB 13.18KB
plugin-list (index.js) 104.87KB 25.18KB
plugin-map (index.js) 16.80KB 5.24KB
plugin-markdown (index.js) 13.65KB 4.67KB
plugin-report (index.js) 40.32KB 10.53KB
plugin-timeline (index.js) 25.75KB 7.32KB
plugin-tree (index.js) 8.36KB 2.81KB
plugin-view (index.js) 83.54KB 20.39KB
providers (DataSourceProvider.js) 0.75KB 0.39KB
providers (MetadataProvider.js) 1.37KB 0.59KB
providers (ThemeProvider.js) 1.90KB 0.85KB
providers (UploadProvider.js) 11.71KB 3.53KB
providers (index.js) 0.44KB 0.22KB
providers (types.js) 0.01KB 0.04KB
react-runtime (index.js) 5.67KB 2.37KB
react (LazyPluginLoader.js) 3.77KB 1.33KB
react (SchemaRenderer.js) 19.28KB 6.38KB
react (data-invalidation.js) 5.05KB 2.08KB
react (index.js) 1.02KB 0.55KB
sdui-parser (codegen.js) 4.09KB 1.74KB
sdui-parser (index.js) 3.47KB 1.54KB
sdui-parser (parse.js) 10.04KB 2.82KB
sdui-parser (types.js) 0.29KB 0.24KB
sdui-parser (validate.js) 4.69KB 1.48KB
types (ai.js) 0.20KB 0.17KB
types (api-types.js) 0.20KB 0.18KB
types (app.js) 2.87KB 0.99KB
types (base.js) 0.20KB 0.18KB
types (blocks.js) 0.20KB 0.18KB
types (complex.js) 0.20KB 0.18KB
types (crud.js) 0.20KB 0.18KB
types (data-display.js) 0.20KB 0.18KB
types (data-protocol.js) 0.20KB 0.19KB
types (data.js) 0.20KB 0.18KB
types (designer.js) 1.87KB 0.85KB
types (disclosure.js) 0.20KB 0.18KB
types (error-code.js) 1.54KB 0.88KB
types (feedback.js) 0.20KB 0.18KB
types (field-types.js) 0.20KB 0.18KB
types (form.js) 0.20KB 0.18KB
types (http-retry.js) 4.32KB 2.02KB
types (index.js) 2.45KB 1.21KB
types (layout.js) 0.20KB 0.18KB
types (managed-by.js) 0.19KB 0.18KB
types (mobile.js) 0.20KB 0.18KB
types (navigation.js) 0.20KB 0.18KB
types (objectql.js) 0.20KB 0.18KB
types (overlay.js) 0.20KB 0.18KB
types (permissions.js) 0.20KB 0.18KB
types (plugin-scope.js) 0.20KB 0.18KB
types (record-components.js) 0.20KB 0.19KB
types (record-semantics.js) 1.28KB 0.67KB
types (registry.js) 0.20KB 0.18KB
types (reports.js) 0.20KB 0.18KB
types (spec-report.js) 5.05KB 1.93KB
types (system-fields.js) 3.33KB 1.54KB
types (theme.js) 0.20KB 0.18KB
types (ui-action.js) 1.08KB 0.64KB
types (views.js) 0.20KB 0.18KB
types (widget.js) 0.20KB 0.18KB

Size Limits

  • ✅ Core packages should be < 50KB gzipped
  • ✅ Component packages should be < 100KB gzipped
  • ⚠️ Plugin packages should be < 150KB gzipped

@os-zhuang
os-zhuang merged commit de2e748 into main Jul 31, 2026
16 checks passed
@os-zhuang
os-zhuang deleted the claude/wait-form-spec-18-deprecation-9ef7c3 branch July 31, 2026 07:42
@os-zhuang os-zhuang mentioned this pull request Jul 31, 2026
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

tests

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@os-zhuang