Skip to content

docs(app-shell): the wait-key retirement lands in spec 17.0.0, not the "18" its tombstone claims (#3101) #3105

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
os-zhuang merged 1 commit into from
Jul 31, 2026
Merged

docs(app-shell): the wait-key retirement lands in spec 17.0.0, not the "18" its tombstone claims (#3101) #3105

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 11 additions & 3 deletions ...pp-shell/src/views/metadata-admin/inspectors/flow-node-config.spec-reconciliation.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,9 +52,17 @@ const SCRIPT_INVOKE_FUNCTION_ACTION_TYPE = spec.SCRIPT_INVOKE_FUNCTION_ACTION_TY
* marks it with a `[REMOVED]` description), but it is NOT part of the
* authorable contract — a form field writing one produces metadata the loader
* rejects. Counting tombstones as contract keys would false-pass exactly that
* drift (e.g. `waitEventConfig.timeoutMs` / `.onTimeout`, retired at spec 18
* by framework#4198 — this filter is what makes the `wait` panel fire on that
* bump until the form drops the two fields).
* drift (e.g. `waitEventConfig.timeoutMs` / `.onTimeout`, retired by
* framework#4198 — this filter is what makes the `wait` panel fire on the spec
* bump that carries their tombstones, until the form drops the two fields).
*
* That bump is a **17.0.0-rc refresh**, not the "spec 18" the tombstone text
* itself names: changesets computes a pre-release train off the last
* *published* major (`@objectstack/spec` latest is 16.1.0, `rc` is
* 17.0.0-rc.0), so the retirement's `major` resolves to **17.0.0** — and
* framework main carries the tombstones with `PROTOCOL_VERSION = '17.0.0'`.
* The trigger is the next rc this repo installs, not a major that the current
* release train cannot produce. Tracked in #3101.
*/
function zodKeys(schema: unknown): string[] {
const shape = (schema as { shape?: Record<string, unknown> }).shape;
Expand Down
Loading