fix(detail): Attachments become a peer tab with a live count badge, and their copy is translated (objectstack#4358) by baozhoutao · Pull Request #3123 · objectstack-ai/objectui

baozhoutao · 2026-07-31T12:04:23Z

Fixes objectstack-ai/objectstack#4358.

Problem

On enable.files: true record detail pages (console 17.0.0-rc.0):

The Attachments panel was buried. RecordDetailView appended it AFTER the schema-rendered page tree, whose synthesized default embeds record:discussion as the last main component — so the panel always sat below an ever-growing feed timeline, undiscoverable without scrolling to the very bottom, with no metadata knob to move it.
Its copy was never translated. All eleven detail.* keys (attachments, uploadAttachment, loadingAttachments, noAttachments, downloadAttachment, deleteAttachment, plus the five attachment*Denied/Required friendly errors) existed only as inline English defaultValues; no locale bundle carried them, so non-English consoles always showed English.

Fix

Placement — a peer Attachments tab (per design review):

buildDefaultTabs emits an Attachments tab (new record:attachments node) between Related and Activity/History for enable.files objects; a hideAttachments synthesizer option suppresses it.
The node is rendered by a new app-shell registration wrapping the existing RecordAttachmentsPanel via RecordContext (registered from the app-shell barrel so Studio's PagePreview resolves it too).
PageTabsRenderer derives the tab's count badge from a sys_attachment probe scoped to (parent_object, parent_id) — the probe wrapper injects the two-key filter the RelatedCountStore shape can't express, while a synthetic relationshipField keeps the cache key unique; the store's existing sys_attachment invalidation (MutationEvent bridge) updates the badge live on upload/delete.
The tab label rides the existing KNOWN_LABEL_DICT (→ 附件 etc.).
RecordDetailView keeps its legacy bottom append only as the fallback for authored pages that don't place the node (hasExplicitAttachments walker in pageSchemaIntrospect).

i18n: all ten locales now define the eleven detail.* keys.

Verification

Unit: new synthesis + introspection cases; 101 files / 1065 tests green across plugin-detail, i18n, components, app-shell utils; full pnpm build 43/43.
Browser (objectui HMR console against a framework showcase backend, zh locale): tab strip renders 详情 / 相关 1 / 附件 1; the panel fills the tab with fully translated copy; creating/deleting a sys_attachment row updates the badge; small screens keep the tab.
Note: showcase's demo showcase_project page overrides the tabs slot (authored full replacement), which legitimately supersedes the synthesized tab — verified by temporarily detaching that assignment locally.

🤖 Generated with Claude Code

vercel · 2026-07-31T12:04:29Z

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment

Project	Deployment	Actions	Updated (UTC)
objectui	Ignored		Jul 31, 2026 12:04pm

github-actions · 2026-07-31T12:08:18Z

✅ Console Performance Budget

Metric	Value	Budget
Main entry (gzip)	28.1 KB	350 KB
Entry file	`index-BJC4txCo.js`	—
Status	PASS	—

📦 Bundle Size Report

Package	Size	Gzipped
app-shell (index.js)	8.45KB	3.08KB
app-shell (runtime-config.js)	7.42KB	2.32KB
app-shell (types.js)	0.01KB	0.04KB
app-shell (urlParams.js)	7.57KB	2.97KB
auth (AuthContext.js)	0.31KB	0.24KB
auth (AuthGuard.js)	1.17KB	0.53KB
auth (AuthProvider.js)	22.10KB	4.37KB
auth (AuthShell.js)	3.49KB	1.40KB
auth (ForgotPasswordForm.js)	12.12KB	3.41KB
auth (LoginForm.js)	17.86KB	5.29KB
auth (PreviewBanner.js)	0.90KB	0.50KB
auth (RegisterForm.js)	6.43KB	2.09KB
auth (SocialSignInButtons.js)	9.60KB	3.89KB
auth (UserMenu.js)	3.40KB	1.22KB
auth (auth-gate-events.js)	1.29KB	0.66KB
auth (authStyles.js)	5.04KB	1.72KB
auth (createAuthClient.js)	35.76KB	9.11KB
auth (createAuthenticatedFetch.js)	4.37KB	1.69KB
auth (index.js)	2.35KB	1.07KB
auth (org-roles.js)	6.66KB	2.78KB
auth (phone-identifier.js)	1.11KB	0.66KB
auth (types.js)	0.59KB	0.35KB
auth (useAuth.js)	4.91KB	0.87KB
auth (useIsWorkspaceAdmin.js)	1.61KB	0.85KB
collaboration (CommentThread.js)	18.38KB	4.49KB
collaboration (LiveCursors.js)	3.17KB	1.27KB
collaboration (PresenceAvatars.js)	3.65KB	1.42KB
collaboration (PresenceProvider.js)	2.79KB	1.13KB
collaboration (index.js)	1.25KB	0.53KB
collaboration (useCommentSearch.js)	1.98KB	0.88KB
collaboration (useConflictResolution.js)	7.75KB	1.86KB
collaboration (useMentionNotifications.js)	1.81KB	0.68KB
collaboration (usePresence.js)	6.33KB	1.84KB
collaboration (useRealtimeSubscription.js)	7.91KB	2.01KB
components (index.js)	475.53KB	104.22KB
core (index.js)	2.25KB	0.80KB
create-plugin (index.js)	9.28KB	2.98KB
data-objectstack (index.js)	136.20KB	34.74KB
fields (index.js)	222.06KB	54.35KB
i18n (LocalizationContext.js)	1.76KB	0.96KB
i18n (currency.js)	1.22KB	0.64KB
i18n (i18n.js)	4.32KB	1.77KB
i18n (index.js)	2.46KB	0.96KB
i18n (pickLocalized.js)	1.70KB	0.83KB
i18n (provider.js)	5.37KB	1.72KB
i18n (useObjectLabel.js)	25.17KB	5.80KB
i18n (useSafeTranslation.js)	3.26KB	1.44KB
layout (index.js)	38.44KB	10.66KB
mobile (MobileProvider.js)	0.92KB	0.49KB
mobile (ResponsiveContainer.js)	0.94KB	0.38KB
mobile (breakpoints.js)	1.51KB	0.70KB
mobile (createOfflineDataSource.js)	5.61KB	1.74KB
mobile (index.js)	1.50KB	0.62KB
mobile (offlineQueue.js)	3.91KB	1.35KB
mobile (pwa.js)	0.97KB	0.49KB
mobile (serviceWorker.js)	1.48KB	0.62KB
mobile (serviceWorkerSource.js)	3.41KB	1.48KB
mobile (useBreakpoint.js)	1.54KB	0.65KB
mobile (useGesture.js)	6.96KB	1.98KB
mobile (useOfflineSync.js)	1.99KB	0.72KB
mobile (usePullToRefresh.js)	2.53KB	0.85KB
mobile (useResponsive.js)	0.71KB	0.42KB
mobile (useResponsiveConfig.js)	1.36KB	0.63KB
mobile (useSpecGesture.js)	4.05KB	1.53KB
mobile (useTouchTarget.js)	1.01KB	0.54KB
permissions (MePermissionsProvider.js)	8.75KB	3.06KB
permissions (PermissionContext.js)	0.31KB	0.25KB
permissions (PermissionGuard.js)	0.89KB	0.45KB
permissions (PermissionProvider.js)	3.67KB	1.12KB
permissions (evaluator.js)	4.41KB	1.44KB
permissions (index.js)	0.91KB	0.41KB
permissions (store.js)	0.91KB	0.42KB
permissions (useFieldPermissions.js)	1.28KB	0.52KB
permissions (usePermissions.js)	1.55KB	0.71KB
plugin-ai (index.js)	15.71KB	3.79KB
plugin-calendar (index.js)	44.90KB	12.35KB
plugin-charts (index.js)	60.52KB	17.11KB
plugin-chatbot (index.js)	180.09KB	42.72KB
plugin-dashboard (index.js)	111.59KB	28.74KB
plugin-designer (index.js)	210.51KB	42.50KB
plugin-detail (index.js)	222.45KB	54.50KB
plugin-editor (index.js)	2.46KB	1.10KB
plugin-form (index.js)	111.38KB	26.93KB
plugin-gantt (index.js)	162.26KB	39.53KB
plugin-grid (index.js)	183.29KB	48.56KB
plugin-kanban (index.js)	47.82KB	13.18KB
plugin-list (index.js)	104.62KB	25.18KB
plugin-map (index.js)	16.80KB	5.24KB
plugin-markdown (index.js)	13.65KB	4.67KB
plugin-report (index.js)	40.32KB	10.53KB
plugin-timeline (index.js)	25.75KB	7.32KB
plugin-tree (index.js)	8.34KB	2.82KB
plugin-view (index.js)	83.54KB	20.39KB
providers (DataSourceProvider.js)	0.75KB	0.39KB
providers (MetadataProvider.js)	1.37KB	0.59KB
providers (ThemeProvider.js)	1.90KB	0.85KB
providers (UploadProvider.js)	11.71KB	3.53KB
providers (index.js)	0.44KB	0.22KB
providers (types.js)	0.01KB	0.04KB
react-runtime (index.js)	5.67KB	2.37KB
react (LazyPluginLoader.js)	3.77KB	1.33KB
react (SchemaRenderer.js)	19.28KB	6.38KB
react (data-invalidation.js)	5.05KB	2.08KB
react (index.js)	1.02KB	0.55KB
sdui-parser (codegen.js)	4.09KB	1.74KB
sdui-parser (index.js)	3.47KB	1.54KB
sdui-parser (parse.js)	10.04KB	2.82KB
sdui-parser (types.js)	0.29KB	0.24KB
sdui-parser (validate.js)	4.69KB	1.48KB
types (ai.js)	0.20KB	0.17KB
types (api-types.js)	0.20KB	0.18KB
types (app.js)	2.87KB	0.99KB
types (base.js)	0.20KB	0.18KB
types (blocks.js)	0.20KB	0.18KB
types (complex.js)	0.20KB	0.18KB
types (crud.js)	0.20KB	0.18KB
types (data-display.js)	0.20KB	0.18KB
types (data-protocol.js)	0.20KB	0.19KB
types (data.js)	0.20KB	0.18KB
types (designer.js)	1.87KB	0.85KB
types (disclosure.js)	0.20KB	0.18KB
types (error-code.js)	1.54KB	0.88KB
types (feedback.js)	0.20KB	0.18KB
types (field-types.js)	0.20KB	0.18KB
types (form.js)	0.20KB	0.18KB
types (http-retry.js)	4.32KB	2.02KB
types (index.js)	2.45KB	1.21KB
types (layout.js)	0.20KB	0.18KB
types (managed-by.js)	0.19KB	0.18KB
types (mobile.js)	0.20KB	0.18KB
types (navigation.js)	0.20KB	0.18KB
types (objectql.js)	0.20KB	0.18KB
types (overlay.js)	0.20KB	0.18KB
types (permissions.js)	0.20KB	0.18KB
types (plugin-scope.js)	0.20KB	0.18KB
types (record-components.js)	0.20KB	0.19KB
types (record-semantics.js)	1.28KB	0.67KB
types (registry.js)	0.20KB	0.18KB
types (reports.js)	0.20KB	0.18KB
types (spec-report.js)	5.05KB	1.93KB
types (system-fields.js)	3.33KB	1.54KB
types (theme.js)	0.20KB	0.18KB
types (ui-action.js)	1.08KB	0.64KB
types (views.js)	0.20KB	0.18KB
types (widget.js)	0.20KB	0.18KB

Size Limits

✅ Core packages should be < 50KB gzipped
✅ Component packages should be < 100KB gzipped
⚠️ Plugin packages should be < 150KB gzipped

…d, and its copy is finally translated (objectstack#4358) Two defects on enable.files record detail pages: 1. Buried placement — RecordDetailView appended RecordAttachmentsPanel AFTER the schema-rendered page tree, whose synthesized default embeds record:discussion as the last main component, so the panel always sat below an ever-growing feed timeline with no metadata knob to move it. buildDefaultPageSchema now emits a footer grid row placing a new record:attachments node to the LEFT of the feed (1/3–2/3 on lg+, stacked attachments-first below). The node is a new app-shell registration wrapping the existing panel via RecordContext; an `attachments` slot + `hideAttachments` option cover slotted pages, and the legacy bottom append survives only as the fallback for authored pages without the node (hasExplicitAttachments). 2. Untranslated copy — the panel's eleven detail.* keys existed only as inline-English defaultValues; no locale bundle carried them. All ten locales now define them. Verified in the browser against a showcase backend: zh console renders 「附件 / 上传 / 暂无附件…」 in the left column with the discussion feed to its right on lg+, and stacks the panel above the feed on mobile. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

… live count badge (objectstack#4358) Rework of the previous commit's side-by-side footer after design review: the narrow attachments card next to a tall feed read as a broken layout. - buildDefaultTabs emits an Attachments tab (record:attachments) between Related and Activity/History for enable.files objects; hideAttachments suppresses it. The footer grid, the attachments slot and toFooterCell are gone — the discussion footer is back to its original shape. - PageTabsRenderer derives the tab badge from a sys_attachment probe scoped to (parent_object, parent_id): the probe wrapper injects the two-key filter the RelatedCountStore shape can't express, while the synthetic relationshipField keeps the cache key unique and the store's existing sys_attachment invalidation (MutationEvent bridge) updates the badge on upload/delete. - Tab label rides the existing KNOWN_LABEL_DICT (→ 附件). Verified in the browser against a showcase backend (authored page assignment temporarily detached, since showcase's demo project page overrides the tabs slot): tab strip renders 详情 / 相关 1 / 附件 1, the panel fills the tab, and the badge reflects a created+deleted sys_attachment row. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

github-actions Bot added package: components plugin tests labels Jul 31, 2026

os-zhuang merged commit c785740 into main Jul 31, 2026
16 checks passed

os-zhuang deleted the fix/attachments-tab-i18n-4358 branch July 31, 2026 12:12

baozhoutao and others added 2 commits July 31, 2026 06:41

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fix(detail): Attachments become a peer tab with a live count badge, and their copy is translated (objectstack#4358) - #3123

fix(detail): Attachments become a peer tab with a live count badge, and their copy is translated (objectstack#4358)#3123
os-zhuang merged 2 commits into
mainfrom
fix/attachments-tab-i18n-4358

baozhoutao commented Jul 31, 2026

Uh oh!

vercel Bot commented Jul 31, 2026

Uh oh!

github-actions Bot commented Jul 31, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

baozhoutao commented Jul 31, 2026

Problem

Fix

Verification

Uh oh!

vercel Bot commented Jul 31, 2026

Uh oh!

github-actions Bot commented Jul 31, 2026

✅ Console Performance Budget

📦 Bundle Size Report

Size Limits

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants