refactor(fields): TextAreaField reads mobile_fullscreen from one source (#3232) by xuyushun441-sys · Pull Request #3244 · objectstack-ai/objectui

xuyushun441-sys · 2026-08-03T07:18:11Z

做了什么

TextAreaField 的全屏入口原本经一条四路 ?? 链决定是否显示,现在收敛为唯一一条:字段元数据上的 mobile_fullscreen。

-  const showFullscreenButton = Boolean(
-    (props as any).mobileFullscreen ??
-    textareaField?.mobile_fullscreen ??
-    (props as any).mobile_fullscreen ??
-    (props as any).schema?.mobile_fullscreen,
-  );
+  const showFullscreenButton = Boolean(textareaField?.mobile_fullscreen);

同时删掉了第 57 行那条只为「把它挡在 DOM spread 之外」而存在的 mobileFullscreen 解构,并把文档注释改成描述真实来源。

为什么这三条读取可以删

复核了 origin/main @ ca58e45,issue 里的四条断言全部成立:

读取源	生产者	结论
① `props.mobileFullscreen`(camelCase)	全仓无人生产 —— 该拼写只出现在本 widget 的读取处和第 57 行的解构	恒 `undefined`,删
② `field.mobile_fullscreen`	`plugin-form/src/ObjectForm.tsx:1049`,由 `ObjectFormSchema.mobile.fullscreenLongText` 推导	唯一活着的,保留
③ `props.mobile_fullscreen`	上游明确剥离:`components/src/renderers/form/form.tsx:266` 的 `stripRegisteredFieldProps()` 把 `mobile_fullscreen` 和 `fullscreen` 从转发给已注册 widget 的 props 里剔除	到不了,删
④ `props.schema.mobile_fullscreen`	与 ② 同一个对象 —— widget 里 `textareaField = field \|\| props.schema` 已经把这对载体解析过了	纯重复,删

所以运行时行为零变化:被删的三条本来就永远是 undefined。

注释里那句「宿主表单传入 mobileFullscreen」从来没有成立过 —— 这正是代价所在:下一个作者照着注释去传一个被静默忽略的 prop,不会收到任何反馈。

明确没有做的事

没有新增「宿主强制全屏」的 prop 覆盖能力。 issue 结尾那句「如果确实需要」是个假设句;今天没有任何宿主需要它,凭空造一个没有生产者的键,恰恰是主令 #12 禁止的同一个错误换个方向犯。真需要时的正确做法写进注释了:在 FieldWidgetComponentProps 上声明一个键、让 form.tsx 停止剥离它、并让某个宿主真的传它。

没有动 packages/components/src/renderers/form/form.tsx。 其中 form.tsx:1761-1763 在内置(未注册) textarea 分支上读 mobile_fullscreen || fullscreen 并渲染它自己的 FullscreenTextarea —— 那是另一条独立的活路径(BUILTIN_FIELD_TYPES 命中 textarea 时走它,不会走到本 widget),本 PR 完全没有触碰,新测试的文件头注释也把这点钉住了,避免下一个人来「顺手统一」。

测试

新增 packages/fields/src/widgets/__tests__/TextAreaField.mobileFullscreen.test.tsx,两组共 6 个用例:

活路径仍然工作(这是本 PR 的回归护栏,不是只断言死路径消失):元数据 flag → 展开按钮出现 → 点击开对话框 → 改草稿 → 点 Done 才回调 onChange;外加 schema 载体(field 缺席时)与「没有 flag 就没有入口」两例。
退役拼写彻底失效:编译期用 @ts-expect-error 钉住 mobileFullscreen / mobile_fullscreen 都不在收紧后的 FieldWidgetComponentProps(FieldWidgetComponentProps 的 [key: string]: any 让每个 widget prop 检查失效 #3221)上;运行时钉住即便无类型宿主硬塞进来,入口也不会复活。

护栏是真的:把实现临时改回 Boolean((props as any).mobileFullscreen) 之后,6 个用例里 4 个立刻转红(含全部三个活路径用例),改回来后恢复全绿。

验证输出:

# 全量 packages/fields
Test Files  39 passed (39)
      Tests  489 passed (489)

# 新文件(verbose)
✓ 元数据 flag 渲染展开入口
✓ 打开全屏对话框并提交编辑后的草稿
✓ 宿主未传 field 时从 schema 读 flag
✓ 元数据未开启时不渲染入口
✓ 退役拼写不在 widget 契约上
✓ 宿主硬传退役拼写时运行时忽略
Test Files  1 passed (1)   Tests  6 passed (6)

# type-check(先 build 了上游 workspace 依赖的 d.ts)
$ pnpm --filter @object-ui/fields type-check
> tsc --noEmit          # 干净通过 —— 同时证明两条 @ts-expect-error 确实各自压住了一个真实报错

# lint
0 errors;两个改动文件均无 warning

Changeset

.changeset/textarea-mobile-fullscreen-single-source.md,patch(未声明 major,符合 AGENTS.md 版本号策略与 changeset-guard)。

依据:AGENTS.md #0.1(消费者侧宽容会固化出第二套事实契约)与主令 #12(拼写分歧在生产者收敛)。收敛之后,写错的键不再有任何读取路径把它悄悄接住 —— 错误从此是响的。

Generated by Claude Code

…ce (#3232) The widget resolved its fullscreen affordance through a four-way `??` chain: a `mobileFullscreen` (camelCase) prop, `field.mobile_fullscreen`, a `mobile_fullscreen` prop, and `schema.mobile_fullscreen`. Three of the four were permanently `undefined`: - `mobileFullscreen` had no producer anywhere in the repo — the only two occurrences of that spelling were this widget's own read and the destructure that kept it off the DOM spread. The doc comment claimed "the host form passes `mobileFullscreen`", so it documented a contract that never held. - `mobile_fullscreen` as a prop cannot arrive: `stripRegisteredFieldProps` (components/src/renderers/form/form.tsx) removes it, and `fullscreen`, from the props forwarded to registered field widgets. - `schema.mobile_fullscreen` restates the object `field || schema` already resolves into `textareaField`. What is left is the one live source: the field metadata flag ObjectForm stamps onto long-text fields from `ObjectFormSchema.mobile.fullscreenLongText`. The doc comment now describes that, names the producer, and records why there is deliberately no host-override prop. No behaviour change. The metadata path is pinned by new tests covering the button, the dialog and the committed edit, so the cleanup cannot have removed the working affordance; the retired spellings are pinned inert at compile time (they are not on the closed `FieldWidgetComponentProps`, #3221) and at runtime. The built-in (unregistered) `textarea` branch of the form renderer, which reads `mobile_fullscreen || fullscreen` off the form-field props and renders its own `FullscreenTextarea`, is a separate live path and is untouched. Per AGENTS.md #0.1 and Prime Directive #12: divergence converges at the producer, not by accumulating tolerance at the consumer. Fixes #3232 Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01NVPjPzmmAJ2Ngtvgg5MSRa

vercel · 2026-08-03T07:18:17Z

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment

Project	Deployment	Actions	Updated (UTC)
objectui	Ignored		Aug 3, 2026 7:18am

github-actions · 2026-08-03T07:21:19Z

✅ Console Performance Budget

Metric	Value	Budget
Main entry (gzip)	28.1 KB	350 KB
Entry file	`index-BoEcRxLi.js`	—
Status	PASS	—

📦 Bundle Size Report

Package	Size	Gzipped
app-shell (index.js)	8.47KB	3.09KB
app-shell (runtime-config.js)	7.42KB	2.32KB
app-shell (types.js)	0.01KB	0.04KB
app-shell (urlParams.js)	7.57KB	2.97KB
auth (AuthContext.js)	0.31KB	0.24KB
auth (AuthGuard.js)	1.17KB	0.53KB
auth (AuthProvider.js)	22.10KB	4.37KB
auth (AuthShell.js)	3.49KB	1.40KB
auth (ForgotPasswordForm.js)	12.12KB	3.41KB
auth (LoginForm.js)	17.86KB	5.29KB
auth (PreviewBanner.js)	0.90KB	0.50KB
auth (RegisterForm.js)	6.43KB	2.09KB
auth (SocialSignInButtons.js)	9.60KB	3.89KB
auth (UserMenu.js)	3.40KB	1.22KB
auth (auth-gate-events.js)	1.29KB	0.66KB
auth (authStyles.js)	5.04KB	1.72KB
auth (createAuthClient.js)	35.76KB	9.11KB
auth (createAuthenticatedFetch.js)	4.37KB	1.69KB
auth (index.js)	2.35KB	1.07KB
auth (org-roles.js)	6.66KB	2.78KB
auth (phone-identifier.js)	1.11KB	0.66KB
auth (types.js)	0.59KB	0.35KB
auth (useAuth.js)	4.91KB	0.87KB
auth (useIsWorkspaceAdmin.js)	1.61KB	0.85KB
collaboration (CommentThread.js)	18.38KB	4.49KB
collaboration (LiveCursors.js)	3.17KB	1.27KB
collaboration (PresenceAvatars.js)	3.65KB	1.42KB
collaboration (PresenceProvider.js)	2.79KB	1.13KB
collaboration (index.js)	1.25KB	0.53KB
collaboration (useCommentSearch.js)	1.98KB	0.88KB
collaboration (useConflictResolution.js)	7.75KB	1.86KB
collaboration (useMentionNotifications.js)	1.81KB	0.68KB
collaboration (usePresence.js)	6.33KB	1.84KB
collaboration (useRealtimeSubscription.js)	7.91KB	2.01KB
components (index.js)	476.12KB	104.47KB
core (index.js)	2.25KB	0.80KB
create-plugin (index.js)	9.28KB	2.98KB
data-objectstack (index.js)	136.23KB	34.75KB
fields (index.js)	223.34KB	54.63KB
i18n (LocalizationContext.js)	1.76KB	0.96KB
i18n (currency.js)	1.22KB	0.64KB
i18n (i18n.js)	4.32KB	1.77KB
i18n (index.js)	2.46KB	0.96KB
i18n (pickLocalized.js)	1.70KB	0.83KB
i18n (provider.js)	5.37KB	1.72KB
i18n (useObjectLabel.js)	26.14KB	6.07KB
i18n (useSafeTranslation.js)	3.26KB	1.44KB
layout (index.js)	37.91KB	10.53KB
mobile (MobileProvider.js)	0.92KB	0.49KB
mobile (ResponsiveContainer.js)	0.94KB	0.38KB
mobile (breakpoints.js)	1.51KB	0.70KB
mobile (createOfflineDataSource.js)	5.61KB	1.74KB
mobile (index.js)	1.50KB	0.62KB
mobile (offlineQueue.js)	3.91KB	1.35KB
mobile (pwa.js)	0.97KB	0.49KB
mobile (serviceWorker.js)	1.48KB	0.62KB
mobile (serviceWorkerSource.js)	3.41KB	1.48KB
mobile (useBreakpoint.js)	1.54KB	0.65KB
mobile (useGesture.js)	6.96KB	1.98KB
mobile (useOfflineSync.js)	1.99KB	0.72KB
mobile (usePullToRefresh.js)	2.53KB	0.85KB
mobile (useResponsive.js)	0.71KB	0.42KB
mobile (useResponsiveConfig.js)	1.36KB	0.63KB
mobile (useSpecGesture.js)	4.05KB	1.53KB
mobile (useTouchTarget.js)	1.01KB	0.54KB
permissions (MePermissionsProvider.js)	8.75KB	3.06KB
permissions (PermissionContext.js)	0.31KB	0.25KB
permissions (PermissionGuard.js)	0.89KB	0.45KB
permissions (PermissionProvider.js)	3.67KB	1.12KB
permissions (evaluator.js)	4.41KB	1.44KB
permissions (index.js)	0.91KB	0.41KB
permissions (store.js)	0.91KB	0.42KB
permissions (useFieldPermissions.js)	1.28KB	0.52KB
permissions (usePermissions.js)	1.55KB	0.71KB
plugin-ai (index.js)	15.71KB	3.79KB
plugin-calendar (index.js)	44.90KB	12.35KB
plugin-charts (index.js)	60.53KB	17.12KB
plugin-chatbot (index.js)	180.09KB	42.72KB
plugin-dashboard (index.js)	111.87KB	28.82KB
plugin-designer (index.js)	210.51KB	42.50KB
plugin-detail (index.js)	230.54KB	56.77KB
plugin-editor (index.js)	2.46KB	1.10KB
plugin-form (index.js)	111.39KB	26.94KB
plugin-gantt (index.js)	162.26KB	39.53KB
plugin-grid (index.js)	185.04KB	49.00KB
plugin-kanban (index.js)	47.82KB	13.18KB
plugin-list (index.js)	104.86KB	25.30KB
plugin-map (index.js)	16.80KB	5.24KB
plugin-markdown (index.js)	13.65KB	4.67KB
plugin-report (index.js)	40.48KB	10.57KB
plugin-timeline (index.js)	25.76KB	7.32KB
plugin-tree (index.js)	8.34KB	2.82KB
plugin-view (index.js)	83.54KB	20.39KB
providers (DataSourceProvider.js)	0.75KB	0.39KB
providers (MetadataProvider.js)	1.37KB	0.59KB
providers (ThemeProvider.js)	1.90KB	0.85KB
providers (UploadProvider.js)	11.71KB	3.53KB
providers (index.js)	0.44KB	0.22KB
providers (types.js)	0.01KB	0.04KB
react-runtime (index.js)	5.67KB	2.37KB
react (LazyPluginLoader.js)	3.77KB	1.33KB
react (SchemaRenderer.js)	19.28KB	6.38KB
react (data-invalidation.js)	5.05KB	2.08KB
react (index.js)	1.02KB	0.55KB
react (spec-input.js)	0.20KB	0.18KB
sdui-parser (codegen.js)	4.09KB	1.74KB
sdui-parser (index.js)	4.47KB	2.03KB
sdui-parser (parse.js)	10.04KB	2.82KB
sdui-parser (types.js)	0.29KB	0.24KB
sdui-parser (validate.js)	4.69KB	1.48KB
types (ai.js)	0.20KB	0.17KB
types (api-types.js)	0.20KB	0.18KB
types (app.js)	2.87KB	0.99KB
types (base.js)	0.20KB	0.18KB
types (blocks.js)	0.20KB	0.18KB
types (complex.js)	0.20KB	0.18KB
types (crud.js)	0.20KB	0.18KB
types (data-display.js)	0.20KB	0.18KB
types (data-protocol.js)	0.20KB	0.19KB
types (data.js)	0.20KB	0.18KB
types (designer.js)	1.87KB	0.85KB
types (disclosure.js)	0.20KB	0.18KB
types (error-code.js)	1.54KB	0.88KB
types (feedback.js)	0.20KB	0.18KB
types (field-types.js)	0.20KB	0.18KB
types (form.js)	0.20KB	0.18KB
types (http-retry.js)	4.32KB	2.02KB
types (index.js)	2.46KB	1.21KB
types (layout.js)	0.20KB	0.18KB
types (managed-by.js)	0.19KB	0.18KB
types (mobile.js)	0.20KB	0.18KB
types (navigation.js)	0.20KB	0.18KB
types (objectql.js)	0.20KB	0.18KB
types (overlay.js)	0.20KB	0.18KB
types (permissions.js)	0.20KB	0.18KB
types (plugin-scope.js)	0.20KB	0.18KB
types (record-components.js)	0.20KB	0.19KB
types (record-semantics.js)	1.28KB	0.67KB
types (registry.js)	0.20KB	0.18KB
types (reports.js)	0.20KB	0.18KB
types (spec-report.js)	5.05KB	1.93KB
types (system-fields.js)	3.33KB	1.54KB
types (theme.js)	0.20KB	0.18KB
types (ui-action.js)	3.40KB	1.71KB
types (views.js)	0.20KB	0.18KB
types (widget.js)	0.20KB	0.18KB

Size Limits

✅ Core packages should be < 50KB gzipped
✅ Component packages should be < 100KB gzipped
⚠️ Plugin packages should be < 150KB gzipped

github-actions Bot added the tests label Aug 3, 2026

xuyushun441-sys mentioned this pull request Aug 3, 2026

ObjectForm 的 mobile.fullscreenLongText 到不了自动生成字段的 TextAreaField:flag 写在 FormField 上,form.tsx 转发的却是 field.field #3245

Open

xuyushun441-sys marked this pull request as ready for review August 3, 2026 07:25

xuyushun441-sys added this pull request to the merge queue Aug 3, 2026

Merged via the queue into main with commit a321fa4 Aug 3, 2026
17 checks passed

xuyushun441-sys deleted the claude/issue-3232-textarea-mobilefullscreen branch August 3, 2026 07:25

xuyushun441-sys mentioned this pull request Aug 3, 2026

TextAreaField 读取的 mobileFullscreen prop 全仓无人生产,注释却说"宿主表单传入" #3232

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

refactor(fields): TextAreaField reads mobile_fullscreen from one source (#3232) - #3244

refactor(fields): TextAreaField reads mobile_fullscreen from one source (#3232)#3244
xuyushun441-sys merged 1 commit into
mainfrom
claude/issue-3232-textarea-mobilefullscreen

xuyushun441-sys commented Aug 3, 2026

Uh oh!

vercel Bot commented Aug 3, 2026

Uh oh!

github-actions Bot commented Aug 3, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

xuyushun441-sys commented Aug 3, 2026

做了什么

为什么这三条读取可以删

明确没有做的事

测试

Changeset

Uh oh!

vercel Bot commented Aug 3, 2026

Uh oh!

github-actions Bot commented Aug 3, 2026

✅ Console Performance Budget

📦 Bundle Size Report

Size Limits

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants