Fix flaky test timeout in ObjectForm MSW test - #357
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Added explicit timeout parameter to waitFor() call in first test to match the second test. This ensures the test has sufficient time to complete in CI environments. Co-authored-by: hotlong <50353452+hotlong@users.noreply.github.com>
Copilot stopped work on behalf of
hotlong due to an error
February 2, 2026 14:35
Contributor
|
@copilot 继续 |
Contributor
Author
Copilot
AI
changed the title
[WIP] Update action workflow settings for better performance
Fix flaky test timeout in ObjectForm MSW test
Feb 2, 2026
xuyushun441-sys
marked this pull request as ready for review
February 2, 2026 15:00
Contributor
📦 Bundle Size Report
Size Limits
|
Contributor
|
✅ All checks passed!
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a flaky test in
@object-ui/plugin-formthat was failing intermittently in CI environments due to insufficient timeout for asynchronous operations.Problem
The test "loads schema and renders form fields" in
ObjectForm.msw.test.tsxwas timing out in CI environments. The test was using the default 1000ms timeout forwaitFor(), which was insufficient when network mocks took longer to respond in CI environments. Meanwhile, the second test "loads record data in edit mode" explicitly specified a 2000ms timeout and passed consistently.Solution
Added explicit
{ timeout: 2000 }parameter to the first test'swaitFor()call to match the second test, ensuring consistent behavior across local and CI environments.Changes Made
waitFor()in the first test ofObjectForm.msw.test.tsxTesting
@object-ui/plugin-formpass locallyThe fix is minimal and surgical, changing only the test configuration without altering any production code or functionality.
Original prompt
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.