Fix ES module directory import in @object-ui/core - #367
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Co-authored-by: hotlong <50353452+hotlong@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Update action run details for better clarity
Fix ES module directory import in @object-ui/core
Feb 3, 2026
Contributor
📦 Bundle Size Report
Size Limits
|
Contributor
|
✅ All checks passed!
|
Collaborator
|
fix ci test |
Collaborator
@copilot |
Contributor
Author
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a CI build failure caused by an ES module directory import issue in @object-ui/core. The package uses "type": "module" in its package.json, which requires explicit file extensions in imports. The import statement import type { SchemaNode } from '../types' was causing TypeScript to emit a directory import reference in the generated declaration files, which is not supported by ES modules.
Changes:
- Updated the import statement in
Registry.tsto use explicit file path with.jsextension:from '../types/index.js'
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CI failing with
Error: Directory import '.../dist/types' is not supported resolving ES modules.Root Cause
TypeScript import without explicit extension:
When compiled to
.d.ts, this creates a directory import reference. ES modules ("type": "module") require explicit file paths.Changes
Updated
packages/core/src/registry/Registry.ts:TypeScript now emits correct file reference in generated declaration files.
Original prompt
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.