-
Notifications
You must be signed in to change notification settings - Fork 2
fix: wire ViewConfigPanel draft to ObjectView for real-time preview + inline filter/sort/column editors #677
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 5 commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
3150df6
Initial plan
Copilot e637678
fix: make ViewConfigPanel draft changes reactive in ObjectView main view
Copilot 491f4b2
docs: update roadmap to reflect real-time draft preview capability
Copilot 64c532b
feat: replace clickable rows with inline FilterBuilder, SortBuilder, …
Copilot bcf39e1
fix: resolve TypeScript build errors in ViewTabBar.tsx
Copilot b00dc61
fix: address all review comments — spec filter bridge, type normaliza…
Copilot 13cdee3
Merge branch 'main' into copilot/fix-object-view-realtime-response
hotlong File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
views={views.map(...)}recreates the active view object on every parent render (via{ ...v, ...viewDraft }), even whenviewDrafthasn't changed.@object-ui/plugin-view'sObjectVieweffect depends onactiveView, so this can trigger unnecessary data refetches / state resets. Consider memoizing the mergedviewsarray (and reusing the merged active view object) withuseMemokeyed on[views, activeViewId, viewDraft]to keep references stable when nothing changed.