-
Notifications
You must be signed in to change notification settings - Fork 2
Console integration: App Creation Wizard routes, entry points, and tests #761
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
fe7722e
d649d84
2ab8f92
de674d1
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -30,6 +30,10 @@ const ReportView = lazy(() => import('./components/ReportView').then(m => ({ def | |||||
| const ViewDesignerPage = lazy(() => import('./components/ViewDesignerPage').then(m => ({ default: m.ViewDesignerPage }))); | ||||||
| const SearchResultsPage = lazy(() => import('./components/SearchResultsPage').then(m => ({ default: m.SearchResultsPage }))); | ||||||
|
|
||||||
| // App Creation / Edit Pages (lazy — only needed during app management) | ||||||
| const CreateAppPage = lazy(() => import('./pages/CreateAppPage').then(m => ({ default: m.CreateAppPage }))); | ||||||
| const EditAppPage = lazy(() => import('./pages/EditAppPage').then(m => ({ default: m.EditAppPage }))); | ||||||
|
|
||||||
| // Auth Pages (lazy — only needed before login) | ||||||
| const LoginPage = lazy(() => import('./pages/LoginPage').then(m => ({ default: m.LoginPage }))); | ||||||
| const RegisterPage = lazy(() => import('./pages/RegisterPage').then(m => ({ default: m.RegisterPage }))); | ||||||
|
|
@@ -246,14 +250,37 @@ export function AppContent() { | |||||
| ); | ||||||
|
|
||||||
| if (!dataSource || metadataLoading) return <LoadingScreen />; | ||||||
| if (!activeApp) return ( | ||||||
|
|
||||||
| // Allow create-app route even when no active app exists | ||||||
| const isCreateAppRoute = location.pathname.endsWith('/create-app'); | ||||||
|
||||||
| const isCreateAppRoute = location.pathname.endsWith('/create-app'); | |
| const isCreateAppRoute = /\/create-app\/?$/.test(location.pathname); |
Copilot
AI
Feb 23, 2026
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
New behavior introduced here (empty-state "Create Your First App" CTA + create-app route bypass when there’s no active app) isn’t covered by the added integration tests. Add a test case with apps: [] that asserts: (1) the empty state renders the CTA, (2) clicking it navigates to /apps/_new/create-app, and (3) the wizard renders in the minimal layout path.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These checklist items describe routes as
/create-appand/edit-app/:appName, but the actual console routes are nested under/apps/:appName/…(e.g./apps/:appName/create-app,/apps/:appName/edit-app/:editAppName). Update the roadmap entries to match the real paths so future readers don’t follow incorrect routes.