From d55f2b04f3b431fa8474fb1019dc5a0a2590cf2f Mon Sep 17 00:00:00 2001 From: "copilot-swe-agent[bot]" <198982749+Copilot@users.noreply.github.com> Date: Fri, 27 Feb 2026 06:32:39 +0000 Subject: [PATCH 1/4] Initial plan From e4d1d50df9b99d23dc2420053c6ad9b41aecf898 Mon Sep 17 00:00:00 2001 From: "copilot-swe-agent[bot]" <198982749+Copilot@users.noreply.github.com> Date: Fri, 27 Feb 2026 07:05:46 +0000 Subject: [PATCH 2/4] Fix navigation modes: explicit onNavigate handling + PluginObjectView split/popover support Co-authored-by: hotlong <50353452+hotlong@users.noreply.github.com> --- apps/console/src/components/ObjectView.tsx | 12 +++-- packages/plugin-view/src/ObjectView.tsx | 60 ++++++++++++++++++++++ 2 files changed, 68 insertions(+), 4 deletions(-) diff --git a/apps/console/src/components/ObjectView.tsx b/apps/console/src/components/ObjectView.tsx index 54767626f4..2fc12b92ed 100644 --- a/apps/console/src/components/ObjectView.tsx +++ b/apps/console/src/components/ObjectView.tsx @@ -433,10 +433,14 @@ export function ObjectView({ dataSource, objects, onEdit, onRowClick }: any) { return; } // page / view mode — navigate to record detail page - if (viewId) { - navigate(`../../record/${String(recordId)}`, { relative: 'path' }); - } else { - navigate(`record/${String(recordId)}`); + // Handles action === 'view' (from useNavigationOverlay page mode) and + // default fallthrough for any unrecognised action + if (action === 'view' || !action || action === 'page') { + if (viewId) { + navigate(`../../record/${String(recordId)}`, { relative: 'path' }); + } else { + navigate(`record/${String(recordId)}`); + } } }, }); diff --git a/packages/plugin-view/src/ObjectView.tsx b/packages/plugin-view/src/ObjectView.tsx index d0bdd101b5..16c5db7699 100644 --- a/packages/plugin-view/src/ObjectView.tsx +++ b/packages/plugin-view/src/ObjectView.tsx @@ -49,6 +49,7 @@ import { DrawerHeader, DrawerTitle, DrawerDescription, + NavigationOverlay, Button, Tabs, TabsList, @@ -974,8 +975,52 @@ export const ObjectView: React.FC = ({ // Determine which form container to render const formLayout = navigationConfig?.mode === 'modal' ? 'modal' : navigationConfig?.mode === 'drawer' ? 'drawer' + : navigationConfig?.mode === 'split' ? 'split' + : navigationConfig?.mode === 'popover' ? 'popover' : layout; + // Build the record detail content for NavigationOverlay (split/popover modes) + const renderOverlayDetail = (record: Record) => ( +
+ +
+ ); + + // For split mode, wrap content inside NavigationOverlay with mainContent + if (formLayout === 'split') { + const objectLabel = (objectSchema?.label as string) || schema.objectName; + return ( +
+ {(schema.title || schema.description) && ( +
+ {schema.title &&

{schema.title}

} + {schema.description &&

{schema.description}

} +
+ )} +
{renderToolbar()}
+
+ {isFormOpen && selectedRecord ? ( + { if (!open) handleFormCancel(); }} + width={navigationConfig?.width} + isOverlay={true} + title={`${objectLabel} Detail`} + mainContent={
{renderContent()}
} + > + {renderOverlayDetail} + + ) : ( + renderContent() + )} +
+
+ ); + } + return (
{/* Title and description */} @@ -1003,6 +1048,21 @@ export const ObjectView: React.FC = ({ {/* Form (drawer or modal) */} {formLayout === 'drawer' && renderDrawerForm()} {formLayout === 'modal' && renderModalForm()} + {/* Popover mode — uses NavigationOverlay Dialog fallback (no popoverTrigger) */} + {formLayout === 'popover' && isFormOpen && selectedRecord && ( + { if (!open) handleFormCancel(); }} + width={navigationConfig?.width} + isOverlay={true} + title={getFormTitle()} + > + {renderOverlayDetail} + + )}
); }; From 88716d98a9807d1e6b4441ac9557d9c0506532a0 Mon Sep 17 00:00:00 2001 From: "copilot-swe-agent[bot]" <198982749+Copilot@users.noreply.github.com> Date: Fri, 27 Feb 2026 07:08:07 +0000 Subject: [PATCH 3/4] Update tests and ROADMAP for navigation mode fixes Co-authored-by: hotlong <50353452+hotlong@users.noreply.github.com> --- ROADMAP.md | 15 +++++++++++ .../src/__tests__/ObjectView.test.tsx | 27 +++++++++++++++++-- 2 files changed, 40 insertions(+), 2 deletions(-) diff --git a/ROADMAP.md b/ROADMAP.md index 5e84e5cbd4..294dd90df7 100644 --- a/ROADMAP.md +++ b/ROADMAP.md @@ -1050,6 +1050,21 @@ The `FlowDesigner` is a canvas-based flow editor that bridges the gap between th **Tests:** All 32 ObjectView tests and 29 useNavigationOverlay tests pass. +### ListView Multi-Navigation Mode Support — split/popover/page/new_window (February 2026) + +**Root Cause:** While `drawer`/`modal` modes worked in the Console ObjectView, the remaining 4 navigation modes had gaps: +1. Console's `onNavigate` callback relied on implicit fallthrough for `view` action (page mode) — not explicit. +2. `PluginObjectView`'s `formLayout` only mapped `drawer`/`modal` modes; `split`/`popover` fell through to the default layout (`drawer`), rendering the wrong overlay type. +3. `PluginObjectView` lacked `NavigationOverlay` integration for `split` (resizable side-by-side panels) and `popover` (compact dialog preview). + +**Fix:** +- Console `onNavigate` now explicitly checks for `action === 'view'` (page mode) alongside the existing `'new_window'` check. +- `PluginObjectView` `formLayout` now includes `split` and `popover` branches. +- `PluginObjectView` imports and renders `NavigationOverlay` from `@object-ui/components` for both `split` mode (with `mainContent` wrapping the grid) and `popover` mode (Dialog fallback when no `popoverTrigger`). +- Split mode close button properly resets form state via `handleFormCancel`. + +**Tests:** Updated split/popover tests to verify `NavigationOverlay` rendering (close panel button for split, dialog role for popover). Added split close-and-return test. All 29 PluginObjectView tests and 37 Console ObjectView tests pass. + ### ListView Grouping Mode Empty Rows (February 2026) **Root Cause:** When grouping is enabled in list view, `buildGroupTableSchema` in `ObjectGrid.tsx` sets `pagination: false` but inherits `pageSize: 10` from the parent schema. The `DataTableRenderer` filler row logic (`Array.from({ length: Math.max(0, pageSize - paginatedData.length) })`) pads each group table with empty rows up to `pageSize`, creating many blank lines. diff --git a/packages/plugin-view/src/__tests__/ObjectView.test.tsx b/packages/plugin-view/src/__tests__/ObjectView.test.tsx index 72b86ad885..f1b279e158 100644 --- a/packages/plugin-view/src/__tests__/ObjectView.test.tsx +++ b/packages/plugin-view/src/__tests__/ObjectView.test.tsx @@ -300,8 +300,9 @@ describe('ObjectView', () => { fireEvent.click(screen.getByTestId('grid-row')); - // Split mode should trigger form display in view mode + // Split mode renders NavigationOverlay with split panels including a close button expect(screen.getByTestId('object-form')).toBeDefined(); + expect(screen.getByLabelText('Close panel')).toBeDefined(); }); it('should open form in view mode when popover navigation mode is clicked', () => { @@ -315,8 +316,30 @@ describe('ObjectView', () => { fireEvent.click(screen.getByTestId('grid-row')); - // Popover mode should trigger form display in view mode + // Popover mode renders NavigationOverlay Dialog fallback (no popoverTrigger) expect(screen.getByTestId('object-form')).toBeDefined(); + expect(screen.getByRole('dialog')).toBeDefined(); + }); + + it('should close split panel and return to normal view', () => { + const schema: ObjectViewSchema = { + type: 'object-view', + objectName: 'contacts', + navigation: { mode: 'split' }, + }; + + render(); + + // Open split panel + fireEvent.click(screen.getByTestId('grid-row')); + expect(screen.getByLabelText('Close panel')).toBeDefined(); + + // Close split panel + fireEvent.click(screen.getByLabelText('Close panel')); + + // Form should be gone, grid should remain + expect(screen.queryByLabelText('Close panel')).toBeNull(); + expect(screen.getByTestId('object-grid')).toBeDefined(); }); }); From 968eb4f0413c94003f58b53f4c830081c4e3b854 Mon Sep 17 00:00:00 2001 From: "copilot-swe-agent[bot]" <198982749+Copilot@users.noreply.github.com> Date: Fri, 27 Feb 2026 07:22:01 +0000 Subject: [PATCH 4/4] Address code review: extract shared handleOverlayOpenChange callback Co-authored-by: hotlong <50353452+hotlong@users.noreply.github.com> --- packages/plugin-view/src/ObjectView.tsx | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/packages/plugin-view/src/ObjectView.tsx b/packages/plugin-view/src/ObjectView.tsx index 16c5db7699..4d4e86a068 100644 --- a/packages/plugin-view/src/ObjectView.tsx +++ b/packages/plugin-view/src/ObjectView.tsx @@ -986,6 +986,11 @@ export const ObjectView: React.FC = ({ ); + // Shared handler for NavigationOverlay onOpenChange — close form when overlay is dismissed + const handleOverlayOpenChange = useCallback((open: boolean) => { + if (!open) handleFormCancel(); + }, [handleFormCancel]); + // For split mode, wrap content inside NavigationOverlay with mainContent if (formLayout === 'split') { const objectLabel = (objectSchema?.label as string) || schema.objectName; @@ -1005,7 +1010,7 @@ export const ObjectView: React.FC = ({ selectedRecord={selectedRecord} mode="split" close={handleFormCancel} - setIsOpen={(open: boolean) => { if (!open) handleFormCancel(); }} + setIsOpen={handleOverlayOpenChange} width={navigationConfig?.width} isOverlay={true} title={`${objectLabel} Detail`} @@ -1055,7 +1060,7 @@ export const ObjectView: React.FC = ({ selectedRecord={selectedRecord} mode="popover" close={handleFormCancel} - setIsOpen={(open: boolean) => { if (!open) handleFormCancel(); }} + setIsOpen={handleOverlayOpenChange} width={navigationConfig?.width} isOverlay={true} title={getFormTitle()}