Address code review feedback - improve type safety and error handling

Co-authored-by: hotlong <50353452+hotlong@users.noreply.github.com>

Author: Copilot

src/adapter/index.ts

@@ -28,7 +28,7 @@ export interface ObjectQLAdapterConfig {
 export function createObjectQLAdapter(config: ObjectQLAdapterConfig) {
   const { ql, debugLogs = false } = config;
 
-  return (options: BetterAuthOptions) => {
+  return (_options: BetterAuthOptions) => {
     // Model name mapping (better-auth uses lowercase model names)
     const modelMap: Record<string, string> = {
       user: 'User',

src/client/hooks.ts

@@ -85,8 +85,13 @@ export type ObjectStackClientSession = {
 export function usePermissions() {
   const { data: session, isPending } = useSession();
 
+  // Safely extract permissions, defaulting to undefined if not present
+  const permissions = session?.user && 'permissions' in session.user 
+    ? (session.user as any).permissions 
+    : undefined;
+  
   return {
-    permissions: (session?.user as any)?.permissions as string[] | Record<string, boolean> | null | undefined,
+    permissions,
     isPending,
     isAuthenticated: !!session,
   };

src/index.ts

@@ -101,7 +101,10 @@ export function createAuthPlugin(config: AuthPluginConfig = {}): ObjectStackPlug
         // Better-Auth exposes a handler for all auth routes
         // The handler expects a Web Request object
         context.app.all('/api/auth/*', async (req: any) => {
-          return authServer!.handler(req);
+          if (!authServer) {
+            throw new Error('Auth server not initialized');
+          }
+          return authServer.handler(req);
         });
 
         console.log('[Auth Plugin] Authentication routes registered at /api/auth/*');

src/server/index.ts

@@ -84,7 +84,7 @@ export function createAuthServer(config: ObjectStackAuthServerConfig) {
   }
 
   // Add social providers if configured
-  if (socialProviders && typeof socialProviders === 'object' && Object.keys(socialProviders).length > 0) {
+  if (socialProviders && Object.keys(socialProviders).length > 0) {
     authOptions.socialProviders = socialProviders as BetterAuthOptions['socialProviders'];
   }