Skip to content

Commit d028e84

Browse files
committed
fix: add final modifier to 6 velocity test classes; fix TESTING.md example method name
All test classes must be final per plan conventions. Fix example method name in TESTING.md to reference an actual test method.
1 parent 58c4555 commit d028e84

7 files changed

Lines changed: 7 additions & 7 deletions

File tree

TESTING.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ the test suite covers the core scripting engine, security, networking primitives
1818
./gradlew :core:test --tests "dev.objz.commandbridge.security.AuthServiceTest"
1919

2020
# run a single test method
21-
./gradlew :core:test --tests "dev.objz.commandbridge.security.AuthServiceTest.rejectsExpiredToken"
21+
./gradlew :core:test --tests "dev.objz.commandbridge.security.AuthServiceTest.signValidInputReturnsDeterministicOutput"
2222

2323
# run checkstyle + all tests (what CI runs)
2424
./gradlew check

velocity/src/test/java/dev/objz/commandbridge/velocity/dispatch/CommandDispatcherTest.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@
2323
* method via reflection, verifying permission set construction from script names and
2424
* command strings.
2525
*/
26-
class CommandDispatcherTest {
26+
final class CommandDispatcherTest {
2727

2828
private static CommandDispatcher dispatcher;
2929
private static Method buildOPPermissions;

velocity/src/test/java/dev/objz/commandbridge/velocity/dispatch/stage/ArgumentMappingStageTest.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@
2929
* Tests for {@link ArgumentMappingStage} — verifies argument mapping from invoked
3030
* arguments to script-defined argument definitions.
3131
*/
32-
class ArgumentMappingStageTest {
32+
final class ArgumentMappingStageTest {
3333

3434
@BeforeAll
3535
static void setUp() {

velocity/src/test/java/dev/objz/commandbridge/velocity/dispatch/stage/PermissionCheckStageTest.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@
2727
* Tests for {@link PermissionCheckStage} — verifies permission gating, disabled
2828
* permissions bypass, and silent mode behavior.
2929
*/
30-
class PermissionCheckStageTest {
30+
final class PermissionCheckStageTest {
3131

3232
private static final String SCRIPT_NAME = "lobby";
3333
private static final String PERM_NODE = "commandbridge.command." + SCRIPT_NAME;

velocity/src/test/java/dev/objz/commandbridge/velocity/dispatch/stage/ScriptResolutionStageTest.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@
2929
* Tests for {@link ScriptResolutionStage} — verifies script lookup by exact name,
3030
* alias, and case-insensitive matching.
3131
*/
32-
class ScriptResolutionStageTest {
32+
final class ScriptResolutionStageTest {
3333

3434
@BeforeAll
3535
static void setUp() {

velocity/src/test/java/dev/objz/commandbridge/velocity/util/CooldownManagerTest.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@
1313
* Tests for {@link CooldownManager} — verifies cooldown setting, checking,
1414
* remaining duration, zero-duration handling, and per-player/per-script isolation.
1515
*/
16-
class CooldownManagerTest {
16+
final class CooldownManagerTest {
1717

1818
private CooldownManager manager;
1919

velocity/src/test/java/dev/objz/commandbridge/velocity/util/PlayerTrackerTest.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@
1919
* Tests for {@link PlayerTracker} — verifies player add/remove, update with join
2020
* listener firing, unknown player/client lookups, and listener exception isolation.
2121
*/
22-
class PlayerTrackerTest {
22+
final class PlayerTrackerTest {
2323

2424
private PlayerTracker tracker;
2525

0 commit comments

Comments
 (0)