Fix: Handle storybook V8 fetch call#547
Open
bassem-i wants to merge 2 commits into
Open
Conversation
Author
|
I've found another approach that keeps the file-based url access: #546 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We are currently migrating our Storybook version from 7 to 8. We've noticed that:
A
fetchcall in Storybook V8 breaks loki's aws-lambda-renderer.Storybook V8 initialization calls
getStoryIndexFromServerfunction which tries to load a file calledindex.json(A json with all the stories loaded in the storybook build) usingfetch. This breaks Loki's aws-lambda-renderer because it depends on file-basedfile://TMP_FOLDER/iframe.html?id=STORY_IDaccess. (File-based access doesn't supportfetch).This PR fixes the
failed to fetcherror by handling the fetch call without actually fetching.readFileSyncto load the content ofindex.jsonfile.fetchfunction implementation as follows:index.json, it returns the stories list.