chore: Stabilize CI fixture resolution and DateTime assertions

Author: seebeen

tests/Integration/Support/IntegrationConfig.php

@@ -28,6 +28,7 @@ final class IntegrationConfig
     ];
 
     private const DEFAULT_CLIENT_CERT_CANDIDATES = [
+        'tests/fixtures/dummy-client-cert.pem',
         'tests/fixtures/oblak.pem',
         'tests/fixtures/client.pem',
         'tests/Fixtures/client.pem',
@@ -92,9 +93,9 @@ public static function ensureReadyOrFail(): void
     {
         self::ensureEnvOrFail('RNIDS_EPP_USERNAME');
         self::ensureEnvOrFail('RNIDS_EPP_PASSWORD');
+        self::port();
         self::ensureFileOrFail(self::clientCertificatePath(), 'RNIDS client certificate');
         self::ensureFileOrFail(self::caCertificatePath(), 'RNIDS CA certificate');
-        self::port();
     }
 
     public static function liveReadinessFailureReason(): ?string
@@ -104,9 +105,11 @@ public static function liveReadinessFailureReason(): ?string
         $port = self::DEFAULT_PORT;
 
         foreach ([ 'RNIDS_EPP_USERNAME', 'RNIDS_EPP_PASSWORD' ] as $requiredEnv) {
-            if (null === self::nonEmptyEnvOrNull($requiredEnv)) {
-                $issues[] = \sprintf('missing %s', $requiredEnv);
+            if (null !== self::nonEmptyEnvOrNull($requiredEnv)) {
+                continue;
             }
+
+            $issues[] = \sprintf('missing %s', $requiredEnv);
         }
 
         try {
@@ -370,7 +373,10 @@ private static function ensureEnvOrFail(string $name): void
 
         if (!\is_string($value) || '' === \trim($value)) {
             throw new \RuntimeException(
-                \sprintf('Missing required environment variable "%s" for RNIDS live integration tests.', $name),
+                \sprintf(
+                    'Missing required environment variable "%s" for RNIDS live integration tests.',
+                    $name,
+                ),
             );
         }
     }
@@ -413,13 +419,17 @@ private static function port(): int
         }
 
         if (!\preg_match('/^\d+$/', $port)) {
-            throw new \RuntimeException('Environment variable "RNIDS_EPP_PORT" must be an integer between 1 and 65535.');
+            throw new \RuntimeException(
+                'Environment variable "RNIDS_EPP_PORT" must be an integer between 1 and 65535.',
+            );
         }
 
         $parsedPort = (int) $port;
 
         if ($parsedPort < 1 || $parsedPort > 65535) {
-            throw new \RuntimeException('Environment variable "RNIDS_EPP_PORT" must be an integer between 1 and 65535.');
+            throw new \RuntimeException(
+                'Environment variable "RNIDS_EPP_PORT" must be an integer between 1 and 65535.',
+            );
         }
 
         return $parsedPort;
@@ -436,7 +446,7 @@ private static function isHostResolvable(string $host): bool
             return false;
         }
 
-        if (\filter_var($host, \FILTER_VALIDATE_IP) !== false) {
+        if (false !== \filter_var($host, \FILTER_VALIDATE_IP)) {
             return true;
         }
 
@@ -446,7 +456,9 @@ private static function isHostResolvable(string $host): bool
     private static function isTcpEndpointReachable(string $host, int $port, float $timeoutSeconds): bool
     {
         $flags = \STREAM_CLIENT_CONNECT;
-        $context = \stream_context_create([ 'ssl' => [ 'verify_peer' => false, 'verify_peer_name' => false ] ]);
+        $context = \stream_context_create(
+            [ 'ssl' => [ 'verify_peer' => false, 'verify_peer_name' => false ] ],
+        );
         $socket = @\stream_socket_client(
             \sprintf('tcp://%s:%d', $host, $port),
             $errorCode,

tests/Unit/Domain/DomainResponseMapperTest.php

@@ -77,7 +77,7 @@ public function testMapMutationResponses(): void
         $mapper = new DomainResponseMapper();
         $metadata = new ResponseMetadata(1000, 'ok', 'CL-1', 'SV-1');
 
-        self::assertSame([
+        self::assertEquals([
             'createDate' => new \DateTimeImmutable('2024-01-01T00:00:00Z'),
             'expirationDate' => new \DateTimeImmutable('2025-01-01T00:00:00Z'),
             'name' => 'example.rs',
@@ -90,14 +90,14 @@ public function testMapMutationResponses(): void
             ),
         ));
 
-        self::assertSame([
+        self::assertEquals([
             'expirationDate' => new \DateTimeImmutable('2026-01-01T00:00:00Z'),
             'name' => 'example.rs',
         ], $mapper->mapRenewResponse(
             new DomainRenewResponse($metadata, 'example.rs', new \DateTimeImmutable('2026-01-01T00:00:00Z')),
         ));
 
-        self::assertSame([
+        self::assertEquals([
             'actionClientId' => 'ACT',
             'actionDate' => new \DateTimeImmutable('2025-01-01T00:00:00Z'),
             'expirationDate' => new \DateTimeImmutable('2026-01-01T00:00:00Z'),

tests/Unit/Host/HostResponseMapperTest.php

@@ -58,7 +58,7 @@ public function testMapInfoAndCreateResponses(): void
         self::assertSame('ok', $mappedInfo['statuses'][0]);
         self::assertSame('192.0.2.1', $mappedInfo['ipv4'][0]);
 
-        self::assertSame([
+        self::assertEquals([
             'createDate' => new \DateTimeImmutable('2026-02-01T00:00:00.0Z'),
             'name' => 'ns1.example.rs',
         ], $mapper->mapCreateResponse(