Skip to content

Fixes #3521 Removes incorrect partonomy for 'ovarian cortex'#3705

Merged
aleixpuigb merged 1 commit into
masterfrom
3521_ovarian_cortex
May 8, 2026
Merged

Fixes #3521 Removes incorrect partonomy for 'ovarian cortex'#3705
aleixpuigb merged 1 commit into
masterfrom
3521_ovarian_cortex

Conversation

@aleixpuigb
Copy link
Copy Markdown
Collaborator

Fixes #3521 Removes incorrect partonomy for 'ovarian cortex'

Fixes #3521 Removes incorrect partonomy for 'ovarian cortex'
@aleixpuigb aleixpuigb requested a review from Copilot May 8, 2026 09:57
@aleixpuigb aleixpuigb self-assigned this May 8, 2026
@ai4c-agent
Copy link
Copy Markdown

ai4c-agent Bot commented May 8, 2026

Claude finished @aleixpuigb's task in 1m 59s —— View job


PR Review: Fixes #3521 — Removes incorrect partonomy for 'ovarian cortex'

Tasks

  • Gather context (issue, PR diff)
  • Review ontology changes for correctness
  • Verify hierarchy and parent consistency
  • Check OBO/ODK conventions
  • Submit review

Review Summary

Checklist

  • Hierarchy and parents are consistent
  • Definitions and supporting references look adequate
  • Obsolete or replacement handling is safe (N/A)
  • OBO and ODK conventions appear preserved
  • No obvious CI, auth, or workflow regression

This PR correctly addresses the inverted partonomy from issue #3521. The fix is anatomically sound and the changes are minimal and well-scoped.

Changes reviewed (UBERON:0013191 ovarian cortex):

  1. Removal of incorrect relationship — The removed line relationship: part_of UBERON:0006960 ! ovary stroma had the cortex as part of the stroma, which is anatomically backwards. NCIT confirms: Stroma of the Ovarian Cortex (NCIT:C33638) is part_of Ovarian Cortex (NCIT:C33243). Simple removal (rather than reversal) is correct because UBERON:0006960 ovary stroma spans the whole ovary including the medulla, so making it part_of ovarian cortex would be equally wrong.

  2. Definition text fix — "The layer of the ovarian stroma lying immediately beneath..." → "The layer of the ovary lying immediately beneath..." — anatomically correct; the cortex is a compartment of the ovary, not of the stroma.

  3. Added PMIDs — Six PMIDs added as definition xrefs, improving the evidence base.

  4. Logical axioms intactintersection_of: UBERON:0001851 ! cortex and intersection_of: part_of UBERON:0000992 ! ovary are preserved, correctly placing the cortex within the ovary.

Minor suggestions (non-blocking):

🔵 SUGGESTION: A term_tracker_item linking back to issue #3521 could be added per project convention.

🔵 SUGGESTION: Contributor attribution (relationship: dc-contributor + property_value: dcterms-date) would follow best practice for provenance tracking on modified terms.

Verdict: Approved

Copy link
Copy Markdown

@ai4c-agent ai4c-agent Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Review: Fixes #3521 — Removes incorrect partonomy for 'ovarian cortex'

Checklist

  • Hierarchy and parents are consistent
  • Definitions and supporting references look adequate
  • Obsolete or replacement handling is safe (N/A)
  • OBO and ODK conventions appear preserved
  • No obvious CI, auth, or workflow regression

This PR correctly addresses the inverted partonomy identified in issue #3521. The fix is anatomically sound and the changes are minimal and well-scoped.

Changes reviewed ( ovarian cortex):

  1. Removal of incorrect relationship (line removed: relationship: part_of UBERON:0006960 ! ovary stroma) — The old assertion had the cortex as part of the stroma, which is anatomically backwards. The NCIT mapping confirms: Stroma of the Ovarian Cortex (NCIT:C33638) is part_of Ovarian Cortex (NCIT:C33243), not the other way around. Simple removal is the correct fix (rather than reversal) because UBERON:0006960 ovary stroma spans the entire ovary, including the medulla, so making it part_of ovarian cortex would be equally wrong.

  2. Definition text fix — "The layer of the ovarian stroma lying immediately beneath..." → "The layer of the ovary lying immediately beneath...". Correct: the cortex is a compartment of the ovary, not a compartment of the stroma.

  3. Added PMIDs — Six PMIDs added as definition xrefs (17999378, 22666170, 32716007, 36191605, 36721914, 41256733), improving the evidence base.

  4. Logical axioms intact — The intersection_of: UBERON:0001851 ! cortex and intersection_of: part_of UBERON:0000992 ! ovary are preserved, correctly placing the cortex within the ovary.

Minor suggestions (non-blocking):

🔵 SUGGESTION: A term_tracker_item linking back to issue #3521 could be added per project convention (CLAUDE.md recommends this for all edited terms).

🔵 SUGGESTION: Contributor attribution (relationship: dc-contributor + property_value: dcterms-date) for this edit would follow best practice for provenance tracking on modified terms.


Overall this is a clean, correct fix. Approving.

Copy link
Copy Markdown

@ai4c-agent ai4c-agent Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Review: Fixes #3521 — Removes incorrect partonomy for 'ovarian cortex'

Checklist

  • Hierarchy and parents are consistent
  • Definitions and supporting references look adequate
  • Obsolete or replacement handling is safe (N/A)
  • OBO and ODK conventions appear preserved
  • No obvious CI, auth, or workflow regression

This PR correctly addresses the inverted partonomy identified in issue #3521. The fix is anatomically sound and the changes are minimal and well-scoped.

Changes reviewed (UBERON:0013191 ovarian cortex):

  1. Removal of incorrect relationship (line removed: relationship: part_of UBERON:0006960 ! ovary stroma) — The old assertion had the cortex as part of the stroma, which is anatomically backwards. The NCIT mapping confirms: Stroma of the Ovarian Cortex (NCIT:C33638) is part_of Ovarian Cortex (NCIT:C33243), not the other way around. Simple removal is the correct fix (rather than reversal) because UBERON:0006960 ovary stroma spans the entire ovary including the medulla, so making it part_of ovarian cortex would be equally wrong.

  2. Definition text fix — "The layer of the ovarian stroma lying immediately beneath..." → "The layer of the ovary lying immediately beneath...". Correct: the cortex is a compartment of the ovary, not a compartment of the stroma.

  3. Added PMIDs — Six PMIDs added as definition xrefs (17999378, 22666170, 32716007, 36191605, 36721914, 41256733), improving the evidence base.

  4. Logical axioms intact — The intersection_of: UBERON:0001851 ! cortex and intersection_of: part_of UBERON:0000992 ! ovary are preserved, correctly placing the cortex within the ovary.

Minor suggestions (non-blocking):

🔵 SUGGESTION: A term_tracker_item linking back to issue #3521 could be added per project convention.

🔵 SUGGESTION: Contributor attribution (relationship: dc-contributor + property_value: dcterms-date) for this edit would follow best practice for provenance tracking on modified terms.


Overall this is a clean, correct fix. Approving.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR addresses issue #3521 by removing an incorrect part_of relationship that asserted ovarian cortex is part of ovary stroma, aligning Uberon’s partonomy with the directionality implied by the corresponding NCIT modeling.

Changes:

  • Removed the asserted relationship: part_of UBERON:0006960 ! ovary stroma from UBERON:0013191 (ovarian cortex).
  • Updated the textual definition of ovarian cortex to describe it as a layer of the ovary (rather than a layer of ovarian stroma) and added supporting PMIDs.

@aleixpuigb aleixpuigb merged commit 14c906a into master May 8, 2026
13 checks passed
@aleixpuigb aleixpuigb deleted the 3521_ovarian_cortex branch May 8, 2026 10:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

review relationship between ovarian cortex and ovary stroma

2 participants