Fixes #3521 Removes incorrect partonomy for 'ovarian cortex'#3705
Conversation
Fixes #3521 Removes incorrect partonomy for 'ovarian cortex'
|
Claude finished @aleixpuigb's task in 1m 59s —— View job PR Review: Fixes #3521 — Removes incorrect partonomy for 'ovarian cortex'Tasks
Review SummaryChecklist
This PR correctly addresses the inverted partonomy from issue #3521. The fix is anatomically sound and the changes are minimal and well-scoped. Changes reviewed (
Minor suggestions (non-blocking): 🔵 SUGGESTION: A 🔵 SUGGESTION: Contributor attribution ( Verdict: Approved ✅ |
There was a problem hiding this comment.
PR Review: Fixes #3521 — Removes incorrect partonomy for 'ovarian cortex'
Checklist
- Hierarchy and parents are consistent
- Definitions and supporting references look adequate
- Obsolete or replacement handling is safe (N/A)
- OBO and ODK conventions appear preserved
- No obvious CI, auth, or workflow regression
This PR correctly addresses the inverted partonomy identified in issue #3521. The fix is anatomically sound and the changes are minimal and well-scoped.
Changes reviewed ( ovarian cortex):
-
Removal of incorrect relationship (line removed:
relationship: part_of UBERON:0006960 ! ovary stroma) — The old assertion had the cortex as part of the stroma, which is anatomically backwards. The NCIT mapping confirms: Stroma of the Ovarian Cortex (NCIT:C33638) ispart_ofOvarian Cortex (NCIT:C33243), not the other way around. Simple removal is the correct fix (rather than reversal) becauseUBERON:0006960 ovary stromaspans the entire ovary, including the medulla, so making itpart_of ovarian cortexwould be equally wrong. -
Definition text fix — "The layer of the ovarian stroma lying immediately beneath..." → "The layer of the ovary lying immediately beneath...". Correct: the cortex is a compartment of the ovary, not a compartment of the stroma.
-
Added PMIDs — Six PMIDs added as definition xrefs (17999378, 22666170, 32716007, 36191605, 36721914, 41256733), improving the evidence base.
-
Logical axioms intact — The
intersection_of: UBERON:0001851 ! cortexandintersection_of: part_of UBERON:0000992 ! ovaryare preserved, correctly placing the cortex within the ovary.
Minor suggestions (non-blocking):
🔵 SUGGESTION: A term_tracker_item linking back to issue #3521 could be added per project convention (CLAUDE.md recommends this for all edited terms).
🔵 SUGGESTION: Contributor attribution (relationship: dc-contributor + property_value: dcterms-date) for this edit would follow best practice for provenance tracking on modified terms.
Overall this is a clean, correct fix. Approving.
There was a problem hiding this comment.
PR Review: Fixes #3521 — Removes incorrect partonomy for 'ovarian cortex'
Checklist
- Hierarchy and parents are consistent
- Definitions and supporting references look adequate
- Obsolete or replacement handling is safe (N/A)
- OBO and ODK conventions appear preserved
- No obvious CI, auth, or workflow regression
This PR correctly addresses the inverted partonomy identified in issue #3521. The fix is anatomically sound and the changes are minimal and well-scoped.
Changes reviewed (UBERON:0013191 ovarian cortex):
-
Removal of incorrect relationship (line removed:
relationship: part_of UBERON:0006960 ! ovary stroma) — The old assertion had the cortex as part of the stroma, which is anatomically backwards. The NCIT mapping confirms: Stroma of the Ovarian Cortex (NCIT:C33638) ispart_ofOvarian Cortex (NCIT:C33243), not the other way around. Simple removal is the correct fix (rather than reversal) becauseUBERON:0006960 ovary stromaspans the entire ovary including the medulla, so making itpart_of ovarian cortexwould be equally wrong. -
Definition text fix — "The layer of the ovarian stroma lying immediately beneath..." → "The layer of the ovary lying immediately beneath...". Correct: the cortex is a compartment of the ovary, not a compartment of the stroma.
-
Added PMIDs — Six PMIDs added as definition xrefs (17999378, 22666170, 32716007, 36191605, 36721914, 41256733), improving the evidence base.
-
Logical axioms intact — The
intersection_of: UBERON:0001851 ! cortexandintersection_of: part_of UBERON:0000992 ! ovaryare preserved, correctly placing the cortex within the ovary.
Minor suggestions (non-blocking):
🔵 SUGGESTION: A term_tracker_item linking back to issue #3521 could be added per project convention.
🔵 SUGGESTION: Contributor attribution (relationship: dc-contributor + property_value: dcterms-date) for this edit would follow best practice for provenance tracking on modified terms.
Overall this is a clean, correct fix. Approving.
There was a problem hiding this comment.
Pull request overview
This PR addresses issue #3521 by removing an incorrect part_of relationship that asserted ovarian cortex is part of ovary stroma, aligning Uberon’s partonomy with the directionality implied by the corresponding NCIT modeling.
Changes:
- Removed the asserted
relationship: part_of UBERON:0006960 ! ovary stromafromUBERON:0013191(ovarian cortex). - Updated the textual definition of ovarian cortex to describe it as a layer of the ovary (rather than a layer of ovarian stroma) and added supporting PMIDs.
Fixes #3521 Removes incorrect partonomy for 'ovarian cortex'