Skip to content

[codex] Clarify SDD code review overlap#1572

Open
Derekko-web wants to merge 1 commit into
obra:devfrom
Derekko-web:codex/sdd-review-satisfies-requesting-code-review
Open

[codex] Clarify SDD code review overlap#1572
Derekko-web wants to merge 1 commit into
obra:devfrom
Derekko-web:codex/sdd-review-satisfies-requesting-code-review

Conversation

@Derekko-web
Copy link
Copy Markdown

What problem are you trying to solve?

Fixes #1481. The current requesting-code-review wording can be read as requiring a second standalone review after SDD has already run its built-in per-task code quality review. That can waste subagent calls and create duplicate feedback for the same diff.

What does this PR change?

This clarifies that SDD invokes the requesting-code-review mechanism through code-quality-reviewer-prompt.md, and that the built-in SDD code quality review satisfies this skill for the reviewed diff. It also narrows the major-feature trigger to major features completed outside SDD.

Is this change appropriate for the core library?

Yes. This affects the relationship between two core workflow skills and is not project-specific.

What alternatives did you consider?

One alternative was to remove the SDD mention from requesting-code-review entirely, but that would hide the fact that SDD still requires per-task review. Another was to leave the wording as-is and rely on agents to infer the relationship, but the current mandatory wording can reasonably be interpreted as a separate post-SDD trigger.

Does this PR contain multiple unrelated changes?

No. It changes one file and only clarifies the SDD/requesting-code-review boundary.

Existing PRs

Environment tested

Harness (e.g. Claude Code, Cursor) Harness version Model Model version/ID
Codex desktop current session GPT-5 session default

New harness support (required if this PR adds a new harness)

Not applicable. This PR does not add a new harness.

Clean-session transcript for "Let's make a react todo list"
Not applicable.

Evaluation

I also attempted tests/claude-code/run-skill-tests.sh --test test-subagent-driven-development.sh; the runner depends on GNU timeout, which is not installed in this macOS environment. A temporary Bash shim got the runner started but left the wrapper stuck with no active claude child process, so I terminated that attempt rather than report it as a pass.

Rigor

  • If this is a skills change: I used superpowers:writing-skills and completed adversarial pressure testing (paste results below)
  • This change was tested adversarially, not just on the happy path
  • I did not modify carefully-tuned content (Red Flags table, rationalizations, "human partner" language) without extensive evals showing the change is an improvement

This is opened as a draft because the project template requires human review and stronger skill-change evaluation before the PR is ready for maintainer review.

Human review

  • A human has reviewed the COMPLETE proposed diff before submission

@Derekko-web Derekko-web marked this pull request as ready for review May 17, 2026 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant