[codex] Clarify SDD code review overlap#1572
Open
Derekko-web wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem are you trying to solve?
Fixes #1481. The current
requesting-code-reviewwording can be read as requiring a second standalone review after SDD has already run its built-in per-task code quality review. That can waste subagent calls and create duplicate feedback for the same diff.What does this PR change?
This clarifies that SDD invokes the requesting-code-review mechanism through
code-quality-reviewer-prompt.md, and that the built-in SDD code quality review satisfies this skill for the reviewed diff. It also narrows the major-feature trigger to major features completed outside SDD.Is this change appropriate for the core library?
Yes. This affects the relationship between two core workflow skills and is not project-specific.
What alternatives did you consider?
One alternative was to remove the SDD mention from
requesting-code-reviewentirely, but that would hide the fact that SDD still requires per-task review. Another was to leave the wording as-is and rely on agents to infer the relationship, but the current mandatory wording can reasonably be interpreted as a separate post-SDD trigger.Does this PR contain multiple unrelated changes?
No. It changes one file and only clarifies the SDD/requesting-code-review boundary.
Existing PRs
Environment tested
New harness support (required if this PR adds a new harness)
Not applicable. This PR does not add a new harness.
Clean-session transcript for "Let's make a react todo list"
Evaluation
descriptionvalues in YAML frontmatter #955 was skipped because open PRs Docs: Require quoted YAML description in SKILL.md and clarify description guidance #979 and docs(writing-skills): add YAML frontmatter quoting guidance #1028 already cover it, so this PR targets Clarify that SDD code quality review satisfies requesting-code-review #1481 instead.git diff --checkrgassertion confirming the old ambiguous SDD wording is gone and the new satisfaction wording appears exactly onceI also attempted
tests/claude-code/run-skill-tests.sh --test test-subagent-driven-development.sh; the runner depends on GNUtimeout, which is not installed in this macOS environment. A temporary Bash shim got the runner started but left the wrapper stuck with no activeclaudechild process, so I terminated that attempt rather than report it as a pass.Rigor
superpowers:writing-skillsand completed adversarial pressure testing (paste results below)This is opened as a draft because the project template requires human review and stronger skill-change evaluation before the PR is ready for maintainer review.
Human review