Fix stale tool references in porting guide#1908
Open
tianma-if wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix stale tool references in porting guide
Base:
obra/superpowers:devHead:
msh01/superpowers:codex/fix-porting-guide-stale-tool-refsWho is submitting this PR? (required)
What problem are you trying to solve?
Issue #1873 identified stale Gemini-related references after Gemini CLI support was removed.
docs/porting-to-a-new-harness.mdstill presents Gemini andreferences/gemini-tools.mdas current copy-from references even thoughgemini-tools.mdis no longer tracked. The same live reference table also namesreferences/claude-code-tools.mdandreferences/copilot-tools.md, which are not tracked in the current checkout.What does this PR change?
Updates the porting guide so it no longer points at missing tool-reference files as current reference integrations. It keeps the important Shape C lesson: do not trust
@-include expansion until a unique-marker test proves the content is present without a tool call.Is this change appropriate for the core library?
Yes. This fixes core contributor documentation for harness porting and avoids directing contributors to files that are not present.
What alternatives did you consider?
I considered removing the whole Shape C section, but #1873 explicitly says to preserve the
@-include-is-a-hint lesson because it matters for Gemini-derived harnesses such as Antigravity. This PR preserves that lesson while removing stale file references.Does this PR contain multiple unrelated changes?
No. Every edit is in
docs/porting-to-a-new-harness.mdand addresses stale current-reference entries.Existing PRs
GEMINI.mdand removes orphaned files. This PR intentionally does not touchGEMINI.md; it handles the remaining porting-guide stale references from Finish removing Gemini CLI support: broken @-include + dangling doc refs (must not regress Antigravity) #1873.Environment tested
New harness support (required if this PR adds a new harness)
Not applicable.
Evaluation
gemini-tools.md,claude-code-tools.md, andcopilot-tools.md; after, those stale references are gone while the Shape C verification rule remains.Verification run:
Rigor
GEMINI.mdHuman review