avoid stack overflow with negative radius (#2404)

Author: mbostock

src/transforms/dodge.js

@@ -78,7 +78,7 @@ function dodge(y, x, anchor, padding, r, options) {
     const radius = R ? (i) => R[i] : () => cr;
     for (let I of facets) {
       const tree = IntervalTree();
-      I = I.filter(R ? (i) => finite(X[i]) && positive(R[i]) : (i) => finite(X[i]));
+      I = I.filter(R ? (i) => finite(X[i]) && positive(R[i]) : cr > 0 ? (i) => finite(X[i]) : () => false);
       const intervals = new Float64Array(2 * I.length + 2);
       for (const i of I) {
         const ri = radius(i);

test/output/penguinDodgeNegativeRadius.svg

@@ -9,3 +9,11 @@ test(async function penguinDodge() {
     marks: [Plot.dot(penguins, Plot.dodgeY({x: "body_mass_g"}))]
   });
 });
+
+test(async function penguinDodgeNegativeRadius() {
+  const penguins = await d3.csv<any>("data/penguins.csv", d3.autoType);
+  return Plot.plot({
+    height: 200,
+    marks: [Plot.dot(penguins, Plot.dodgeY({x: "body_mass_g", r: -1}))]
+  });
+});