add constructors to mark class types (#2425)

* add constructors to mark class types

* prasnier

Author: Fil

src/mark.d.ts

@@ -482,6 +482,7 @@ export interface MarkOptions {
 
 /** The abstract base class for Mark implementations. */
 export class Mark {
+  constructor(data?: Data, channels?: Record<string, Channel>, options?: MarkOptions, defaults?: MarkOptions);
   /**
    * Renders a new plot, prepending this mark as the first element of **marks**
    * of the specified *options*, and returns the corresponding SVG element, or
@@ -492,8 +493,10 @@ export class Mark {
 
 /** A concrete Mark implementation. */
 export class RenderableMark extends Mark {
+  // Declared as a method rather than a property so that subclasses can override
+  // it and call super.render(). See https://www.typescriptlang.org/docs/handbook/release-notes/typescript-5-3.html#checks-for-super-property-accesses-on-instance-fields
   /** Renders this mark, returning a new SVGElement (or null). */
-  render: RenderFunction;
+  render(...args: Parameters<RenderFunction>): ReturnType<RenderFunction>;
 }
 
 /** A compound Mark, comprising other marks. */

src/marks/area.d.ts

@@ -205,4 +205,6 @@ export function areaX(data?: Data, options?: AreaXOptions & AreaLineOptions): Ar
 export function areaY(data?: Data, options?: AreaYOptions & AreaLineOptions): Area;
 
 /** The area mark. */
-export class Area extends RenderableMark {}
+export class Area extends RenderableMark {
+  constructor(data?: Data, options?: AreaOptions);
+}

src/marks/arrow.d.ts

@@ -111,4 +111,6 @@ export interface ArrowOptions extends MarkOptions {
 export function arrow(data?: Data, options?: ArrowOptions): Arrow;
 
 /** The arrow mark. */
-export class Arrow extends RenderableMark {}
+export class Arrow extends RenderableMark {
+  constructor(data?: Data, options?: ArrowOptions);
+}

src/marks/bar.d.ts

@@ -203,7 +203,11 @@ export function barX(data?: Data, options?: BarXOptions): BarX;
 export function barY(data?: Data, options?: BarYOptions): BarY;
 
 /** The barX mark. */
-export class BarX extends RenderableMark {}
+export class BarX extends RenderableMark {
+  constructor(data?: Data, options?: BarXOptions);
+}
 
 /** The barY mark. */
-export class BarY extends RenderableMark {}
+export class BarY extends RenderableMark {
+  constructor(data?: Data, options?: BarYOptions);
+}

src/marks/cell.d.ts

@@ -71,4 +71,6 @@ export function cellX(data?: Data, options?: CellOptions): Cell;
 export function cellY(data?: Data, options?: CellOptions): Cell;
 
 /** The cell mark. */
-export class Cell extends RenderableMark {}
+export class Cell extends RenderableMark {
+  constructor(data?: Data, options?: CellOptions);
+}

src/marks/contour.d.ts

@@ -89,4 +89,6 @@ export function contour(data?: Data, options?: ContourOptions): Contour;
 export function contour(options?: ContourOptions): Contour;
 
 /** The contour mark. */
-export class Contour extends RenderableMark {}
+export class Contour extends RenderableMark {
+  constructor(data?: Data, options?: ContourOptions);
+}

src/marks/density.d.ts

@@ -51,4 +51,6 @@ export interface DensityOptions extends MarkOptions {
 export function density(data?: Data, options?: DensityOptions): Density;
 
 /** The density mark. */
-export class Density extends RenderableMark {}
+export class Density extends RenderableMark {
+  constructor(data?: Data, options?: DensityOptions);
+}

src/marks/difference.d.ts

@@ -97,4 +97,6 @@ export function differenceX(data?: Data, options?: DifferenceOptions): Differenc
 export function differenceY(data?: Data, options?: DifferenceOptions): Difference;
 
 /** The difference mark. */
-export class Difference extends RenderableMark {}
+export class Difference extends RenderableMark {
+  constructor(data?: Data, options?: DifferenceOptions);
+}

src/marks/dot.d.ts

@@ -144,4 +144,6 @@ export function circle(data?: Data, options?: Omit<DotOptions, "symbol">): Dot;
 export function hexagon(data?: Data, options?: Omit<DotOptions, "symbol">): Dot;
 
 /** The dot mark. */
-export class Dot extends RenderableMark {}
+export class Dot extends RenderableMark {
+  constructor(data?: Data, options?: DotOptions);
+}

src/marks/frame.d.ts

@@ -20,4 +20,6 @@ export interface FrameOptions extends MarkOptions, InsetOptions, RectCornerOptio
 export function frame(options?: FrameOptions): Frame;
 
 /** The frame decoration mark. */
-export class Frame extends RenderableMark {}
+export class Frame extends RenderableMark {
+  constructor(options?: FrameOptions);
+}