Merge branch 'fil/brush-dataless' into fil/brush-across-facets

Author: Fil

src/interactions/brush.js

@@ -148,7 +148,7 @@ export class Brush extends Mark {
         });
     }
 
-    const g = create("svg:g").attr("aria-label", "brush");
+    const g = create("svg:g").attr("aria-label", this._dimension === "xy" ? "brush" : `brush-${this._dimension}`);
     g.call(this._brush);
     const node = g.node();
     this._brushNodes.push(node);

test/output/brushXDot.html

@@ -34,7 +34,7 @@
     <g aria-label="x-axis label" text-anchor="end" transform="translate(17.5,27.5)">
       <text transform="translate(620,140)">body_mass_g →</text>
     </g>
-    <g aria-label="brush" fill="none" pointer-events="all">
+    <g aria-label="brush-x" fill="none" pointer-events="all">
       <rect class="overlay" pointer-events="all" cursor="crosshair" x="19" y="10" width="602" height="130"></rect>
       <rect class="selection" cursor="move" fill="#777" fill-opacity="0.3" stroke="#fff" shape-rendering="crispEdges" style="" x="103.333" y="10" width="266.667" height="130"></rect>
       <rect class="handle handle--w" cursor="ew-resize" style="" x="100.333" y="7" width="6" height="136"></rect>

test/output/brushXHistogram.html

@@ -65,7 +65,7 @@
     <g aria-label="x-axis label" text-anchor="end" transform="translate(17.5,27.5)">
       <text transform="translate(620,370)">body_mass_g →</text>
     </g>
-    <g aria-label="brush" fill="none" pointer-events="all">
+    <g aria-label="brush-x" fill="none" pointer-events="all">
       <rect class="overlay" pointer-events="all" cursor="crosshair" x="39" y="20" width="582" height="350"></rect>
       <rect class="selection" cursor="move" fill="#777" fill-opacity="0.3" stroke="#fff" shape-rendering="crispEdges" style="" x="166.973" y="20" width="227.297" height="350"></rect>
       <rect class="handle handle--w" cursor="ew-resize" style="" x="163.973" y="17" width="6" height="356"></rect>

test/output/brushXHistogramFaceted.html

@@ -146,7 +146,7 @@
       <g aria-label="x-axis label" text-anchor="end" transform="translate(37.5,27.5)">
         <text transform="translate(600,449)">body_mass_g →</text>
       </g>
-      <g aria-label="brush">
+      <g aria-label="brush-x">
         <g fill="none" pointer-events="all" transform="translate(0,0)">
           <rect class="overlay" pointer-events="all" cursor="crosshair" x="39" y="20" width="562" height="133"></rect>
           <rect class="selection" cursor="move" fill="#777" fill-opacity="0.3" stroke="#fff" shape-rendering="crispEdges" style="" x="161.081" y="20" width="227.027" height="133"></rect>

test/output/brushXLine.html

@@ -62,7 +62,7 @@
       <text y="0.71em" transform="translate(462.599,370)">2017</text>
       <text y="0.71em" transform="translate(578.662,370)">2018</text>
     </g>
-    <g aria-label="brush" fill="none" pointer-events="all">
+    <g aria-label="brush-x" fill="none" pointer-events="all">
       <rect class="overlay" pointer-events="all" cursor="crosshair" x="39" y="20" width="582" height="350"></rect>
       <rect class="selection" cursor="move" fill="#777" fill-opacity="0.3" stroke="#fff" shape-rendering="crispEdges" style="" x="230.154" y="20" width="164.397" height="350"></rect>
       <rect class="handle handle--w" cursor="ew-resize" style="" x="227.154" y="17" width="6" height="356"></rect>

test/output/brushXTemporal.html

@@ -66,7 +66,7 @@
       <text y="0.71em" transform="translate(458.837,370)">2017</text>
       <text y="0.71em" transform="translate(572.838,370)">2018</text>
     </g>
-    <g aria-label="brush" fill="none" pointer-events="all">
+    <g aria-label="brush-x" fill="none" pointer-events="all">
       <rect class="overlay" pointer-events="all" cursor="crosshair" x="39" y="20" width="582" height="350"></rect>
       <rect class="selection" cursor="move" fill="#777" fill-opacity="0.3" stroke="#fff" shape-rendering="crispEdges" style="" x="163.683" y="20" width="114.001" height="350"></rect>
       <rect class="handle handle--w" cursor="ew-resize" style="" x="160.683" y="17" width="6" height="356"></rect>

test/output/brushXTemporalReversed.html

@@ -66,7 +66,7 @@
       <text y="0.71em" transform="translate(429.478,370)">2015</text>
       <text y="0.71em" transform="translate(543.479,370)">2014</text>
     </g>
-    <g aria-label="brush" fill="none" pointer-events="all">
+    <g aria-label="brush-x" fill="none" pointer-events="all">
       <rect class="overlay" pointer-events="all" cursor="crosshair" x="39" y="20" width="582" height="350"></rect>
       <rect class="selection" cursor="move" fill="#777" fill-opacity="0.3" stroke="#fff" shape-rendering="crispEdges" style="" x="382.316" y="20" width="114.001" height="350"></rect>
       <rect class="handle handle--w" cursor="ew-resize" style="" x="379.316" y="17" width="6" height="356"></rect>

test/output/brushYDot.html

@@ -53,7 +53,7 @@
     <g aria-label="x-axis label" text-anchor="end" transform="translate(17.5,27.5)">
       <text transform="translate(620,370)">culmen_length_mm →</text>
     </g>
-    <g aria-label="brush" fill="none" pointer-events="all">
+    <g aria-label="brush-y" fill="none" pointer-events="all">
       <rect class="overlay" pointer-events="all" cursor="crosshair" x="40" y="19" width="580" height="352"></rect>
       <rect class="selection" cursor="move" fill="#777" fill-opacity="0.3" stroke="#fff" shape-rendering="crispEdges" style="" x="40" y="82.5" width="580" height="208.333"></rect>
       <rect class="handle handle--n" cursor="ns-resize" style="" x="37" y="79.5" width="586" height="6"></rect>

test/output/brushYHistogram.html

@@ -76,7 +76,7 @@
     <g aria-label="x-axis label" text-anchor="end" transform="translate(17.5,27.5)">
       <text transform="translate(620,370)">Frequency →</text>
     </g>
-    <g aria-label="brush" fill="none" pointer-events="all">
+    <g aria-label="brush-y" fill="none" pointer-events="all">
       <rect class="overlay" pointer-events="all" cursor="crosshair" x="40" y="19" width="580" height="352"></rect>
       <rect class="selection" cursor="move" fill="#777" fill-opacity="0.3" stroke="#fff" shape-rendering="crispEdges" style="" x="40" y="175.556" width="580" height="116.667"></rect>
       <rect class="handle handle--n" cursor="ns-resize" style="" x="37" y="172.556" width="586" height="6"></rect>

test/output/brushYLine.html

@@ -48,7 +48,7 @@
     <g aria-label="x-axis label" text-anchor="end" transform="translate(17.5,27.5)">
       <text transform="translate(620,370)">Close →</text>
     </g>
-    <g aria-label="brush" fill="none" pointer-events="all">
+    <g aria-label="brush-y" fill="none" pointer-events="all">
       <rect class="overlay" pointer-events="all" cursor="crosshair" x="40" y="19" width="580" height="352"></rect>
       <rect class="selection" cursor="move" fill="#777" fill-opacity="0.3" stroke="#fff" shape-rendering="crispEdges" style="" x="40" y="156.047" width="580" height="99.205"></rect>
       <rect class="handle handle--n" cursor="ns-resize" style="" x="37" y="153.047" width="586" height="6"></rect>