Handle null titles/empty channels in Tip#2275
Closed
matthewCmatt wants to merge 1 commit intoobservablehq:mainfrom
Closed
Handle null titles/empty channels in Tip#2275matthewCmatt wants to merge 1 commit intoobservablehq:mainfrom
matthewCmatt wants to merge 1 commit intoobservablehq:mainfrom
Conversation
Author
|
To be clear, this MR allows |
mbostock
reviewed
Apr 3, 2026
| renderLine(that, {value: mark.clipLine(line)}); | ||
| } | ||
| } else { | ||
| } else if (isIterable(lines)) { |
Member
There was a problem hiding this comment.
I think we’d just want to check for nullish here instead:
Suggested change
| } else if (isIterable(lines)) { | |
| } else if (lines != null) { |
If lines is not null or undefined, we don’t want to allow non-iterable values here; a non-nullish, non-iterable value should still be an error.
Merged
Member
|
I tested this in #2408; it fixes the crash but also isn’t exactly the desired behavior. Rather than rendering an empty tip, we should render no tip at all. 
I also figured out how to test this by dispatching a synthetic pointermove event. Work will continue in #2408. Thank you for filing the issue and proposing a fix. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Aims to fix #2274
This PR allows the
renderfunction of tooltips (Tip) to handlenullvalues for atitle.See the issue linked above for steps to reproduce the issue and some more reasoning behind this PR.