-
Notifications
You must be signed in to change notification settings - Fork 227
pointer pool option #2382
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pointer pool option #2382
Changes from 8 commits
f3e0b29
e6ef8e4
dd65c3a
0a1ea24
4a7126b
2c8922a
ed914e9
8fca112
97dd4e2
04bccc4
350effd
bbd32a2
60e830b
d198cd1
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -17,6 +17,13 @@ export interface PointerOptions { | |
| /** The vertical target position channel, typically bound to the *y* scale. */ | ||
| py?: ChannelValue; | ||
|
|
||
| /** | ||
| * Whether this mark participates in the pointer pool, which ensures that | ||
| * only the closest point is shown when multiple pointer marks are present. | ||
| * Defaults to true for the tip mark. | ||
| */ | ||
| pool?: boolean; | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This isn’t the right place to declare this option. The pointer transform ignores Either we should make this option work for every mark (either reading it from Moving it to Why is it that only the tip mark wants pool to default to true?
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. To answer my own question, I guess the tip mark wants pool to default to true because the tip mark is generally “exclusive” as in typically you only want to see one tip at a time. (Though we do support rendering tips statically as annotations, in which case you do want multiple tips at the same time.) |
||
|
|
||
| /** | ||
| * The fallback horizontal target position channel, typically bound to the *x* | ||
| * scale; used if **px** is not specified. | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is losing a useful tip relevant to the example above, which is rendering multiple tips statically!