Closed
Conversation
Closed
mbostock
reviewed
Apr 4, 2026
Member
mbostock
left a comment
There was a problem hiding this comment.
This looks like a step in the right direction. I think we’ll probably want to lump the display attributes into three categories: (1) shared attributes that apply to both the area and line path, (2) attributes that only apply to the area path, and (3) attributes that only apply to the line path.
This branch currently produces something like:
<g>
<g>
<path aria-label="area" fill="#3ca951" d="M40,189.819L52.6,192.692…Z">
<title>8 - Track Tape</title>
</path>
<path aria-label="area" fill="none" stroke="white" stroke-linejoin="round" stroke-linecap="round" transform="translate(0.5,0.5)" d="M40,189.819L52.6,192.692…">
<title>8 - Track Tape</title>
</path>
</g>
</g>But I think we are going to want something like:
<g aria-label="area">
<g>
<path fill="#3ca951" d="M40,189.819L52.6,192.692…Z"></path>
<path fill="none" stroke="white" stroke-linejoin="round" stroke-linecap="round" transform="translate(0.5,0.5)" d="M40,189.819L52.6,192.692…"></path>
<title>8 - Track Tape</title>
</g>
</g>In other words:
- Constant attributes such as
aria-labelshould be moved up to the mark’s root G element. - Shared attributes attributes such as
mix-blend-modeandopacityshould be on the G element that contains the per-instance area and line paths; this G element should also contain a singular TITLE element; the clip would also be applied here. - Attributes that are specific to the area and line paths go on the path elements.
Merged
Member
|
Superseded by #2407. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This still needs updates to the tests (to actually test that the line and fill options are going to the right place).for #2133.