Skip to content

handle null lines #2408

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mbostock merged 4 commits into from
Apr 6, 2026
+858 −1
Merged

handle null lines #2408

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
1ed5008
handle null lines
mbostock Apr 5, 2026
e80ba02
test dispatch case
mbostock Apr 5, 2026
3a260b8
await async tip render
mbostock Apr 5, 2026
5939344
fix dev rendering
mbostock Apr 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion src/marks/tip.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -127,6 +127,11 @@ export class Tip extends Mark {
format = formatChannels;
}

// Format the tip text, skipping any nulls.
const T = new Array(index.length);
for (const i of index) T[i] = format.call(mark, i, index, sources, scales, values);
index = index.filter((i) => T[i] != null);

// We don’t call applyChannelStyles because we only use the channels to
// derive the content of the tip, not its aesthetics.
const g = create("svg:g", context)
Expand All @@ -150,7 +155,7 @@ export class Tip extends Mark {
this.setAttribute("fill-opacity", 1);
this.setAttribute("stroke", "none");
// iteratively render each channel value
const lines = format.call(mark, i, index, sources, scales, values);
const lines = T[i];
if (typeof lines === "string") {
for (const line of mark.splitLines(lines)) {
renderLine(that, {value: mark.clipLine(line)});
Expand Down
Loading