Skip to content

python literals via pyodide#293

Draft
mbostock wants to merge 6 commits into
mainfrom
mbostock/pyodide
Draft

python literals via pyodide#293
mbostock wants to merge 6 commits into
mainfrom
mbostock/pyodide

Conversation

@mbostock

@mbostock mbostock commented Jun 23, 2022

Copy link
Copy Markdown
Member

This is roughly the same approach as taken by Grant Nestor, although I made some changes to fix falsey value interpolation and to adopt the recommended/public APIs such as runPythonAsync instead of calling eval_code_async directly.

@mbostock mbostock requested a review from duaneatat June 23, 2022 14:07

@duaneatat duaneatat left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so cool!

@mootari

mootari commented Jun 23, 2022

Copy link
Copy Markdown

Should the pyodide instance be exposed so that you can e.g. load micropip?

mbostock added 2 commits June 23, 2022 17:02
* patch matplotlib’s show

* font-awesome for matplotlib buttons

* fix for redrawing figure

* only remove if parent is body
@mbostock

Copy link
Copy Markdown
Member Author

Should the pyodide instance be exposed so that you can e.g. load micropip?

I’m not going to do this yet, but we might add this in the future.

@mbostock mbostock marked this pull request as draft July 4, 2022 12:34
@mbostock

mbostock commented Jul 4, 2022

Copy link
Copy Markdown
Member Author

Putting this on hold as, at a minimum, I think we need to update the Observable Inspector to do a better job with PyProxy objects.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants