Skip to content

frontend: Adjust shutdown logic more#13347

Open
Warchamp7 wants to merge 2 commits intoobsproject:masterfrom
Warchamp7:more-shutdown-things
Open

frontend: Adjust shutdown logic more#13347
Warchamp7 wants to merge 2 commits intoobsproject:masterfrom
Warchamp7:more-shutdown-things

Conversation

@Warchamp7
Copy link
Copy Markdown
Member

@Warchamp7 Warchamp7 commented Apr 21, 2026

Description

Removes our connections to Qt's aboutToQuit signal as well better handling the deferred close to the main window for WM_QUERYENDSESSION.

Motivation and Context

Trying to fix shutdown crashes more. The aboutToQuit connections were set up early in my original shutdown logic PR and now that we have a nativeEventFilter for the Windows MSGs (Which is exactly the same thing aboutToQuit gets fired from), it no longer appears to be necessary (And indeed was causing some issues on macOS) and may only be causing problems in some cases.

We're still seeing some situations where OBSBasic is getting destroyed while already shutting down that may be attributable to this.

How Has This Been Tested?

Shut down OBS various times, including with/without outputs active, and tried logging out in both scenarios.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • I have read the contributing document.
  • My code has been run through clang-format.
  • My code follows the project's style guidelines
  • My code is not on the master branch.
  • My code has been tested.
  • All commit messages are properly formatted and commits squashed where appropriate.
  • I have included updates to all appropriate documentation.

@Warchamp7 Warchamp7 force-pushed the more-shutdown-things branch from 1c37d83 to 50e4b6f Compare April 21, 2026 01:21
@WizardCM WizardCM added the kind/bug Categorizes issue or PR as related to a bug. label May 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

kind/bug Categorizes issue or PR as related to a bug.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants