Fix: Behavior of hotkeys more like other apps now#13363
Open
suogesi wants to merge 3 commits intoobsproject:masterfrom
Open
Fix: Behavior of hotkeys more like other apps now#13363suogesi wants to merge 3 commits intoobsproject:masterfrom
suogesi wants to merge 3 commits intoobsproject:masterfrom
Conversation
Remove the unnessary param `pressed`. Split conditions connected with `||`.
Rename `modifiers_match` tl `input_match_modifiers`. No need to pass binding pointer anymore.
Rewrite `handle_binding`. Also remove `modifiers_match` in `obs_hotkey_binding` and add `pressing_key` for detecting if user press common key before modifiers. Previous code maybe tried to distingguish the order of keys input. It actually didn't work. Rewrited `handle_binding` can check if user press common key before modifiers and prevent hotkey being triggered. Rewrited `handle_binding` also solve the problem that if you hold a hotkey combination and press a modifier, when the modifier up, the hotkey will be triggered. Delete a assign in `inject_hotkey` because `modifiers_match` has been removed. I trust it was just for pass the conditions in `handle_binding`.
WizardCM
added
the
kind/enhancement
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Hotkeys could trigger in unexpected way before:
Motivation and Context
#13091
How Has This Been Tested?
I ran it on my Windows 10 laptop and see it works.
Types of changes
Checklist: