plugins: Remove legacy slideshow source#13380
Open
cg2121 wants to merge 1 commit intoobsproject:masterfrom
Open
plugins: Remove legacy slideshow source#13380cg2121 wants to merge 1 commit intoobsproject:masterfrom
cg2121 wants to merge 1 commit intoobsproject:masterfrom
Conversation
This removes the old slideshow source. Since the properties are the same for both of the new and old slideshows, they are backwards compatible.
Warchamp7
reviewed
May 3, 2026
|
|
||
| struct obs_source_info slideshow_info_mk2 = { | ||
| .id = "slideshow", | ||
| .version = 2, |
Member
There was a problem hiding this comment.
What is the impact or result of removing this?
Member
|
What happens to a Slideshow v1 and v2 in a scene collection after these changes? I presume they're simply treated as the same thing which begs the question of why v1 was ever retained in the first place? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This removes the old slideshow source. Since the properties are the same for both of the new and old slideshows, they are backwards compatible.
Motivation and Context
It is just extra code that is not need.
How Has This Been Tested?
Created slideshow with old source and made sure it migrated to the new one.
Types of changes
Checklist: