Skip to content

frontend: Duplicate browser cookies when profile is duplicated #13472

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
WizardCM wants to merge 1 commit into
base: master
Choose a base branch
from
Open

frontend: Duplicate browser cookies when profile is duplicated #13472

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions frontend/widgets/OBSBasic_Browser.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -223,7 +223,7 @@ void DeleteCookies()
#endif
}

void DuplicateCurrentCookieProfile(ConfigFile &config)
void DuplicateCurrentCookieProfile()
{
#ifdef BROWSER_AVAILABLE
if (cef) {
Expand Down Expand Up @@ -260,7 +260,6 @@ void DuplicateCurrentCookieProfile(ConfigFile &config)
}
}

config_set_string(config, "Panels", "CookieId", cookie_id.c_str());
config_set_string(main->Config(), "Panels", "CookieId", new_id.c_str());
}
#else
Expand Down
4 changes: 3 additions & 1 deletion frontend/widgets/OBSBasic_Profiles.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ constexpr std::string_view OBSProfileSettingsFile = "basic.ini";
extern bool restart;

extern void DestroyPanelCookieManager();
extern void DuplicateCurrentCookieProfile(ConfigFile &config);
extern void DuplicateCurrentCookieProfile();
extern void CheckExistingCookieId();
extern void DeleteCookies();

Expand Down Expand Up @@ -103,6 +103,8 @@ void OBSBasic::SetupDuplicateProfile(const std::string &profileName)

ActivateProfile(newProfile);

DuplicateCurrentCookieProfile();

blog(LOG_INFO, "Created profile '%s' (duplicate, %s)", newProfile.name.c_str(),
newProfile.directoryName.c_str());
blog(LOG_INFO, "------------------------------------------------");
Expand Down
Loading