frontend: replace Auth with YoutubeApiWrappers for YouTube callers

[xakep8]

Description

Part of #13443

Updates YouTube-specific frontend code to pass YoutubeApiWrappers directly where the caller already requires YouTube auth object, instead of passing generic Auth.

Motivation and Context

OBSYoutubeActions and related YouTube-specific paths only work with the YouTube API version of Auth object. Passing generic Auth into these call sites pushes constructors to perform dynamic_cast internally when it should be the callers responsibility.

How Has This Been Tested?

xcodebuild -configuration RelWithDebInfo -scheme obs-studio -parallelizeTargets -destination "generic/platform=macOS,name=Any Mac"

Types of changes

• Code cleanup (non-breaking change which makes code smaller or more readable)

Checklist:

• I have read the contributing document.
• My code has been run through clang-format.
• My code follows the project's style guidelines
• My code is not on the master branch.
• My code has been tested.
• All commit messages are properly formatted and commits squashed where appropriate.
• I have included updates to all appropriate documentation.

[xakep8]

@Warchamp7 PTAL

[Warchamp7]

There's deeper problems we need to fix here, but this is fine as a small cleanup.

[xakep8]

There's deeper problems we need to fix here, but this is fine as a small cleanup.

I could raise another PR as a follow up to this and I can clean up other places where the dynamic_cast is used.

We have a lot of scattered RTTI would it be okay if we centralize it in OBSBasic?

Edit: The question was a reference to the code in YouTubeAppDock.cpp where we have GetYTApi, which does the GetAuth and then does dynamic_cast, it would make sense if we move this to OBSBasic.

[Warchamp7]

There's deeper problems we need to fix here, but this is fine as a small cleanup.

I could raise another PR as a follow up to this and I can clean up other places where the dynamic_cast is used.

We have a lot of scattered RTTI would it be okay if we centralize it in OBSBasic?

Edit: The question was a reference to the code in YouTubeAppDock.cpp where we have GetYTApi, which does the GetAuth and then does dynamic_cast, it would make sense if we move this to OBSBasic.

I'm referring more to the architectural problems of YoutubeApiWrappers being an extension of YoutubeAuth which is an extension of OAuthStreamKey which is an extension of OAuth which is an extension of Auth and all kinds of things have been bolted onto all manner of those layers. It's a mess but that's a much larger and complicated problem to fix.

[xakep8]

There's deeper problems we need to fix here, but this is fine as a small cleanup.

I could raise another PR as a follow up to this and I can clean up other places where the dynamic_cast is used.
We have a lot of scattered RTTI would it be okay if we centralize it in OBSBasic?
Edit: The question was a reference to the code in YouTubeAppDock.cpp where we have GetYTApi, which does the GetAuth and then does dynamic_cast, it would make sense if we move this to OBSBasic.

I'm referring more to the architectural problems of YoutubeApiWrappers being an extension of YoutubeAuth which is an extension of OAuthStreamKey which is an extension of OAuth which is an extension of Auth and all kinds of things have been bolted onto all manner of those layers. It's a mess but that's a much larger and complicated problem to fix.

Got it so considering this, I have a little understanding of what we are dealing with, here's something that I was thinking please let me know if this makes sense as I would like to work on solving this.

The YoutubeApiWrapper is inheriting from YoutubeAuth but considering what it does it's not really a more specific Auth object it's more off a Youtube API/broadcast client which needs OAuth data so maybe we should separate it as a YoutubeApiClient which is not a QObject and not a Auth and then we let YoutubeService own this along with a OAuthTokenStore. I also saw that the YoutubeAuth has LoadUI which does the dock creation we can move this out to a YoutubeDockController and also move broadcast setup/start/stop to YoutubeBroadcastController.

As a first cleanup, I can first work on the YoutubeApiClient part and then clean up the call sites to use YoutubeApiClient instead of the YoutubeApiWrappers.

Please suggest if I'm missing something.