fix: hide splash screen on onboarding and login screens#524
Open
songyipan wants to merge 1 commit intoobytes:masterfrom
Open
fix: hide splash screen on onboarding and login screens#524songyipan wants to merge 1 commit intoobytes:masterfrom
songyipan wants to merge 1 commit intoobytes:masterfrom
Conversation
SplashScreen was only hidden in TabLayout, but when isFirstTime is true or user is signed out, the app redirects to onboarding/login screens before TabLayout's useEffect runs, causing the splash screen to never hide. Also added error handling to storage getItem to prevent JSON.parse exceptions from blocking auth hydration. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
✅ Deploy Preview for obytes-starter canceled.
|
songyipan
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this do?
Adds
SplashScreen.hideAsync()calls toonboarding-screen.tsxandlogin-screen.tsx, and adds error handling tostorage.getItem().Why did you do this?
Bug: The app was stuck on the splash screen.
Root cause:
SplashScreen.hideAsync()was only called inTabLayout'suseEffect, but whenisFirstTimeistrueor user is signed out, the app redirects toonboardingorloginscreens beforeTabLayoutrenders. This means the splash screen hiding logic never executes.Additionally,
storage.getItem()could throw onJSON.parseerrors, potentially blocking auth hydration and leavingstatusasidle.Who/what does this impact?
TabLayoutbefore splash screen can be hiddenHow did you test this?