You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
@OlivierNicole Do you recall why you chose empty variant types for constructible/deconstructible
and abstract types for combinable/noncombinable?
Rather than rewrite the interface, I guess another way around this is to silence the warnings with attributes on each pattern match that trunk will now deem potentially non-exhaustive. We know from OCaml 5.0.0-5.4.0 that they are in fact exhaustive. On the positive side this will be less invasive, however it also smells like more of a temporary workaround... 🤷
jmid
changed the title
WIP: rework GADT index types to get Lin compiling on trunk again
Rework GADT index types to get Lin compiling on trunk again
Jun 19, 2025
@OlivierNicole Do you recall why you chose empty variant types for constructible/deconstructible and abstract types for combinable/noncombinable?
Sorry for the response delay, it looks like I missed the notification. No, I can't recall a good reason for this!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #559
ATM this changes two empty variant types in the interface, which is a bit annoying... 🤔