Skip to content

Add missing l and L suffixes in int32 and int64 printers for both Lin and STM #562

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jmid merged 3 commits into from
Jun 25, 2025
Merged

Add missing l and L suffixes in int32 and int64 printers for both Lin and STM #562

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
cd48a79
Fix Lin int32 and int64 printer to add 'l' and 'L' suffixes
jmid Jun 25, 2025
6cf94a6
Fix STM int32 and int64 printer to add 'l' and 'L' suffixes
jmid Jun 25, 2025
0808b2f
Add CHANGES entry
jmid Jun 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions CHANGES.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,8 @@

## NEXT RELEASE

- #562: Fix the `int32` and `int64` printers in both `Lin` and `STM` to add
missing `l` and `L` suffixes on literals.
- #560: Change `Lin.{constructible,deconstructible}` from an empty variant type
to an abstract type to get `Lin` compiling on `5.5.0+trunk` again, due
to https://github.com/ocaml/ocaml/pull/13994 removing special handling
Expand Down
4 changes: 2 additions & 2 deletions lib/STM.ml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,8 +27,8 @@ let unit = (Unit, QCheck.Print.unit)
let bool = (Bool, QCheck.Print.bool)
let char = (Char, QCheck.Print.char)
let int = (Int, QCheck.Print.int)
let int32 = (Int32, Int32.to_string)
let int64 = (Int64, Int64.to_string)
let int32 = (Int32, QCheck.Print.int32)
let int64 = (Int64, QCheck.Print.int64)
let float = (Float, QCheck.Print.float)
let string = (String, QCheck.Print.string)
let bytes = (Bytes, QCheck.Print.bytes)
Expand Down
6 changes: 3 additions & 3 deletions lib/lin.ml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -181,9 +181,9 @@ let int = GenDeconstr (QCheck.int, QCheck.Print.int, (=))
let int_small = GenDeconstr (QCheck.small_int, QCheck.Print.int, (=))
let int_pos = GenDeconstr (QCheck.pos_int, QCheck.Print.int, (=))
let int_bound b = GenDeconstr (QCheck.int_bound b, QCheck.Print.int, (=))
let int32 = GenDeconstr (QCheck.int32, Int32.to_string, Int32.equal)
let int64 = GenDeconstr (QCheck.int64, Int64.to_string, Int64.equal)
let nat64_small = GenDeconstr (qcheck_nat64_small, Int64.to_string, Int64.equal)
let int32 = GenDeconstr (QCheck.int32, QCheck.Print.int32, Int32.equal)
let int64 = GenDeconstr (QCheck.int64, QCheck.Print.int64, Int64.equal)
let nat64_small = GenDeconstr (qcheck_nat64_small, QCheck.Print.int64, Int64.equal)
let float = GenDeconstr (QCheck.float, QCheck.Print.float, Float.equal)
let string = GenDeconstr (string, QCheck.Print.string, String.equal)
let string_small = GenDeconstr (string_small, QCheck.Print.string, String.equal)
Expand Down
Loading